Signed-off-by: NVinod Koul <vinod.koul@linux.intel.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Commit ALSA: compress_core: integer overflow in snd_compr_allocate_buffer()
added a new error check for input params.
this add new routine for input checks and moves buffer overflow check to this
new routine. This allows the error value to be propogated to user space
Signed-off-by: NVinod Koul <vinod.koul@linux.intel.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

These are 32 bit values that come from the user, we need to check for
integer overflows or we could end up allocating a smaller buffer than
expected.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

O_RDONLY is zero so the original test (f->f_flags & O_RDONLY) is always
false and it will never do compress capture.  The test for O_WRONLY is
also slightly off.  The original test would consider "->flags =
(O_WRONLY | O_RDWR)" as write only instead of rejecting it as invalid.

I've also removed the pr_err() because that could flood dmesg.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

as the start can be called after stop again, we need to reset state
Signed-off-by: NNamarta Kohli <namartax.kohli@intel.com>
Signed-off-by: NVinod Koul <vinod.koul@linux.intel.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

during pause the core should maintain the status-quo on the device and pointers
and not wake up. If app needs it should call DROP explcitly.
Signed-off-by: NNamarta Kohli <namartax.kohli@intel.com>
Signed-off-by: NVinod Koul <vinod.koul@linux.intel.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

If copy_from_user() does not return 0 we'll leak the memory we
allocated for 'params' when that variable goes out of scope.

Also a small CodingStyle cleanup: Use braces on both branches of
if/else when one branch needs it.
Signed-off-by: NJesper Juhl <jj@chaosbits.net>
Acked-by: NVinod Koul <vinod.koul@linux.intel.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

This patch adds core.c, the file which implements the ioctls and
registers the devices
Signed-off-by: NVinod Koul <vinod.koul@linux.intel.com>
Signed-off-by: NPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>