This patch removes a definition that was not used in driver xgifb
Signed-off-by: NSarah Khan <sarahjmi07@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

A comment about a pre-existing bug data structure definition is added.
This bug was evidently introduced by Xiong Zhou in the patch
bd471258 ("staging: android: logger: use kuid_t instead of uid_t")
where the code was changed to hide a valid build warning instead of
solving the bug that was identified by it.
Signed-off-by: NSomya Anand <somyaanand214@gmail.com>
Reviewed-by: NArnd Bergmann <arnd@arndb.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

WARNING: space prohibited before semicolon

Signed-off-by: Surya Seetharaman<suryaseetharaman.9@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

WARNING: void function return statements are not generally useful
Signed-off-by: NSurya Seetharaman <suryaseetharaman.9@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
Signed-off-by: NSurya Seetharaman <suryaseetharaman.9@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch introduces the use of function put_unaligned_le16.

This is done using Coccinelle and semantic patch used is as follows:

@@ identifier tmp; expression ptr; expression y,e; type T; @@

- tmp = cpu_to_le16(y);

  <+... when != tmp
- memcpy(ptr, (T)&tmp, ...);
+ put_unaligned_le16(y,ptr);
  ...+>
? tmp = e

@@ type T; identifier tmp; @@

- T tmp;
...when != tmp

Here, unnecessory comment after change is removed too.
This patch also fixes sparse warnings in file ieeee80211_softmac.c.
Signed-off-by: NVaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch introduces the use of function put_unaligned_le16.

This is done using Coccinelle and semantic patch used is as follows:

@@ identifier tmp; expression ptr; expression y,e; type T; @@

- tmp = cpu_to_le16(y);

  <+... when != tmp
- memcpy(ptr, (T)&tmp, ...);
+ put_unaligned_le16(y,ptr);
  ...+>
? tmp = e

@@ type T; identifier tmp; @@

- T tmp;
...when != tmp

Here, to be compatible with the change header file is added too.
Signed-off-by: NVaishali Thakkar <vthakkar1994@gmail.com>
Reviewed-by: NArnd Bergmann <arnd@arndb.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes the static functions bthci_CmdSetEventFilter,
bthci_CmdReadRSSI and bthci_CmdHostNumberOfCompletedPackets, since their
body only consists of 'return HCI_STATUS_SUCCESS'.
Signed-off-by: NRoberta Dobrescu <roberta.dobrescu@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch introduces the use of function put_unaligned_le64.

This is done using Coccinelle and semantic patch used is as follows:

@@ identifier tmp; expression ptr; expression y,e; type T; @@

- tmp = cpu_to_le64(y);

  <+... when != tmp
- memcpy(ptr, (T)&tmp, ...);
+ put_unaligned_le64(y,ptr);
  ...+>
? tmp = e

@@ type T; identifier tmp; @@

- T tmp;
...when != tmp
Signed-off-by: NVaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

ksock_net_t uses a __u64 quantity as an 'incarnation' timestamp. This is also
passed on in hello messages and used to detect if a reboot has occurred.
This 'incarnation' is obtained using do_gettimeofday.It is only used in equality
checks, so the absolute value does not matter.

This patch replaces do_gettimeofday with ktime_get_ns for the following reasons:
1. ktime_get_ns returns a __u64 which is safer than 'struct timeval'
which will overflow on 32-bit systems in year 2038 and beyond.
2. Reduced compute: ktime_get_ns is faster than the multiply/add
   combination used in this function
Signed-off-by: NTina Ruchandani <ruchandani.tina@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes checkpatch.pl warning in files of rtl8188eu
WARNING: else is not generally useful after a break or return
Signed-off-by: NDilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes some unneeded white space after casts within the
channel.c file.  The checkpatch script was run after these changes,
and no further checks or warnings were seen.
Signed-off-by: NKen Depro <kenneth.depro@unisys.com>
Signed-off-by: NBen Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename the following local variables in virtpci_device_add()
pIoChan changed to io_chan
pDev changed to dev
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename the following local variables in fix_vbus_dev_info()
Change pChan to chan
Change devInfo to dev_info
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename the following fix_vbus_dev_info() parameters
devNo changed to dev_no
devType changed to dev_type
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename fix_vbus_devInfo() to fix_vbus_dev_info().
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename pDev to dev in delete_vbus_device()
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename write_vbus_devInfo() to write_vbus_dev_info() in virtpci.c
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename write_vbus_busInfo() to write_vbus_bus_info() in virtpci.c
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename write_vbus_chpInfo() to write_vbus_chp_info() in virtpci.c
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename BusDriverInfo variable to bus_driver_info in virtpci.c
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename VpcidevListLock to vpcidev_list_lock in virtpci.c
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename VpcidevListHead to vpcidev_list_head in virtpci.c
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename Chipset_DriverInfo to chipset_driver_info in virtpci.c
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Delete the macros and related preprocessor code for DBG_GETFILE_PAYLOAD(),
DBG_GETFILE(), and DBG_PUTFILE().
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

No one is using this definition so remove it.
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix CamelCase parameter names:

busNo => bus_no
devNo => dev_no
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix CamelCase parameter:

busNo => bus_no
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Delete visorchipset_get_switch_info() and visorchipset_get_externalport_info()
as these functions were declared but not defined, or used.
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix CamelCase names:

busNo => bus_no
devNo => dev_no
devInfo => dev_info
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix CamelCase names:

busNo => bus_no
busInfo => bus_info
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix CamelCase parameters:

busNo => bus_no
devNo => dev_no
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix CamelCase name:

driverInfo => driver_info
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix CamelCase parameter:

driverInfo => driver_info
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Get rid of the typedef and just use struct visorchipset_busdev_responders
instead. Fix CamelCase parameter names in the function pointer definitions for
the structure:

busNo => bus_no
devNo => dev_no

Update references to changed names.
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Get rid of the typedef and just use struct visorchipset_busdev_notifiers
instead. Fix CamelCase names in parameters for the function pointers:

busNo => bus_no
devNo => dev_no
typeGuid => type_uuid
minSize => min_size
maxSize => max_size

Update references.
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Get rid of the typedef and use struct visorchipset_internalport_info and fix
CamelCase member names:

switchNo => switch_no
internalPortNo => internal_port_no
busNo => bus_no
devNo => dev_no
Reserved1 => reserved1
Reserved2 => reserved2
pendingMsgHdr => pending_msg_hdr
procObject => proc_object
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>

Remove the typedef and just use struct visorchipset_externalport_info instead.
Fix all CamelCase names:

switchNo => switch_no
externalPortNo => external_port_no
networkZoneGuid => network_zone_uuid
pdPort => pd_port
ipNetmask => ip_netmask
ipBroadcast => ip_broadcast
ipNetwork => ip_network
ipGateway => ip_gateway
ipDNS => ip_dns
Reserved1 => reserved1
Reserved2 => reserved2
pendingMsgHdr => pending_msg_hdr
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>

Remove the typedef and use struct visorchipset_switch_info instead. Fix all
CamelCase member names:

switchNo => switch_no
switchTypeGuid => switch_type_uuid
authService1 => authservice1
authService2 => authservice2
authService3 => authservice3
securityContext => security_context
Reserved => reserved
Reserved2 => reserved2
pendingMsgHdr => pending_msg_hdr
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>

Fix the CamelCase parameter name in findbus() in visorchipset.h.

busNo => bus_no
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>