crystalhd_fw_if.h: indentation fix (spaces to tabs)
The rest are brackets.

NOTE: there are quite some 80 character warnings, but they look in place,
comments mostly on the right next to the constants and stuff like that. I
haven't touched them, since this rule is 'going away', but in case you would
like it to be fixed, let me know.

I'm sending 2 patches, but it they aren't connected in any way, so doesn't
matter the apply order. It's just a cleanup.

P.S sorry for the first lame patches a couple of days ago
Signed-off-by: NArvydas Sidorenko <asido4@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix long lines in cx25821-video-upstream.h
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix long lines in cx25821-video-upstream.c
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix long lines in cx25821-video-upstream-ch2.h
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix long lines in cx25821-video-upstream-ch2.c
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change obscure line endings to less obscure ones. Rationale: improve
readability.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Delete whitespace characters before labels.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Replace :? operator by if-else equivalent where it improves readability.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix long lines in cx25821-audio-upstream.h
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix long lines in cx25821-audio-upstream.c
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change obscure line endings to less obscure ones. Rationale: more
readable.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix too long lines in cx25821-audio.h
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix wrong brace placement and statement indent in cx25821-i2c.c
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix wrong brace placement and statement indent in cx25821-core.c
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix wrong brace placement and statement indent in cx25821-cards.c
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Move EXPORT_SYMBOL(cx25821_set_gpiopin_direction) to the right place.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Delete file cx25821-gpio.h since it is not used.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Rename _audio_upstream_channel_select to _audio_upstream_channel in
in struct cx25821_dev in cx25821.h and all usages of that struct member
as well, because _audio_upstream_channel_select is seems to be too long
for a variable name.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Get rid of typedef in cx25821.h
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: NValdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fixes sparse warning:
zram_drv.c:666:6: warning: symbol 'zram_slot_free_notify' was not
declared. Should it be static?

Also, max_zpage_size is now size_t just to be consistent with data-type
of other variables maintaining sizes of various kinds.
Signed-off-by: NNitin Gupta <ngupta@vflare.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

V3 is a straightforward forward port to teh current tree of V2.

Simple fix is to just not cache REG_TEST (offset 8).
Cache doesn't help REG_TEST anyway since we write all 8 bits exactly once
(at resume/init time).

Also fix an "off-by-one" allocation of reg_cache[] array size that
was in the original code before I touched it.
Reported-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGrant Grundler <grundler@chromium.org>
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Cleanup dated comments in channel_mgmt.c.
Signed-off-by: NK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The vmbus devices are NOT child devices; rename vmbus_child_device_unregister
to reflect this.
Signed-off-by: NK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The vmbus devices are NOT child devices; rename vmbus_child_device_register
to reflect this.
Signed-off-by: NK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The vmbus devices are NOT child devices; rename vmbus_child_device_create
to reflect this.
Signed-off-by: NK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

There is no reason to cache the irq_handler in struct dt3155_priv.  Just pass
the function directly in request_irq.
Signed-off-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Most of the printk's in this driver are just noise. Proper error codes
are being returned so just remove the noise and clean up the whitespace
in the code due to the removal.

The two messages left in the probe are useful. Convert them to dev_info
messages.
Signed-off-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NOren Weil <oren.jer.weil@intel.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NOren Weil <oren.jer.weil@intel.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

wd module parameter is not needed now that driver is using watchdog core.
Signed-off-by: NOren Weil <oren.jer.weil@intel.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

starting removing the dependency from the module parameters.
setting the default timeout on init so don't need to check if it is bigger
then zero.
Signed-off-by: NOren Weil <oren.jer.weil@intel.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

the timer_work does not only handle watchdog but also handles mei timeouts.
Signed-off-by: NOren Weil <oren.jer.weil@intel.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

the wd_work and mei_wd_timer() function was not just for watchdog.
mei managing the AMT watchdog going to be replace by the kernel watchdog
interface.

the mei_timer() will still manage the mei driver timeouts.
Signed-off-by: NOren Weil <oren.jer.weil@intel.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

add the ability to let the watchdog core set
the AMT watchdog timeout value.

the default value will be only set in the start function.
Signed-off-by: NOren Weil <oren.jer.weil@intel.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

adding watchdog ping to send ping/heartbeat to the the AMT watchdog client.
in addition removing the heartbeat sending from the driver timers function.
Signed-off-by: NOren Weil <oren.jer.weil@intel.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

adding start and stop function.
start - check if AMT wd client is connected, which is been connected on driver
load.
stop - send stop command to AMT wd.
Signed-off-by: NOren Weil <oren.jer.weil@intel.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Adding kernel watchdog interface (/dev/watchdog) to the MEI Driver to support AMT Watchdog feature.
This patch and the following one will replace MEI Driver self management of the AMT watchdog
with the standard kernel watchdog interface.
Signed-off-by: NOren Weil <oren.jer.weil@intel.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NOren Weil <oren.jer.weil@intel.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>