1. 16 12月, 2008 2 次提交
  2. 27 11月, 2008 2 次提交
  3. 21 11月, 2008 1 次提交
  4. 20 11月, 2008 1 次提交
  5. 13 11月, 2008 1 次提交
    • S
      RDMA/cxgb3: Fix deadlock in iw_cxgb3 (hang when configuring interface) · b3e123cf
      Steve Wise 提交于
      When the iw_cxgb3 module's cxgb3_client "add" func gets called by the
      cxgb3 module, the iwarp driver ends up calling the ethtool ops
      get_drvinfo function in cxgb3 to get the fw version and other info.
      Currently the iwarp driver grabs the rtnl lock around this down call
      to serialize.  As of 2.6.27 or so, things changed such that the rtnl
      lock is held around the call to the netdev driver open function.  Also
      the cxgb3_client "add" function doesn't get called if the device is
      down.
      
      So, if you load cxgb3, then load iw_cxgb3, then ifconfig up the
      device, the iw_cxgb3 add func gets called with the rtnl_lock held.  If
      you load cxgb3, ifconfig up the device, then load iw_cxgb3, the add
      func gets called without the rtnl_lock held.  The former causes the
      deadlock, the latter does not.
      
      In addition, there are iw_cxgb3 sysfs handlers that also can call down
      into cxgb3 to gather the fw and hw versions.  These can be called
      concurrently on different processors and at any time.  Thus we need to
      push this serialization down in the cxgb3 driver get_drvinfo func.
      
      The fix is to remove rtnl lock usage, and use a per-device lock in cxgb3.
      Signed-off-by: NSteve Wise <swise@opengridcomputing.com>
      Acked-by: NDivy Le Ray <divy@chelsio.com>
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      b3e123cf
  6. 11 11月, 2008 2 次提交
    • S
      RDMA/cxgb3: deadlock in iw_cxgb3 can cause hang when configuring interface. · cf3760da
      Steve Wise 提交于
      When the iw_cxgb3 module's cxgb3_client "add" func gets called by the
      cxgb3 module, the iwarp driver ends up calling the ethtool ops get_drvinfo
      function in cxgb3 to get the fw version and other info.  Currently the
      iwarp driver grabs the rtnl lock around this down call to serialize.
      As of 2.6.27 or so, things changed such that the rtnl lock is held around
      the call to the netdev driver open function.  Also the cxgb3_client "add"
      function doesn't get called if the device is down.
      
      So, if you load cxgb3, then load iw_cxgb3, then ifconfig up the device,
      the iw_cxgb3 add func gets called with the rtnl_lock held.   If you
      load cxgb3, ifconfig up the device, then load iw_cxgb3, the add func
      gets called without the rtnl_lock held.  The former causes the deadlock,
      the latter does not.
      
      In addition, there are iw_cxgb3 sysfs handlers that also can call
      down into cxgb3 to gather the fw and hw versions.  These can be called
      concurrently on different processors and at any time.  Thus we need to
      push this serialization down in the cxgb3 driver get_drvinfo func.
      
      The fix is to remove rtnl lock usage, and use a per-device lock in cxgb3.
      Signed-off-by: NSteve Wise <swise@opengridcomputing.com>
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      cf3760da
    • D
      cxgb3 - Limit multiqueue setting to msi-x · f9ee3882
      Divy Le Ray 提交于
      Allow multiqueue setting in MSI-X mode only
      Signed-off-by: NDivy Le Ray <divy@chelsio.com>
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      f9ee3882
  7. 31 10月, 2008 1 次提交
  8. 14 10月, 2008 1 次提交
  9. 09 10月, 2008 6 次提交
  10. 22 5月, 2008 1 次提交
  11. 13 5月, 2008 2 次提交
  12. 07 5月, 2008 1 次提交
  13. 18 4月, 2008 1 次提交
    • D
      cxgb3: Fix __must_check warning with dev_dbg. · d96a51f6
      Dan Noe 提交于
      Fix the warning:
      drivers/net/cxgb3/cxgb3_main.c: In function ‘offload_open’:
      drivers/net/cxgb3/cxgb3_main.c:936: warning: ignoring return value of
       ‘sysfs_create_group’, declared with attribute warn_unused_result
      
      Now the return value is checked; if sysfs_create_group() returns failure,
      a warning is printed using dev_dbg, and the code continues as before.  Use
      of dev_dbg ensures printk is not needlessly included unless desired for
      debugging.
      Signed-off-by: NDan Noe <dpn@isomerica.net>
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      d96a51f6
  14. 29 1月, 2008 10 次提交
  15. 11 10月, 2007 8 次提交