1. 22 5月, 2013 1 次提交
    • T
      leds: leds-gpio: reserve gpio before using it · 803d19d5
      Timo Teräs 提交于
      This reverts commit a99d76f9 (leds: leds-gpio: use gpio_request_one)
      and commit 2d7c22f6 (leds: leds-gpio: set devm_gpio_request_one()
      flags param correctly) which was a fix of the first one.
      
      The conversion to devm_gpio_request in commit e3b1d44c (leds:
      leds-gpio: use devm_gpio_request_one) is not reverted.
      
      The problem is that gpio_cansleep() and gpio_get_value_cansleep()
      calls can crash if the gpio is not first reserved. Incidentally this
      same bug existed earlier and was fixed similarly in commit d95cbe61
      (leds: Fix potential leds-gpio oops). But the OOPS is real. It happens
      when GPIOs are provided by module which is not yet loaded.
      
      So this fixes the following BUG during my ALIX boot (3.9.2-vanilla):
      
      BUG: unable to handle kernel NULL pointer dereference at 0000004c
      IP: [<c11287d6>] __gpio_cansleep+0xe/0x1a
      *pde = 00000000
      Oops: 0000 [#1] SMP
      Modules linked in: leds_gpio(+) via_rhine mii cs5535_mfd mfd_core
      geode_rng rng_core geode_aes isofs nls_utf8 nls_cp437 vfat fat
      ata_generic pata_amd pata_cs5536 pata_acpi libata ehci_pci ehci_hcd
      ohci_hcd usb_storage usbcore usb_common sd_mod scsi_mod squashfs loop
      Pid: 881, comm: modprobe Not tainted 3.9.2 #1-Alpine
      EIP: 0060:[<c11287d6>] EFLAGS: 00010282 CPU: 0
      EIP is at __gpio_cansleep+0xe/0x1a
      EAX: 00000000 EBX: cf364018 ECX: c132b8b9 EDX: 00000000
      ESI: c13993a4 EDI: c1399370 EBP: cded9dbc ESP: cded9dbc
       DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
      CR0: 8005003b CR2: 0000004c CR3: 0f0c4000 CR4: 00000090
      DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
      DR6: ffff0ff0 DR7: 00000400
      Process modprobe (pid: 881, ti=cded8000 task=cf094aa0 task.ti=cded8000)
      Stack:
       cded9de0 d09471cb 00000000 c1399260 cf364014 00000000 c1399260 c1399254
       d0949014 cded9df4 c118cd59 c1399260 d0949014 d0949014 cded9e08 c118ba47
       c1399260 d0949014 c1399294 cded9e1c c118bb75 cded9e24 d0949014 00000000
      Call Trace:
       [<d09471cb>] gpio_led_probe+0xba/0x203 [leds_gpio]
       [<c118cd59>] platform_drv_probe+0x26/0x48
       [<c118ba47>] driver_probe_device+0x75/0x15c
       [<c118bb75>] __driver_attach+0x47/0x63
       [<c118a727>] bus_for_each_dev+0x3c/0x66
       [<c118b6f9>] driver_attach+0x14/0x16
       [<c118bb2e>] ? driver_probe_device+0x15c/0x15c
       [<c118b3d5>] bus_add_driver+0xbd/0x1bc
       [<d08b4000>] ? 0xd08b3fff
       [<d08b4000>] ? 0xd08b3fff
       [<c118bffc>] driver_register+0x74/0xec
       [<d08b4000>] ? 0xd08b3fff
       [<c118c8e8>] platform_driver_register+0x38/0x3a
       [<d08b400d>] gpio_led_driver_init+0xd/0x1000 [leds_gpio]
       [<c100116c>] do_one_initcall+0x6b/0x10f
       [<d08b4000>] ? 0xd08b3fff
       [<c105e918>] load_module+0x1631/0x1907
       [<c10975d6>] ? insert_vmalloc_vmlist+0x14/0x43
       [<c1098d5b>] ? __vmalloc_node_range+0x13e/0x15f
       [<c105ec50>] sys_init_module+0x62/0x77
       [<c1257888>] syscall_call+0x7/0xb
      EIP: [<c11287d6>] __gpio_cansleep+0xe/0x1a SS:ESP 0068:cded9dbc
      CR2: 000000000000004c
       ---[ end trace 5308fb20d2514822 ]---
      Signed-off-by: NTimo Teräs <timo.teras@iki.f>
      Cc: Sachin Kamat <sachin.kamat@linaro.org>
      Cc: Raphael Assenat <raph@8d.com>
      Cc: Trent Piepho <tpiepho@freescale.com>
      Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
      Cc: Arnaud Patard <arnaud.patard@rtp-net.org>
      Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
      Acked-by: NJingoo Han <jg1.han@samsung.com>
      Signed-off-by: NBryan Wu <cooloney@gmail.com>
      803d19d5
  2. 21 5月, 2013 7 次提交
  3. 20 5月, 2013 5 次提交
  4. 19 5月, 2013 7 次提交
    • J
      hwmon: (tmp401) Drop redundant safety on cache lifetime · 4e2284d2
      Jean Delvare 提交于
      time_after (as opposed to time_after_equal) already ensures that the
      cache lifetime is at least as much as requested. There is no point in
      manually adding another jiffy to that value, and this can confuse the
      reader into wrong interpretation.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Cc: Imre Deak <imre.deak@intel.com>
      Cc: Guenter Roeck <linux@roeck-us.net>
      Signed-off-by: NGuenter Roeck <linux@roeck-us.net>
      4e2284d2
    • L
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs · 130901ba
      Linus Torvalds 提交于
      Pull btrfs fixes from Chris Mason:
       "Miao Xie has been very busy, fixing races and enospc problems and many
        other small but important pieces.
      
        Alexandre Oliva discovered some problems with how our error handling
        was interacting with the block layer and for now has disabled our
        partial handling of sub-page writes.  The real sub-page work is in a
        series of patches from IBM that we still need to integrate and test.
        The code Alexandre has turned off was really incomplete.
      
        Josef has more error handling fixes and an important fix for the new
        skinny extent format.
      
        This also has my fix for the tracepoint crash from late in 3.9.  It's
        the first stage in a larger clean up to get rid of btrfs_bio and make
        a proper bioset for all the items we need to tack into the bio.  For
        now the bioset only holds our mirror_num and stripe_index, but for the
        next merge window I'll shuffle more in."
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs: (25 commits)
        Btrfs: use a btrfs bioset instead of abusing bio internals
        Btrfs: make sure roots are assigned before freeing their nodes
        Btrfs: explicitly use global_block_rsv for quota_tree
        btrfs: do away with non-whole_page extent I/O
        Btrfs: don't invoke btrfs_invalidate_inodes() in the spin lock context
        Btrfs: remove BUG_ON() in btrfs_read_fs_tree_no_radix()
        Btrfs: pause the space balance when remounting to R/O
        Btrfs: fix unprotected root node of the subvolume's inode rb-tree
        Btrfs: fix accessing a freed tree root
        Btrfs: return errno if possible when we fail to allocate memory
        Btrfs: update the global reserve if it is empty
        Btrfs: don't steal the reserved space from the global reserve if their space type is different
        Btrfs: optimize the error handle of use_block_rsv()
        Btrfs: don't use global block reservation for inode cache truncation
        Btrfs: don't abort the current transaction if there is no enough space for inode cache
        Correct allowed raid levels on balance.
        Btrfs: fix possible memory leak in replace_path()
        Btrfs: fix possible memory leak in the find_parent_nodes()
        Btrfs: don't allow device replace on RAID5/RAID6
        Btrfs: handle running extent ops with skinny metadata
        ...
      130901ba
    • L
      Merge branch 'devm_no_resource_check' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux · e5106682
      Linus Torvalds 提交于
      Pull devm usage cleanup from Wolfram Sang:
       "Lately, I have been experimenting how to improve the devm interface to
        make writing device drivers easier and less error prone while also
        getting rid of its subtle issues.  I think it has more potential but
        still needs work and definately conistency, especiall in its usage.
      
        The first thing I come up with is a low hanging fruit regarding
        devm_ioremap_resouce().  This function already checks if the passed
        resource is valid and gives an error message if not.  So, we can
        remove similar checks from the drivers and get rid of a bit of code
        and a number of inconsistent error strings.
      
        This series only removes the unneeded check iff devm_ioremap_resource
        follows platform_get_resource directly.  The previous version tried to
        shuffle code if needed, too, what lead to an embarrasing bug.  It
        turned out to me that shuffling code for all cases found will make the
        automated script too complex, so I am unsure if an automated cleanup
        is the proper tool for this case.  Removing the easy stuff seems
        worthwhile to me, though.
      
        Despite various architectures and platform dependencies, I managed to
        compile test 45 out of 57 modified files locally using heuristics and
        defconfigs."
      
      Pulled because: 296 deletions, 0 additions.
      
      * 'devm_no_resource_check' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux: (33 commits)
        sound/soc/kirkwood: don't check resource with devm_ioremap_resource
        sound/soc/fsl: don't check resource with devm_ioremap_resource
        arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource
        arch/arm/plat-samsung: don't check resource with devm_ioremap_resource
        arch/arm/mach-tegra: don't check resource with devm_ioremap_resource
        drivers/watchdog: don't check resource with devm_ioremap_resource
        drivers/w1/masters: don't check resource with devm_ioremap_resource
        drivers/video/omap2/dss: don't check resource with devm_ioremap_resource
        drivers/video/omap2: don't check resource with devm_ioremap_resource
        drivers/usb/phy: don't check resource with devm_ioremap_resource
        drivers/usb/host: don't check resource with devm_ioremap_resource
        drivers/usb/gadget: don't check resource with devm_ioremap_resource
        drivers/usb/chipidea: don't check resource with devm_ioremap_resource
        drivers/thermal: don't check resource with devm_ioremap_resource
        drivers/staging/nvec: don't check resource with devm_ioremap_resource
        drivers/staging/dwc2: don't check resource with devm_ioremap_resource
        drivers/spi: don't check resource with devm_ioremap_resource
        drivers/rtc: don't check resource with devm_ioremap_resource
        drivers/pwm: don't check resource with devm_ioremap_resource
        drivers/pinctrl: don't check resource with devm_ioremap_resource
        ...
      e5106682
    • L
      Merge tag 'devicetree-for-linus' of git://git.secretlab.ca/git/linux · ff9129b0
      Linus Torvalds 提交于
      Pull device tree fixes from Grant Likely:
       "Device tree bug fixes and documentation updates for v3.10
      
        Nothing earth shattering here.  A build failure fix, and fix for
        releasing nodes and some documenation updates."
      
      * tag 'devicetree-for-linus' of git://git.secretlab.ca/git/linux:
        Documentation/devicetree: make semantic of initrd-end more explicit
        of/base: release the node correctly in of_parse_phandle_with_args()
        of/documentation: move video device bindings to a common place
        <linux/of_platform.h>: fix compilation warnings with DT disabled
      ff9129b0
    • L
      Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus · 3c6a279f
      Linus Torvalds 提交于
      Pull MIPS fixes from Ralf Baechle:
       "Patching up across the field.  The reversion of the two ASID patches
        is particularly important as it was breaking many platforms."
      
      * 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus:
        MIPS: ralink: use the dwc2 driver for the rt305x USB controller
        MIPS: Extract schedule_mfi info from __schedule
        MIPS: Fix sibling call handling in get_frame_info
        MIPS: MSP71xx: remove inline marking of EXPORT_SYMBOL functions
        MIPS: Make virt_to_phys() work for all unmapped addresses.
        MIPS: Fix build error for crash_dump.c in 3.10-rc1
        MIPS: Xway: Fix clk leak
        Revert "MIPS: Allow ASID size to be determined at boot time."
        Revert "MIPS: microMIPS: Support dynamic ASID sizing."
      3c6a279f
    • L
      Merge tag 'kmemleak-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/cmarinas/linux-aarch64 · 8f05bde9
      Linus Torvalds 提交于
      Pull kmemleak patches from Catalin Marinas:
       "Kmemleak now scans all the writable and non-executable module sections
        to avoid false positives (previously it was only scanning specific
        sections and missing .ref.data)."
      
      * tag 'kmemleak-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/cmarinas/linux-aarch64:
        kmemleak: No need for scanning specific module sections
        kmemleak: Scan all allocated, writeable and not executable module sections
      8f05bde9
    • L
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/cmarinas/linux-aarch64 · f71df633
      Linus Torvalds 提交于
      Pull arm64 fixes from Catalin Marinas:
       "Fixes for duplicate definition of early_console, kernel/time/Kconfig
        include, __flush_dcache_all() set/way computing, debug (locking, bit
        testing).  The of_platform_populate() was moved to an arch_init_call()
        to allow subsys_init_call() drivers to probe the DT."
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/cmarinas/linux-aarch64:
        arm64: debug: fix mdscr.ss check when enabling debug exceptions
        arm64: Do not source kernel/time/Kconfig explicitly
        arm64: mm: Fix operands of clz in __flush_dcache_all
        arm64: Invoke the of_platform_populate() at arch_initcall() level
        arm64: debug: clear mdscr_el1 instead of taking the OS lock
        arm64: Fix duplicate definition of early_console
      f71df633
  5. 18 5月, 2013 20 次提交