This patch fixes checkpatch.pl error in baseband.c file
ERROR : that open brace { should be on the previous line
Signed-off-by: NTapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes checkpatch.pl warning in aes_ccmp.c file
WARNING : else is not generally useful after a break or return
Signed-off-by: NTapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch merges an assignment with an immediately following return of
the assigned variable.  The following Coccinelle semantic patch was used
to make this transformation:

@@
expression ret;
identifier f;
@@

-ret =
+return
     f(...);
-return ret;

A variable that became unused due to this transformation was also removed.
Signed-off-by: NMahati Chamarthy <mahati.chamarthy@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch merges an assignment with an immediately following return of
the assigned variable.The following Coccinelle semantic patch was used to make this transformation:

@@
expression ret;
identifier f;
@@

-ret =
+return
     f(...);
-return ret;

A variable that became unused due to this transformation was also removed.
Signed-off-by: NMahati Chamarthy <mahati.chamarthy@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes these error messages found by checkpatch.pl:
ERROR: do not use C99 // comments
Signed-off-by: NAybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixes "braces {} are not necessary for single statement blocks"
checkpatch.pl warnings in dgnc_sysfs.c
Signed-off-by: NGulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The function ULTRA_check_channel_client() was recently patched to use
ioread8_rep(). Unfortunately the parameters were incorrectly ordered, and this
causes the function to fail and the guest to not boot.

This patch switches the parameters around and uses memcpy_fromio() instead,
which is clearer since a structure is being copied, not an array, and it
fixes the error message printout later in the function that was using the UUID
value in the channel, rather than the value copied from the channel, which
causes a misleading error to be reported.
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes these warning messages found by checkpatch.pl:
WARNING : Missing a blank line after declarations.
Signed-off-by: NAybuke Ozdemir <aybuke.147@gmail.com>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This fixes the following checkpatch.pl warning:
WARNING: void function return statements are not generally useful
Signed-off-by: NCatalina Mocanu <catalina.mocanu@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This fixes the following checkpatch.pl warning:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: NCatalina Mocanu <catalina.mocanu@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes following checkpatch.pl warning:

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
Signed-off-by: NVaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes checkpatch.pl warning in files of speakup
WARNING : Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends
Signed-off-by: NTapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Removes void function return statements.
Signed-off-by: NErin Grasmick <ecg@unseen.is>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NErin Grasmick <ecg@unseen.is>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes these warning messages found by checkpatch.pl:
WARNING : Missing a blank line after declarations.
Signed-off-by: NAybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix for unnecessary return at end of function as diagnosed by checkpatch.pl.
Signed-off-by: NErin Grasmick <ecg@unseen.is>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This fixes the warning:
WARNING: Missing a blank line after declarations
Signed-off-by: NRoxana Blaj <roxanagabriela10@gmail.com>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The following checkpatch warning was fixed :

WARNING: Missing a blank line after declarations
Signed-off-by: NTina Johnson <tinajohnson.1234@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This fixes the warning:
WARNING: void function return statements are not generally useful
Signed-off-by: NRoxana Blaj <roxanagabriela10@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This fixes the warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: NRoxana Blaj <roxanagabriela10@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes "void function return statements are not generally
useful" checkpatch.pl warning in base.c
Signed-off-by: NGulsah Kose <gulsah.1004@gmail.com>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NMark Einon <mark.einon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename adapter->flowcontrol to adapter->flow, reducing split lines.
Signed-off-by: NMark Einon <mark.einon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The 'if' blocks have braces, so the 'else' blocks should too.
Signed-off-by: NMark Einon <mark.einon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Modify some packet status ring associated variables to save a few
split lines:

pktstat_ringsize -> psr_size
psr_num_entries -> psr_entries
index -> ii
Signed-off-by: NMark Einon <mark.einon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Modify temporary variables so that split lines can be reduced:

index -> k
fbr_tmp_physaddr -> fbr_physaddr
Signed-off-by: NMark Einon <mark.einon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This ce_stats struct member is no longer used. Remove it.
Signed-off-by: NMark Einon <mark.einon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

These two defines are not used, so remove them.
Signed-off-by: NMark Einon <mark.einon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

These two adapter struct members are not used, remove them.
Signed-off-by: NMark Einon <mark.einon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixes "Missing a blank line after declarations"
checkpatch.pl warning in ethernet-xaui.c
Signed-off-by: NAybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes checkpatch.pl warning in lirc_serial.c file
WARNING : break is not useful after goto or return
Signed-off-by: NTapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes checkpatch.pl warning in file lirc_serial.c
WARNING : else is not generally useful after a break or return
Signed-off-by: NTapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes "quoted string split across lines" checkpatch.pl
warning in lirc_imon.c.
Signed-off-by: NGulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixes "Missing a blank line after declarations" checkpatch.pl warning in
iss_video.c
Signed-off-by: NGulsah Kose <gulsah.1004@gmail.com>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixes "Missing a blank line after declarations" checkpatch.pl warning in
iss_csi2.c
Signed-off-by: NGulsah Kose <gulsah.1004@gmail.com>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch.pl "open brace '{' following struct go on the same line" errors
Signed-off-by: NGreg Donald <gdonald@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The following patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters.
Signed-off-by: NAybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes following checkpatch.pl warning using coccinelle:

WARNING: else is not generally useful after a break or return

Semantic patch used for this is as follows:

@rule1@
expression e1;
@@

        if (e1) { ... return ...; }
-       else{
                ...
-       }

@rule2@
expression e2;
statement s1;
@@

        if(e2) { ... return ...; }
-       else
                s1
Signed-off-by: NVaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes following checkpatch.pl warning using coccinelle:

WARNING: else is not generally useful after a break or return

Semantic patch used for this is as follows:

@rule1@
expression e1;
@@

        if (e1) { ... return ...; }
-       else{
                ...
-       }

@rule2@
expression e2;
statement s1;
@@

        if(e2) { ... return ...; }
-       else
                s1
Signed-off-by: NVaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The GOTO macro is neither standard in Linux nor does its definiton
contain much useful code. Hence GOTO can be replaced with useful
parts of its definition. In a statement like GOTO(label, rc), the
replacing code will be goto label if rc is a constant or a variable.
But in cases like GOTO(label, e) where e is an assignment statement,
both assignment and goto statements are kept.

This patch was done using Coccinelle and the following semantic
patch was used:

@@
identifier rc,label;
expression e;
constant c;
@@

(
-GOTO(label,rc = e);
+rc = e;
+goto label;
|
-GOTO(label,rc);
+goto label;
|
-GOTO(label,c);
+goto label;
)
Signed-off-by: NTina Johnson <tinajohnson.1234@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>