1. 24 2月, 2013 1 次提交
  2. 13 2月, 2013 1 次提交
    • R
      ACPI / hotplug: Fix concurrency issues and memory leaks · 3757b948
      Rafael J. Wysocki 提交于
      This changeset is aimed at fixing a few different but related
      problems in the ACPI hotplug infrastructure.
      
      First of all, since notify handlers may be run in parallel with
      acpi_bus_scan(), acpi_bus_trim() and acpi_bus_hot_remove_device()
      and some of them are installed for ACPI handles that have no struct
      acpi_device objects attached (i.e. before those objects are created),
      those notify handlers have to take acpi_scan_lock to prevent races
      from taking place (e.g. a struct acpi_device is found to be present
      for the given ACPI handle, but right after that it is removed by
      acpi_bus_trim() running in parallel to the given notify handler).
      Moreover, since some of them call acpi_bus_scan() and
      acpi_bus_trim(), this leads to the conclusion that acpi_scan_lock
      should be acquired by the callers of these two funtions rather by
      these functions themselves.
      
      For these reasons, make all notify handlers that can handle device
      addition and eject events take acpi_scan_lock and remove the
      acpi_scan_lock locking from acpi_bus_scan() and acpi_bus_trim().
      Accordingly, update all of their users to make sure that they
      are always called under acpi_scan_lock.
      
      Furthermore, since eject operations are carried out asynchronously
      with respect to the notify events that trigger them, with the help
      of acpi_bus_hot_remove_device(), even if notify handlers take the
      ACPI scan lock, it still is possible that, for example,
      acpi_bus_trim() will run between acpi_bus_hot_remove_device() and
      the notify handler that scheduled its execution and that
      acpi_bus_trim() will remove the device node passed to
      acpi_bus_hot_remove_device() for ejection.  In that case, the struct
      acpi_device object obtained by acpi_bus_hot_remove_device() will be
      invalid and not-so-funny things will ensue.  To protect agaist that,
      make the users of acpi_bus_hot_remove_device() run get_device() on
      ACPI device node objects that are about to be passed to it and make
      acpi_bus_hot_remove_device() run put_device() on them and check if
      their ACPI handles are not NULL (make acpi_device_unregister() clear
      the device nodes' ACPI handles for that check to work).
      
      Finally, observe that acpi_os_hotplug_execute() actually can fail,
      in which case its caller ought to free memory allocated for the
      context object to prevent leaks from happening.  It also needs to
      run put_device() on the device node that it ran get_device() on
      previously in that case.  Modify the code accordingly.
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      Acked-by: NYinghai Lu <yinghai@kernel.org>
      3757b948
  3. 26 1月, 2013 1 次提交
  4. 19 1月, 2013 1 次提交
    • R
      ACPI / scan: Drop acpi_bus_add() and use acpi_bus_scan() instead · b8bd759a
      Rafael J. Wysocki 提交于
      The only difference between acpi_bus_scan() and acpi_bus_add() is the
      invocation of acpi_update_all_gpes() in the latter which in fact is
      unnecessary, because acpi_update_all_gpes() has already been called
      by acpi_scan_init() and the way it is implemented guarantees the next
      invocations of it to do nothing.
      
      For this reason, drop acpi_bus_add() and make all its callers use
      acpi_bus_scan() directly instead of it.  Additionally, rearrange the
      code in acpi_scan_init() slightly to improve the visibility of the
      acpi_update_all_gpes() call in there.
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      Acked-by: NYinghai Lu <yinghai@kernel.org>
      b8bd759a
  5. 15 1月, 2013 1 次提交
  6. 03 1月, 2013 2 次提交
    • R
      ACPI: Make acpi_bus_scan() and acpi_bus_add() take only one argument · 0cd6ac52
      Rafael J. Wysocki 提交于
      The callers of acpi_bus_add() usually assume that if it has
      succeeded, then a struct acpi_device object has been attached to
      the handle passed as the first argument.  Unfortunately, however,
      this assumption is wrong, because acpi_bus_scan(), and acpi_bus_add()
      too as a result, may return a pointer to a different struct
      acpi_device object on success (it may be an object corresponding to
      one of the descendant ACPI nodes in the namespace scope below that
      handle).
      
      For this reason, the callers of acpi_bus_add() who care about
      whether or not a struct acpi_device object has been created for
      its first argument need to check that using acpi_bus_get_device()
      anyway, so the second argument of acpi_bus_add() is not really
      useful for them.  The same observation applies to acpi_bus_scan()
      executed directly from acpi_scan_init().
      
      Therefore modify the relevant callers of acpi_bus_add() to check the
      existence of the struct acpi_device in question with the help of
      acpi_bus_get_device() and drop the no longer necessary second
      argument of acpi_bus_add().  Accordingly, modify acpi_scan_init() to
      use acpi_bus_get_device() to get acpi_root and drop the no longer
      needed second argument of acpi_bus_scan().
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      Acked-by: NYinghai Lu <yinghai@kernel.org>
      Acked-by: NToshi Kani <toshi.kani@hp.com>
      0cd6ac52
    • R
      ACPI: Remove the arguments of acpi_bus_add() that are not used · 636458de
      Rafael J. Wysocki 提交于
      Notice that acpi_bus_add() uses only 2 of its 4 arguments and
      redefine its header to match the body.  Update all of its callers as
      necessary and observe that this leads to quite a number of removed
      lines of code (Linus will like that).
      
      Add a kerneldoc comment documenting acpi_bus_add() and wonder how
      its callers make wrong assumptions about the second argument (make
      note to self to take care of that later).
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      Acked-by: NYinghai Lu <yinghai@kernel.org>
      Acked-by: NToshi Kani <toshi.kani@hp.com>
      636458de
  7. 22 11月, 2012 1 次提交
  8. 15 11月, 2012 2 次提交
  9. 26 10月, 2012 1 次提交
  10. 16 9月, 2012 2 次提交
  11. 03 8月, 2012 1 次提交
  12. 06 7月, 2012 1 次提交
  13. 01 7月, 2012 1 次提交
  14. 04 6月, 2012 1 次提交
  15. 30 3月, 2012 2 次提交
  16. 29 3月, 2012 1 次提交
  17. 09 2月, 2012 2 次提交
    • Y
      ACPI: remove duplicated lines of merging problems with acpi_processor_start · 976a0be0
      Yinghai Lu 提交于
      When checking driver-core tree, found crazying warnings on my setups.
      
      [  216.025849] calling  acpi_processor_init+0x0/0x81 @ 1
      [  216.045332] ACPI: Requesting acpi_cpufreq
      [  216.047454] Monitor-Mwait will be used to enter C-1 state
      [  216.047912] Monitor-Mwait will be used to enter C-3 state
      [  216.065270] ACPI: acpi_idle registered with cpuidle
      [  216.068241] kobject (ffff8870364a1940): tried to init an initialized object, something is seriously wrong.
      [  216.085287] Pid: 1, comm: swapper/0 Not tainted 3.3.0-rc2-tip-yh-02428-ge663840-dirty #247
      [  216.105041] Call Trace:
      [  216.105192]  [<ffffffff813a9c06>] kobject_init+0x33/0x83
      [  216.124880]  [<ffffffff813aa1f8>] kobject_init_and_add+0x23/0x57
      [  216.125158]  [<ffffffff819f3a08>] cpuidle_add_sysfs+0x49/0x62
      [  216.144850]  [<ffffffff819f2a28>] __cpuidle_register_device+0xe6/0x10e
      [  216.145182]  [<ffffffff819f2ea4>] cpuidle_register_device+0x25/0x4d
      [  216.164912]  [<ffffffff81cb5774>] acpi_processor_power_init+0x13e/0x16c
      [  216.165205]  [<ffffffff81427620>] ? acpi_processor_get_throttling_info+0x128/0x158
      [  216.185012]  [<ffffffff81c68ae5>] acpi_processor_start+0x62/0x11d
      [  216.204861]  [<ffffffff81cb55ff>] acpi_processor_add+0x1b0/0x1e7
      [  216.205144]  [<ffffffff81402a7e>] acpi_device_probe+0x4e/0x11c
      [  216.225063]  [<ffffffff8148f0e7>] really_probe+0x99/0x126
      [  216.225328]  [<ffffffff8148f2a3>] driver_probe_device+0x3b/0x56
      [  216.244846]  [<ffffffff8148f31d>] __driver_attach+0x5f/0x82
      [  216.245101]  [<ffffffff8148f2be>] ? driver_probe_device+0x56/0x56
      [  216.264668]  [<ffffffff8148db80>] bus_for_each_dev+0x5c/0x88
      [  216.264942]  [<ffffffff8148eea7>] driver_attach+0x1e/0x20
      [  216.284639]  [<ffffffff8148eaec>] bus_add_driver+0xca/0x21d
      [  216.284903]  [<ffffffff81095827>] ? local_clock+0xf/0x3c
      [  216.304580]  [<ffffffff82814177>] ? acpi_fan_init+0x18/0x18
      [  216.304849]  [<ffffffff8148f79b>] driver_register+0x91/0xfe
      [  216.324545]  [<ffffffff82814177>] ? acpi_fan_init+0x18/0x18
      [  216.324813]  [<ffffffff81403705>] acpi_bus_register_driver+0x43/0x45
      [  216.344563]  [<ffffffff828141a7>] acpi_processor_init+0x30/0x81
      [  216.344845]  [<ffffffff82814177>] ? acpi_fan_init+0x18/0x18
      [  216.364590]  [<ffffffff810001e7>] do_one_initcall+0x57/0x134
      [  216.364868]  [<ffffffff827e6f8c>] kernel_init+0x146/0x1c0
      [  216.384512]  [<ffffffff81d03aa4>] kernel_thread_helper+0x4/0x10
      [  216.384819]  [<ffffffff81cfbb5d>] ? retint_restore_args+0xe/0xe
      [  216.404578]  [<ffffffff827e6e46>] ? start_kernel+0x3ab/0x3ab
      [  216.424530]  [<ffffffff81d03aa0>] ? gs_change+0xb/0xb
      [  216.424793] ------------[ cut here ]------------
      [  216.425038] WARNING: at fs/sysfs/dir.c:502 sysfs_add_one+0x97/0xab()
      [  216.444480] Hardware name: Sun Fire X4800
      [  216.444668] sysfs: cannot create duplicate filename '/devices/system/cpu/cpu0/cpuidle'
      ...
      
      It turns out acpi_processor_power_init() get called two time in acpi_processor_add and acpi_processor_start.
      
      Found several lines are duplicated in those two functions even related commit move them.
      
      The related patches are ok.  Not sure how it could happen, looks like git problem.
      
      -v2: add back acpi_processor_load_module(pr) to acpi_processor_load_start
      Signed-off-by: NYinghai Lu <yinghai@kernel.org>
      Cc: Linus Torvalds <torvalds@linux-foundation.org>
      Acked-by: NThomas Renninger <trenn@suse.de>
      Cc: Len Brown <lenb@kernel.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      976a0be0
    • Y
      ACPI: remove duplicated lines of merging problems with acpi_processor_add · 15f51136
      Yinghai Lu 提交于
      Those lines have two copies.
      
      Not sure how it could happen, looks like git problem.
      Signed-off-by: NYinghai Lu <yinghai@kernel.org>
      Cc: Linus Torvalds <torvalds@linux-foundation.org>
      Cc: Thomas Renninger <trenn@suse.de>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      15f51136
  18. 08 2月, 2012 1 次提交
  19. 27 1月, 2012 1 次提交
  20. 20 1月, 2012 2 次提交
  21. 18 1月, 2012 2 次提交
  22. 17 1月, 2012 1 次提交
  23. 22 12月, 2011 1 次提交
    • K
      cpu: convert 'cpu' and 'machinecheck' sysdev_class to a regular subsystem · 8a25a2fd
      Kay Sievers 提交于
      This moves the 'cpu sysdev_class' over to a regular 'cpu' subsystem
      and converts the devices to regular devices. The sysdev drivers are
      implemented as subsystem interfaces now.
      
      After all sysdev classes are ported to regular driver core entities, the
      sysdev implementation will be entirely removed from the kernel.
      
      Userspace relies on events and generic sysfs subsystem infrastructure
      from sysdev devices, which are made available with this conversion.
      
      Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
      Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
      Cc: Tony Luck <tony.luck@intel.com>
      Cc: Fenghua Yu <fenghua.yu@intel.com>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
      Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
      Cc: Paul Mundt <lethal@linux-sh.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Chris Metcalf <cmetcalf@tilera.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: "H. Peter Anvin" <hpa@zytor.com>
      Cc: Borislav Petkov <bp@amd64.org>
      Cc: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
      Cc: Len Brown <lenb@kernel.org>
      Cc: Zhang Rui <rui.zhang@intel.com>
      Cc: Dave Jones <davej@redhat.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Russell King <rmk+kernel@arm.linux.org.uk>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: Arjan van de Ven <arjan@linux.intel.com>
      Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
      Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
      Signed-off-by: NKay Sievers <kay.sievers@vrfy.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      8a25a2fd
  24. 07 11月, 2011 1 次提交
  25. 03 3月, 2011 1 次提交
  26. 11 1月, 2011 1 次提交
  27. 14 12月, 2010 1 次提交
  28. 20 10月, 2010 1 次提交
  29. 16 10月, 2010 1 次提交
  30. 29 9月, 2010 1 次提交
  31. 15 8月, 2010 1 次提交
  32. 10 6月, 2010 1 次提交
    • T
      ACPI: Do not try to set up acpi processor stuff on cores exceeding maxcpus= · 75cbfb97
      Thomas Renninger 提交于
      Patch is against latest Linus master branch and is expected to be
      safe bug fix.
      
      You get:
      ACPI: HARDWARE addr space,NOT supported yet
      for each ACPI defined CPU which status is active, but exceeds
      maxcpus= count.
      
      As these "not booted" CPUs do not run an idle routine
      and echo X >/proc/acpi/processor/*/throttling did not work
      I couldn't find a way to really access not onlined/booted
      machines. Still this should get fixed and
      /proc/acpi/processor/X dirs of cores exceeding maxcpus
      should not show up.
      
      I wonder whether this could get cleaned up by truncating possible cpu mask
      and nr_cpu_ids to setup_max_cpus early some day
      (and not exporting setup_max_cpus anymore then).
      But this needs touching of a lot other places...
      Signed-off-by: NThomas Renninger <trenn@suse.de>
      CC: travis@sgi.com
      CC: linux-acpi@vger.kernel.org
      CC: lenb@kernel.org
      Signed-off-by: NLen Brown <len.brown@intel.com>
      75cbfb97
  33. 29 5月, 2010 1 次提交
    • L
      intel_idle: native hardware cpuidle driver for latest Intel processors · 26717172
      Len Brown 提交于
      This EXPERIMENTAL driver supersedes acpi_idle on
      Intel Atom Processors, Intel Core i3/i5/i7 Processors
      and associated Intel Xeon processors.
      
      It does not support the Intel Core2 processor or earlier.
      
      For kernels configured with ACPI, CONFIG_INTEL_IDLE=y
      allows intel_idle to probe before the ACPI processor driver.
      Booting with "intel_idle.max_cstate=0" disables intel_idle
      and the system will fall back on ACPI's "acpi_idle".
      
      Typical Linux distributions load ACPI processor module early,
      making CONFIG_INTEL_IDLE=m not easily useful on ACPI platforms.
      
      intel_idle probes all processors at module_init time.
      Processors that are hot-added later will be limited
      to using C1 in idle.
      Signed-off-by: NLen Brown <len.brown@intel.com>
      26717172