1. 05 4月, 2013 2 次提交
  2. 31 3月, 2013 10 次提交
  3. 22 3月, 2013 1 次提交
    • S
      [media] s5p-fimc: Do not attempt to disable not enabled media pipeline · 8c6ecdd7
      Sylwester Nawrocki 提交于
      This fixes following warnings when all links are being disconnected:
      [   20.080000] WARNING: at drivers/media/platform/s5p-fimc/fimc-mdevice.c:1269 __fimc_md_set_camclk+0x208/0x20c()
      [   20.090000] Modules linked in:
      [   20.095000] [<c001603c>] (unwind_backtrace+0x0/0x13c) from [<c00246dc>] (warn_slowpath_common+0x54/0x64)
      [   20.105000] [<c00246dc>] (warn_slowpath_common+0x54/0x64) from [<c0024708>] (warn_slowpath_null+0x1c/0x24)
      [   20.115000] [<c0024708>] (warn_slowpath_null+0x1c/0x24) from [<c0323fe8>] (__fimc_md_set_camclk+0x208/0x20c)
      [   20.125000] [<c0323fe8>] (__fimc_md_set_camclk+0x208/0x20c) from [<c0324368>] (__fimc_pipeline_close+0x38/0x48)
      [   20.135000] [<c0324368>] (__fimc_pipeline_close+0x38/0x48) from [<c0325848>] (fimc_md_link_notify+0x10c/0x198)
      [   20.145000] [<c0325848>] (fimc_md_link_notify+0x10c/0x198) from [<c02f9dd4>] (__media_entity_setup_link+0x1c0/0x1e8)
      [   20.155000] [<c02f9dd4>] (__media_entity_setup_link+0x1c0/0x1e8) from [<c02f9710>] (media_device_ioctl+0x2c0/0x41c)
      [   20.165000] [<c02f9710>] (media_device_ioctl+0x2c0/0x41c) from [<c02f9938>] (media_ioctl+0x30/0x34)
      [   20.175000] [<c02f9938>] (media_ioctl+0x30/0x34) from [<c00cf0bc>] (do_vfs_ioctl+0x84/0x5e8)
      [   20.185000] [<c00cf0bc>] (do_vfs_ioctl+0x84/0x5e8) from [<c00cf65c>] (sys_ioctl+0x3c/0x60)
      [   20.190000] [<c00cf65c>] (sys_ioctl+0x3c/0x60) from [<c000f040>] (ret_fast_syscall+0x0/0x30)
      Signed-off-by: NSylwester Nawrocki <s.nawrocki@samsung.com>
      Signed-off-by: NKyungmin Park <kyungmin.park@samsung.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      8c6ecdd7
  4. 06 2月, 2013 5 次提交
  5. 06 1月, 2013 4 次提交
  6. 04 1月, 2013 1 次提交
    • G
      Drivers: media: remove __dev* attributes. · 4c62e976
      Greg Kroah-Hartman 提交于
      CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
      markings need to be removed.
      
      This change removes the use of __devinit, __devexit_p, __devinitdata,
      __devinitconst, and __devexit from these drivers.
      
      Based on patches originally written by Bill Pemberton, but redone by me
      in order to handle some of the coding style issues better, by hand.
      
      Cc: Bill Pemberton <wfp5p@virginia.edu>
      Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4c62e976
  7. 21 12月, 2012 3 次提交
  8. 27 11月, 2012 1 次提交
  9. 26 10月, 2012 4 次提交
  10. 02 10月, 2012 5 次提交
  11. 16 8月, 2012 1 次提交
  12. 25 6月, 2012 3 次提交
    • S
      [media] s5p-fimc: Prevent lock-up in multiple sensor systems · e3fc82e8
      Sylwester Nawrocki 提交于
      The camera clocks managed by the driver were improperly reference counted
      and remained disabled when multiple video nodes were opened simultaneously.
      It manifested itself with following warning:
      
       [12.920000] WARNING: at drivers/media/video/s5p-fimc/fimc-mdevice.c:787 __fimc_md_set_camclk+0x1c0/0x1dc()
       [13.005000] Modules linked in:
       [13.005000] Backtrace:
       [13.040000] [<c0013084>] (dump_backtrace+0x0/0x10c) from [<c0454b70>] (dump_stack+0x18/0x1c)
       [13.070000]  r7:00000009 r6:00000313 r5:c02d576c r4:00000000
       [13.155000] [<c0454b58>] (dump_stack+0x0/0x1c) from [<c0022ec4>] (warn_slowpath_common+0x54/0x6c)
       [13.285000] [<c0022e70>] (warn_slowpath_common+0x0/0x6c) from [<c0022f00>] (warn_slowpath_null+0x24/0x2c)
       [13.360000]  r9:e1981010 r8:00000000 r7:c061d3fc r6:e1981010 r5:e1981030
       [13.430000] r4:00000000
       [13.430000] [<c0022edc>] (warn_slowpath_null+0x0/0x2c) from [<c02d576c>] (__fimc_md_set_camclk+0x1c0/0x1dc)
       [13.550000] [<c02d55ac>] (__fimc_md_set_camclk+0x0/0x1dc) from [<c02d57b0>] (fimc_md_set_camclk+0x28/0x2c)
       [13.630000] [<c02d5788>] (fimc_md_set_camclk+0x0/0x2c) from [<c02d57e8>] (__fimc_pipeline_shutdown+0x34/0x50)
       [13.705000] [<c02d57b4>] (__fimc_pipeline_shutdown+0x0/0x50) from [<c02d5844>] (fimc_pipeline_shutdown+0x40/0x58)
       [13.765000]  r5:e2391200 r4:e2357704
       [13.805000] [<c02d5804>] (fimc_pipeline_shutdown+0x0/0x58) from [<c02d4754>] (fimc_capture_close+0xcc/0xe4)
       [13.915000]  r5:e1b396c0 r4:e2357410
       [13.915000] [<c02d4688>] (fimc_capture_close+0x0/0xe4) from [<c02b2d5c>] (v4l2_release+0x5c/0x80)
       [13.970000]  r7:00000010 r6:e1d2d990 r5:e1b396c0 r4:e2394800
       [14.000000] [<c02b2d00>] (v4l2_release+0x0/0x80) from [<c00b66cc>] (fput+0xc0/0x22c)
       [14.015000]  r5:c157ef30 r4:e1b396c0
       [14.015000] [<c00b660c>] (fput+0x0/0x22c) from [<c00b2ca0>] (filp_close+0x60/0x80)
       [14.080000] [<c00b2c40>] (filp_close+0x0/0x80) from [<c00b2d78>] (sys_close+0xb8/0xf4)
       [14.125000]  r7:00000001 r6:e1b396c0 r5:c1400340 r4:c1400300
       [14.125000] [<c00b2cc0>] (sys_close+0x0/0xf4) from [<c000f300>] (ret_fast_syscall+0x0/0x30)
       [14.205000]  r7:00000006 r6:beee5b94 r5:00000003 r4:b6f64fac
      
      Fix this, as well as potential memory leaks due to not calling
      v4l2_fh_release() on some error paths.
      
      Also remove some error logs printed for events that aren't critical and
      are normal conditions for some system configurations.
      
      Also check if the device have been properly run-time enabled during
      video node open.
      Signed-off-by: NSylwester Nawrocki <s.nawrocki@samsung.com>
      Signed-off-by: NKyungmin Park <kyungmin.park@samsung.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      e3fc82e8
    • S
      [media] s5p-fimc: Don't create multiple active links to same sink entity · d0da3c35
      Sylwester Nawrocki 提交于
      The driver is supposed to create active media link from sensor N
      (or its corresponding s5p-mipi-csis entity) to FIMC.N by default.
      Instead s5p-mipi-csis.N entity gets  always connected by a default
      active link to FIMC.N, regardless of there are parallel bus sensor
      entities already connected to FIMC.N. Correct this.
      Signed-off-by: NSylwester Nawrocki <s.nawrocki@samsung.com>
      Signed-off-by: NKyungmin Park <kyungmin.park@samsung.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      d0da3c35
    • S
      [media] s5p-fimc: Fix bug in capture node open() · 90e614bb
      Sylwester Nawrocki 提交于
      When video pipeline initialization fails, the ST_CAPT_BUSY flag
      needs to be cleared before pm_runtime_put_sync is called.
      Otherwise the runtime suspend routine tries to suspend device,
      rather than just turning it off. Also fix potential null pointer
      dereference in fimc_pipeline_shutdown().
      Signed-off-by: NSylwester Nawrocki <s.nawrocki@samsung.com>
      Signed-off-by: NKyungmin Park <kyungmin.park@samsung.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      90e614bb