1. 21 5月, 2010 1 次提交
  2. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  3. 16 6月, 2009 3 次提交
    • D
      musb: support disconnect after HNP roleswitch · ab983f2a
      David Brownell 提交于
      Adjust HNP state machines in MUSB driver so that they handle the
      case where the cable is disconnected.  The A-side machine was
      very wrong (unrecoverable); the B-Side was much less so.
      
       - A_PERIPHERAL ... as usual, the non-observability of the ID
         pin through Mentor's registers makes trouble.  We can't go
         directly to A_WAIT_VFALL to end the session and start the
         disconnect processing.  We can however sense link suspending,
         go to A_WAIT_BCON, and from there use OTG timeouts to finally
         trigger that A_WAIT_VFALL transition.  (Hoping that nobody
         reconnects quickly to that port and notices the wrong state.)
      
       - B_HOST ... actually clear the Host Request (HR) bit as the
         messages say, disconnect the peripheral from the root hub,
         and don't detour through a suspend state.  (In some cases
         this would eventually have cleaned up.)
      
      Also adjust the A_SUSPEND transition to respect the A_AIDL_BDIS
      timeout, so if HNP doesn't trigger quickly enough the A_WAIT_VFALL
      transition happens as it should.
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      ab983f2a
    • D
      musb: make initial HNP roleswitch work (v2) · 1de00dae
      David Brownell 提交于
      Minor HNP bugfixes, so the initial role switch works:
      
       - A-Device:
           * disconnect-during-suspend enters A_PERIPHERAL state
           * kill OTG timer after reset as A_PERIPHERAL ...
           * ... and also pass that reset to the gadget
           * once HNP succeeds, clear the "ignore_disconnect" flag
           * from A_PERIPHERAL, disconnect transitions to A_WAIT_BCON
      
       - B-Device:
           * kill OTG timer on entry to B_HOST state (HNP succeeded)
           * once HNP succeeds, clear "ignore_disconnect" flag
           * kick the root hub only _after_ the state is adjusted
      
      Other state transitions are left alone.  Notably, exit paths from
      the "roles have switched" state ... A_PERIPHERAL handling of that
      stays seriously broken.
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      1de00dae
    • D
      musb: proper hookup to transceiver drivers · 84e250ff
      David Brownell 提交于
      Let the otg_transceiver in MUSB be managed by an external driver;
      don't assume it's integrated.  OMAP3 chips need it to be external,
      and there may be ways to interact with the transceiver which add
      functionality to the system.
      
      Platform init code is responsible for setting up the transeciver,
      probably using the NOP transceiver for integrated transceivers.
      External ones will use whatever the board init code provided,
      such as twl4030 or something more hands-off.
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      84e250ff
  4. 25 3月, 2009 1 次提交
  5. 14 8月, 2008 1 次提交