This patch makes the needlessly global struct info static.
Signed-off-by: NAdrian Bunk <bunk@stusta.de>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

To be able to convert kmalloc + memset(..., 1, ...) to kzalloc this patch
reverses the logic around 'buf'.
Signed-off-by: NMariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

Signed-off-by: NMariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

Signed-off-by: NMariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

	This patch removes redundant memset() and dead return line from
of_physmap_probe(). No functional change.
Signed-off-by: NMariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

When we mark block bad we have to get chip because this involves
writing to the page's OOB. We hit this bug in UBI - we observed
random obscure crashes when it marks block bad from the background
thread and there is some parallel task which utilizes flash.

This patch also adds a TODO note about BBT table protection which
it seems does not exist.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

It expects a uint64_t; give it one.
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

Signed-off-by: NRobert P. J. Day <rpjday@mindspring.com>
Acked-by: NRalf Baechle <ralf@linux-mips.org>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

The patch ensures that the current code (kernel 2.6.22) uses the bits 
like the code prior to the refactoring. The variable "bits" is employed 
in a useful way now.
Signed-off-by: NRoland Stigge <stigge@antcom.de>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

embedded returns are evil.
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

This fixes a leak in the !mtd->erasesize error path (Coverity 1765).
Signed-off-by: NFlorin Malita <fmalita@gmail.com>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

This patch cleans up duplicate includes in
	drivers/mtd/
Signed-off-by: NJesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

This patch adds the manufacturer ID for AMD flash.
Signed-off-by: NSteven J. Hill <sjhill1@rockwellcollins.com>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

Slab destructors were no longer supported after Christoph's
c59def9f change. They've been
BUGs for both slab and slub, and slob never supported them
either.

This rips out support for the dtor pointer from kmem_cache_create()
completely and fixes up every single callsite in the kernel (there were
about 224, not including the slab allocator definitions themselves,
or the documentation references).
Signed-off-by: NPaul Mundt <lethal@linux-sh.org>

cdev.c whines in current git:

drivers/mtd/ubi/cdev.c: In function `major_to_device':
drivers/mtd/ubi/cdev.c:67: warning: control reaches end of non-void function

Shut it up.
Signed-off-by: NPaul Mundt <lethal@linux-sh.org>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Do not switch to read-only mode in case of -EINTR and some
other obvious cases. Switch to RO mode only when we do not
know what is the error.
Reported-by: NVinit Agnihotri <vinit.agnihotri@gmail.com>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Pointed to by viro.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

The use of try_module_get(THIS_MODULE) in ubi_get_device_info does not
offer real protection against unexpected driver unloads, since we could
be preempted before try_modules_get gets executed. It is the caller who
should manipulate the refcounts. Besides, ubi_get_device_info is an
exported symbol which guarantees protection when accessed through
symbol_get.
Signed-off-by: NFernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

I was experiencing overflows in multiplications for
volume->used_bytes in vmt.c & vtbl.c, while creating & resizing large volumes.

vol->used_bytes is long long however its 2 operands vol->used_ebs &
vol->usable_leb_size
are int. So their multiplication for larger values causes integer overflows.
Typecasting them solves the problem.

My machine & flash details:

64Bit dual-core AMD opteron, 1 GB RAM, linux 2.6.18.3.
mtd size = 6GB, volume size= 5GB, peb_size = 4MB.

heres patch which does the fix.
Signed-off-by: NVinit Agnihotri <vinit.agnihotri@gmail.com>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Do not zero max_sqnum after a new volume has been found.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Hi,I came across problem of having two leb with same sequence no.This
happens when we continuously write one block again and again and reboot
machine before background thread erases those blocks.
The problem here was,when we find two blocks with same sequence no,we take
the higher one,but we were not updating max seq no,so next block may have
the same seqnum.
This patch solves this problem.
Signed-off-by: NBrijesh Singh <brijesh.s.singh@gmail.com>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

There is signed multiplication assigned to unsigned ei.addr in io.c.
This causes wrong addresses for big multiplication.This patch solves the
problem.
Signed-off-by: NBrijesh Singh <brijesh.s.singh@gmail.com>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

atomic_leb_change() is only allowed for dynamic volumes, so set
the volume type correctly.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Increase UBI devices couter after the message, not before.
Signed-off-by: NVinit Agnihotri <vinit.agnihotri@gmail.com>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Do not check volumes which are currently in use because thay may be
in inconsistent state.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

When volume creation fails, we have to set ubi->volumes[vol_id]
back to NULL.

This patch also tweaks some debugging stuff.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: NVignesh Babu <vignesh.babu@wipro.com>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

ubi->vtbl is allocated using vmalloc() in vtbl.c empty_create_lvol(),
but it is freed in build.c with kfree()
Signed-off-by: NVinit Agnihotri <vinit.agnihotri@gmail.com>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Do not call 'ubi_wl_put_peb()' if the LEB was unmapped.
Reported-by: NGabor Loki <loki@inf.u-szeged.hu>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Kill UBI's homegrown endianess handling and replace it with
the standard kernel endianess handling.
Signed-off-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

- don't do access_ok + get/put user but use the proper macro
- remove useless checks
Signed-off-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

No need to unlock the lock, this will be done at out_unlock.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Use coma at the the last elements of structure initializer.

Daniel Stone's explanation:

Because it turns:
-   .attr   = foo
+   .attr   = foo,
+   .bar    = baz

into:
+   .bar    = baz,

i.e., far less likely to screw up a merge.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

UBI allocates temporary buffers of PEB size, which may be 256KiB.
Use vmalloc instead of kmalloc for such big temporary buffers.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Add few comments above ubi_scan_add_used() to explain why it is so
complex. Requested by Satyam Sharma <satyam.sharma@gmail.com>.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

In case of static volumes, make emulated MTD device size to
be equivalent to data size, rather then volume size.
Reported-by: NJohn Smith <john@arrows.demon.co.uk>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

In case of static volumes it is prohibited to read more data
then available.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

There were several bugs in volume table creation error path. Thanks to
Satyam Sharma <satyam.sharma@gmail.com> and Florin Malita <fmalita@gmail.com>
for finding and analysing them: http://lkml.org/lkml/2007/5/3/274

This patch makes ubi_scan_add_to_list() static and renames it to
add_to_list(), just because it is not needed outside scan.c anymore.
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>

Coverity (CID 1614) spotted new_seb being dereferenced after kfree() in
create_vtbl's write_error path.
Signed-off-by: NFlorin Malita <fmalita@gmail.com>
Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>