1. 30 3月, 2009 2 次提交
    • T
      V4L/DVB (10559): bttv: Fix TDA9880 norm setting code · 72134a6d
      Trent Piepho 提交于
      The code to set the norm for the TDA9880 analog demod was comparing
      btv->norm, an index into the bttv driver's norm array, to V4L2_STD_NTSC,
      which is a bit flag that's part of the V4L2 API.  This doesn't work of
      course and results in the PAL path always being taken.
      
      What's more, it modified the bttv_tvcards[] entries for cards using the
      TDA9880.  This is wrong because changing the norm on one card will also
      affect other cards of the same type.  Writing to bttv_tvcards is also bad
      because it should be read-only or even devinitdata.
      
      Changing the norm would also cause the audio to become unmuted.
      
      Have the code get called for both norm setting and audio input setting
      (which where the gpios are set) to avoid needed to modify bttv_tvcards.
      Signed-off-by: NTrent Piepho <xyzzy@speakeasy.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      72134a6d
    • T
      V4L/DVB (10558): bttv: norm value should be unsigned · 4ef2ccc2
      Trent Piepho 提交于
      The norm value in the driver is an index into an array and the the driver
      doesn't allow it to be negative or otherwise invalid.  It should be
      unsigned but wasn't in all places.
      
      Fix some structs and functions to have the norm be unsigned.  Get rid of
      useless checks for "< 0".  Most of the driver code can't handle a norm
      value that's out of range, so change some ">= BTTV_TVNORMS" checks to
      BUG_ON().  There's no point in silently ignoring invalid driver state just
      to crash because of it later.
      Reported-by: NRoel Kluin <roel.kluin@gmail.com>
      Signed-off-by: NTrent Piepho <xyzzy@speakeasy.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      4ef2ccc2
  2. 03 1月, 2009 3 次提交
  3. 22 10月, 2008 1 次提交
    • H
      V4L/DVB (9327): v4l: use video_device.num instead of minor in video%d · c6330fb8
      Hans Verkuil 提交于
      The kernel number of a v4l2 node (e.g. videoX, radioX or vbiX) is now
      independent of the minor number. So instead of using the minor field
      of the video_device struct one has to use the num field: this always
      contains the kernel number of the device node.
      
      I forgot about this when I did the v4l2 core change, so this patch
      converts all drivers that use it in one go. Luckily the change is
      trivial.
      
      Cc: michael@mihu.de
      Cc: mchehab@infradead.org
      Cc: corbet@lwn.net
      Cc: luca.risolia@studio.unibo.it
      Cc: isely@pobox.com
      Cc: pe1rxq@amsat.org
      Cc: royale@zerezo.com
      Cc: mkrufky@linuxtv.org
      Cc: stoth@linuxtv.org
      Signed-off-by: NHans Verkuil <hverkuil@xs4all.nl>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      c6330fb8
  4. 13 10月, 2008 1 次提交
  5. 12 10月, 2008 4 次提交
  6. 05 10月, 2008 1 次提交
    • J
      V4L/DVB (8955): bttv: Prevent NULL pointer dereference in radio_open · c37396c1
      Jean Delvare 提交于
      Fix the following crash in the bttv driver:
      
      BUG: unable to handle kernel NULL pointer dereference at 000000000000036c
      IP: [<ffffffffa037860a>] radio_open+0x3a/0x170 [bttv]
      
      This happens because radio_open assumes that all present bttv devices
      have a radio function. If a bttv device without radio and one with
      radio are installed on the same system, and the one without radio is
      registered first, then radio_open checks for the radio device number
      of a bttv device that has no radio function, and this breaks. All we
      have to do to fix it is to skip bttv devices without a radio function.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      c37396c1
  7. 04 9月, 2008 1 次提交
  8. 27 7月, 2008 1 次提交
  9. 26 7月, 2008 1 次提交
  10. 24 7月, 2008 3 次提交
  11. 20 7月, 2008 3 次提交
  12. 21 5月, 2008 1 次提交
  13. 25 4月, 2008 3 次提交
  14. 02 4月, 2008 4 次提交
  15. 20 3月, 2008 1 次提交
  16. 18 2月, 2008 2 次提交
  17. 26 1月, 2008 8 次提交