1. 07 2月, 2009 2 次提交
    • I
      sungem: Soft lockup in sungem on Netra AC200 when switching interface up · 71822faa
      Ilkka Virta 提交于
      From: Ilkka Virta <itvirta@iki.fi>
      
      In the lockup situation the driver seems to go off in an eternal storm
      of interrupts right after calling request_irq(). It doesn't actually
      do anything interesting in the interrupt handler. Since connecting the link
      afterwards works, something later in initialization must fix this.
      
      Looking at gem_do_start() and gem_open(), it seems that the only thing
      done while opening the device after the request_irq(), is a call to
      napi_enable().
      
      I don't know what the ordering requirements are for the
      initialization, but I boldly tried to move the napi_enable() call
      inside gem_do_start() before the link state is checked and interrupts
      subsequently enabled, and it seems to work for me. Doesn't even break
      anything too obvious...
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      71822faa
    • I
      r8169: Don't update statistics counters when interface is down · 355423d0
      Ivan Vecera 提交于
      Some Realtek chips (RTL8169sb/8110sb in my case) are unable to retrieve
      ethtool statistics when the interface is down. The process stays in
      endless loop in rtl8169_get_ethtool_stats. This is because these chips
      need to have receiver enabled (CmdRxEnb bit in ChipCmd register) that is
      cleared when the interface is going down. It's better to update statistics
      only when the interface is up and otherwise return copy of statistics
      grabbed when the interface was up (in rtl8169_close).
      
      It is interesting that PCI-E NICs (like 8168b/8111b...) are not affected.
      Signed-off-by: NIvan Vecera <ivecera@redhat.com>
      Acked-by: NFrancois Romieu <romieu@fr.zoreil.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      355423d0
  2. 05 2月, 2009 5 次提交
    • A
      gianfar: Fix potential soft reset race · b98ac702
      Andy Fleming 提交于
      SOFT_RESET must be asserted for at least 3 TX clocks in order for it to work
      properly.  The syncs in the gfar_write() commands have been hiding this, but
      we need to guarantee it.
      Signed-off-by: NAndy Fleming <afleming@freescale.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      b98ac702
    • A
      gianfar: Fix BD_LENGTH_MASK definition · 1fbe4932
      Andy Fleming 提交于
      BD_LENGTH_MASK is supposed to catch the low 16-bits of the status field, not
      the low byte.  The old way, we would never be able to clean up tx packets with
      sizes divisible by 256.
      Signed-off-by: NAndy Fleming <afleming@freescale.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      1fbe4932
    • D
      cxgb3: Fix lro switch · 65ab8385
      Divy Le Ray 提交于
      The LRO switch is always set to 1 in the rx processing loop.
      It breaks the accelerated iSCSI receive traffic.
      Fix its computation.
      Signed-off-by: NDivy Le Ray <divy@chelsio.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      65ab8385
    • R
      iwlwifi: save PCI state before suspend, restore after resume · c4e061ac
      Reinette Chatre 提交于
      This is the right thing to do and fixes the following warning:
      
      [  115.012278] ------------[ cut here ]------------
      [  115.012281] WARNING: at drivers/pci/pci-driver.c:370
      pci_legacy_suspend+0x85/0xc2()
      [  115.012285] Hardware name: Latitude D630
      [  115.012301] PCI PM: Device state not saved by
      iwl3945_pci_suspend+0x0/0x4c [iwl3945]
      [  115.012304] Modules linked in: fuse nfsd lockd nfs_acl auth_rpcgss
      exportfs sunrpc ipv6 acpi_cpufreq kvm_intel kvm snd_hda_codec_idt
      snd_hda_intel snd_hda_codec snd_hwdep arc4 snd_seq_device snd_pcm_oss
      snd_mixer_oss ecb snd_pcm cryptomgr aead snd_timer crypto_blkcipher
      snd snd_page_alloc ohci1394 crypto_hash crypto_algapi ch341 ieee1394
      usbserial thermal iwl3945 mac80211 led_class lib80211 tg3 processor
      i2c_i801 i2c_core sg cfg80211 libphy usbhid battery ac button sr_mod
      cdrom evdev dcdbas ata_generic ata_piix libata sd_mod scsi_mod ext3
      jbd mbcache uhci_hcd ohci_hcd ehci_hcd usbcore [last unloaded:
      microcode]
      [  115.012374] Pid: 4163, comm: pm-suspend Not tainted
      2.6.29-rc3-00227-gf1dd849-dirty #67
      [  115.012377] Call Trace:
      [  115.012382]  [<ffffffff8023d04d>] warn_slowpath+0xb1/0xed
      [  115.012387]  [<ffffffff80450b5e>] ? _spin_unlock_irqrestore+0x5c/0x78
      [  115.012390]  [<ffffffff80254f08>] ? up+0x34/0x39
      [  115.012394]  [<ffffffff80362319>] ? acpi_ut_release_mutex+0x5d/0x61
      [  115.012397]  [<ffffffff803584b2>] ? acpi_get_data+0x5e/0x70
      [  115.012400]  [<ffffffff80363dd9>] ? acpi_bus_get_device+0x25/0x39
      [  115.012403]  [<ffffffff80363e98>] ? acpi_bus_power_manageable+0x11/0x29
      [  115.012406]  [<ffffffff803462f7>] ? acpi_pci_power_manageable+0x17/0x19
      [  115.012410]  [<ffffffff8033ddfd>] ? pci_set_power_state+0xcc/0x101
      [  115.012418]  [<ffffffffa01f28e9>] ? iwl3945_pci_suspend+0x0/0x4c [iwl3945]
      [  115.012422]  [<ffffffff803401e6>] pci_legacy_suspend+0x85/0xc2
      [  115.012425]  [<ffffffff80340316>] pci_pm_suspend+0x34/0x86
      [  115.012429]  [<ffffffff8039d7ce>] pm_op+0x52/0xe5
      [  115.012432]  [<ffffffff8039dd78>] device_suspend+0x32a/0x451
      [  115.012436]  [<ffffffff80269ec2>] suspend_devices_and_enter+0x3e/0x13a
      [  115.012439]  [<ffffffff8026a128>] enter_state+0x110/0x164
      [  115.012442]  [<ffffffff8026a233>] state_store+0xb7/0xd7
      [  115.012446]  [<ffffffff8032f95f>] kobj_attr_store+0x17/0x19
      [  115.012449]  [<ffffffff80307d64>] sysfs_write_file+0xe4/0x119
      [  115.012453]  [<ffffffff802baa7a>] vfs_write+0xae/0x137
      [  115.012456]  [<ffffffff802babc7>] sys_write+0x47/0x70
      [  115.012459]  [<ffffffff8020b73a>] system_call_fastpath+0x16/0x1b
      [  115.012467] ---[ end trace 829828966f6f24dc ]---
      Signed-off-by: NReinette Chatre <reinette.chatre@intel.com>
      Tested-by: NMing Lei <tom.leiming@gmail.com>
      Cc: Rafael J. Wysocki <rjw@sisk.pl>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      c4e061ac
    • R
      iwlwifi: clean key table in iwl_clear_stations_table · 5e46882e
      Reinette Chatre 提交于
      Cleans uCode key table bit map iwl_clear_stations_table
      since all stations are cleared also the key table must be.
      
      Since the keys are not removed properly on suspend by mac80211
      this may result in exhausting key table on resume leading
      to memory corruption during removal
      Signed-off-by: NTomas Winkler <tomas.winkler@intel.com>
      Signed-off-by: NReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      5e46882e
  3. 04 2月, 2009 4 次提交
  4. 03 2月, 2009 20 次提交
  5. 02 2月, 2009 2 次提交
  6. 01 2月, 2009 4 次提交
    • D
      V4L/DVB (10411): s5h1409: Perform s5h1409 soft reset after tuning · 67e70baf
      Devin Heitmueller 提交于
      Just like with the s5h1411, the s5h1409 needs a soft-reset in order for it
      to know that the tuner has been told to change frequencies.  This change
      changes the behavior from "random tuning times between 500ms to complete
      tuning lock failures" to "tuning lock consistently within 700ms".
      
      Thanks to Robert Krakora <rob.krakora@messagenetsystems.com> for doing
      initial testing of the patch on the KWorld 330U.
      
      Thanks to Andy Walls <awalls@radix.net> for doing testing of the patch on
      the HVR-1600.
      
      Thanks to Michael Krufky <mkrufky@linuxtv.org> for doing additional testing.
      Signed-off-by: NDevin Heitmueller <dheitmueller@linuxtv.org>
      Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      67e70baf
    • M
      V4L/DVB (10403): saa7134-alsa: saa7130 doesn't support digital audio · 40c41c8c
      Mauro Carvalho Chehab 提交于
      According with saa7130 public datasheet, saa7130 doesn't support
      digital audio. This is also confirmed by experimental tests. So, it
      doesn't make sense to let saa7134-alsa register for those chipsets.
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      40c41c8c
    • M
      Fix memory corruption in console selection · 878b8619
      Mikulas Patocka 提交于
      Fix an off-by-two memory error in console selection.
      
      The loop below goes from sel_start to sel_end (inclusive), so it writes
      one more character.  This one more character was added to the allocated
      size (+1), but it was not multiplied by an UTF-8 multiplier.
      
      This patch fixes a memory corruption when UTF-8 console is used and the
      user selects a few characters, all of them 3-byte in UTF-8 (for example
      a frame line).
      
      When memory redzones are enabled, a redzone corruption is reported.
      When they are not enabled, trashing of random memory occurs.
      Signed-off-by: NMikulas Patocka <mpatocka@redhat.com>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      878b8619
    • L
      Stop playing silly games with the VM_ACCOUNT flag · fc8744ad
      Linus Torvalds 提交于
      The mmap_region() code would temporarily set the VM_ACCOUNT flag for
      anonymous shared mappings just to inform shmem_zero_setup() that it
      should enable accounting for the resulting shm object.  It would then
      clear the flag after calling ->mmap (for the /dev/zero case) or doing
      shmem_zero_setup() (for the MAP_ANON case).
      
      This just resulted in vma merge issues, but also made for just
      unnecessary confusion.  Use the already-existing VM_NORESERVE flag for
      this instead, and let shmem_{zero|file}_setup() just figure it out from
      that.
      
      This also happens to make it obvious that the new DRI2 GEM layer uses a
      non-reserving backing store for its object allocation - which is quite
      possibly not intentional.  But since I didn't want to change semantics
      in this patch, I left it alone, and just updated the caller to use the
      new flag semantics.
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      fc8744ad
  7. 31 1月, 2009 3 次提交