note_interrupt wants to be called with the combined result of all
handlers called, not with the last one. If it's a shared interrupt
then the last handler might return IRQ_NONE often enough to trigger
the spurious dectector which turns off a perfectly fine working
interrupt line. Bug was introduced in commit 1277a532(genirq: Simplify
handle_irq_event()).

Yes, I really messed up there. First the variable ret should not have
been named differently to avoid similarity with retval. Second it
should have been declared in the do {} loop.

Rename it to res and move it into the do {} loop and vanish under a
huge brown paperbag.
Reported-bisected-tested-by: NIngo Molnar <mingo@elte.hu>
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

The switch case in __irq_set_trigger() lacks a break, which emits a
pr_err unconditionally on success.
Reported-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

The runtime expansion of nr_irqs does not take into account that
bitmap_find_next_zero_area() returns "start" + size in case the search
for an matching zero area fails. That results in a start value which
can be completely off and is not covered by the following
expand_nr_irqs() and possibly outside of the absolute limit. But we
use it without further checking.

Use IRQ_BITMAP_BITS as the limit for the bitmap search and expand
nr_irqs when the start bit is beyond nr_irqs. So start is always
pointing to the correct area in the bitmap. nr_irqs is just the limit
for irq enumerations, not the real limit for the irq space.

[ tglx: Let irq_expand_nr_irqs() take the new upper end so we do not
  	expand nr_irqs more than necessary. Made changelog readable ]
Signed-off-by: NYinghai Lu <yinghai@kernel.org>
LKML-Reference: <4D6014F9.8040605@kernel.org>
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

We lazy disable interrupt lines, so only mark the line masked, when
the chip provides an irq_disable callback.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

No need to lookup the irq descriptor when calling from a chip callback
function which has irq_data already handy.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Some chips want irq_eoi() only called when an interrupt is actually
handled. So they have checks for INPROGRESS and DISABLED in their
irq_eoi callbacks. Add a chip flag, which allows to handle that in the
generic code. No impact on the fastpath.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

sparc64 needs to call a preflow handler on certain interrupts befor
calling the action chain. Integrate it into handle_fasteoi_irq. Must
be enabled via CONFIG_IRQ_FASTEOI_PREFLOW. No impact when disabled.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
Cc: David S. Miller <davem@davemloft.net>

No need to have separate functions if we have one plus inline wrappers.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Convert the management functions to use the common irq_get/put
function.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Most of the managing functions get the irq descriptor and lock it -
either with or without buslock. Instead of open coding this over and
over provide a common function to do that.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

These transition helpers are stale for years now. Remove them.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

If everything uses the right accessors, then enabling
GENERIC_HARDIRQS_NO_COMPAT should just work. If not it will tell you.

Don't be lazy and use the trick which I use in the core code!

git grep status_use_accessors

will unearth it in a split second. Offenders are tracked down and not
slapped with stinking trouts. This time we use frozen shark for a
better educational value.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Required by x86.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Some irq_chips need to know the state of wakeup mode for
setting the trigger type etc. Reflect it in irq_data state.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

irq_chips, which require to mask the chip before changing the trigger
type should set this flag. So the core takes care of it and the
requirement for looking into desc->status in the chip goes away.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
Cc: Linus Walleij <linus.walleij@stericsson.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>

Looking through irq_chip implementations I noticed that some of them
have special requirements, like setting the type masked and therefor
fiddle in irq_desc->status. Add a flag field, so the core code can
handle it.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Put the constants into an enum and document them.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Force the usage of wrappers by another nasty CPP substitution.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Use wrappers to keep them away from the core code.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

That's the data structure chip functions get provided. Also allow them
to signal the core code that they updated the flags in irq_data.state
by returning IRQ_SET_MASK_OK_NOCOPY. The default is unchanged.

The type bits should be accessed via:

val = irqd_get_trigger_type(irqdata);
and
irqd_set_trigger_type(irqdata, val);

Coders who access them directly will be tracked down and slapped with
stinking trouts.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Keep status in sync until last abuser is gone.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Add a !desc check while at it.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

That's the right data structure to look at for arch code.

Accessor functions are provided.

	 irqd_is_per_cpu(irqdata);
	 irqd_can_balance(irqdata);

Coders who access them directly will be tracked down and slapped with
stinking trouts.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

It'll break when I'm going to undefine the constants.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Its' too ugly and needs to go. The only users are core code and
parisc. Core code does not need it and parisc gets a new check once
IRQ_PER_CPU is reflected in irq_data.state.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

The saving of this switch is minimal versus the ifdef mess it
creates. Simple enable PER_CPU unconditionally and remove the config
switch.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

chip implementations need to know about it. Keep status in sync until
all users are fixed. 

Accessor function: irqd_is_setaffinity_pending(irqdata)

Coders who access them directly will be tracked down and slapped with
stinking trouts.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Some chip implementations need to access certain status flags. With
sparse irqs that requires a lookup of the irq descriptor. Add a state
field which contains such flags.

Name it in a way which will make coders happy to access it with the
proper accessor functions. And it's easy to grep for.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

No users outside of core.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

No users outside of core.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Keep status in sync until all users are fixed.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Keep status in sync until all users are fixed.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

Keep status in sync until all abusers are fixed.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

No users outside of core.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

No users outside of core.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

We need to maintain the flag for now in both fields status and istate.
Add a CONFIG_GENERIC_HARDIRQS_NO_COMPAT switch to allow testing w/o
the status one. Wrap the access to status IRQ_INPROGRESS in a inline
which can be turned of with CONFIG_GENERIC_HARDIRQS_NO_COMPAT along
with the define.

There is no reason that anything outside of core looks at this. That
needs some modifications, but we'll get there.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

No users outside of core.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

No need for a separate function in the core code.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>

No users outside.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>