1. 29 11月, 2009 6 次提交
    • D
      pcmcia: rework the irq_req_t typedef · 5fa9167a
      Dominik Brodowski 提交于
      Most of the irq_req_t typedef'd struct can be re-worked quite
      easily:
      
      (1) IRQInfo2 was unused in any case, so drop it.
      
      (2) IRQInfo1 was used write-only, so drop it.
      
      (3) Instance (private data to be passed to the IRQ handler):
      	Most PCMCIA drivers using pcmcia_request_irq() to actually
      	register an IRQ handler set the "dev_id" to the same pointer
      	as the "priv" pointer in struct pcmcia_device. Modify the two
      	exceptions (ipwireless, ibmtr_cs) to also work this waym and
      	set the IRQ handler's "dev_id" to p_dev->priv unconditionally.
      
      (4) Handler is to be of type irq_handler_t.
      
      (5) Handler != NULL already tells whether an IRQ handler is present.
      	Therefore, we do not need the IRQ_HANDLER_PRESENT flag in
      	irq_req_t.Attributes.
      
      CC: netdev@vger.kernel.org
      CC: linux-bluetooth@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: alsa-devel@alsa-project.org
      CC: Jaroslav Kysela <perex@perex.cz>
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: Karsten Keil <isdn@linux-pingi.de>
      for the Bluetooth parts: Acked-by: Marcel Holtmann <marcel@holtmann.org>
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      5fa9167a
    • D
      pcmcia: remove deprecated handle_to_dev() macro · dd2e5a15
      Dominik Brodowski 提交于
      Update remaining users and remove deprecated handle_to_dev() macro
      
      CC: Harald Welte <laforge@gnumonks.org>
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-serial@vger.kernel.org
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      dd2e5a15
    • D
      pcmcia: pcmcia_request_window() doesn't need a pointer to a pointer · 6838b03f
      Dominik Brodowski 提交于
      pcmcia_request_window() only needs a pointer to struct pcmcia_device, not
      a pointer to a pointer.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      Acked-by: Karsten Keil <keil@b1-systems.de> (for ISDN)
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      6838b03f
    • M
      pcmcia: Change window_handle_t logic to unsigned long · 0bdf9b3d
      Magnus Damm 提交于
      Logic changes based on top of the other patches:
      
      This set of patches changed window_handle_t from being a pointer to an
      unsigned long. The unsigned long is now a simple index into socket->win[].
      Going from a pointer to unsigned long should leave the user space interface
      unchanged unless I'm mistaken.
      
      This change results in code that is less error prone and a user space
      interface which is much cleaner and safer. A nice side effect is that we
      are also are able to remove all members except one from window_t.
      
      [ linux@dominikbrodowski.net:
      	Update to 2.6.31. Also, a plain "index" to socket->win[] does not
      	work, as several codepaths rely on "window_handle_t" being
      	non-zero if used. Therefore, set the window_handle_t to the
      	socket->win[] index + 1. ]
      
      CC: netdev@vger.kernel.org
      Signed-off-by: NMagnus Damm <damm@opensource.se>
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      0bdf9b3d
    • M
      pcmcia: Pass struct pcmcia_device to pcmcia_map_mem_page() · 868575d1
      Magnus Damm 提交于
      No logic changes, just pass struct pcmcia_device to pcmcia_map_mem_page()
      
      [linux@dominikbrodowski.net: update to 2.6.31]
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      Acked-by: Karsten Keil <keil@b1-systems.de> (for ISDN)
      Signed-off-by: NMagnus Damm <damm@opensource.se>
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      868575d1
    • M
      pcmcia: Pass struct pcmcia_device to pcmcia_release_window() · f5560da5
      Magnus Damm 提交于
      No logic changes, just pass struct pcmcia_device to pcmcia_release_window().
      
      [linux@dominikbrodowski.net: update to 2.6.31]
      CC: netdev@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      Signed-off-by: NMagnus Damm <damm@opensource.se>
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      f5560da5
  2. 09 11月, 2009 4 次提交
  3. 30 10月, 2009 1 次提交
  4. 13 10月, 2009 1 次提交
  5. 05 10月, 2009 1 次提交
  6. 23 9月, 2009 1 次提交
  7. 15 9月, 2009 1 次提交
  8. 04 9月, 2009 2 次提交
  9. 01 9月, 2009 1 次提交
  10. 13 8月, 2009 1 次提交
  11. 20 7月, 2009 1 次提交
  12. 09 7月, 2009 1 次提交
  13. 06 7月, 2009 2 次提交
  14. 13 6月, 2009 1 次提交
  15. 02 5月, 2009 1 次提交
  16. 21 4月, 2009 1 次提交
  17. 07 4月, 2009 1 次提交
  18. 30 3月, 2009 1 次提交
  19. 22 3月, 2009 11 次提交
  20. 04 3月, 2009 1 次提交
    • R
      net pcmcia: worklimit reaches -1 · b9bdcd9b
      Roel Kluin 提交于
      with while (--worklimit >= 0); worklimit reaches -1 after the loop. In
      3c589_cs.c this caused a warning not to be printed.
      
      In 3c574_cs.c contrastingly, el3_rx() treats worklimit differently:
      
      static int el3_rx(struct net_device *dev, int worklimit)
      {
      	while (--worklimit >= 0) { ... }
      	return worklimit;
      }
      
      el3_rx() is only called by function el3_interrupt(): twice:
      
      static irqreturn_t el3_interrupt(int irq, void *dev_id)
      {
              int work_budget = max_interrupt_work;
      	while(...) {
      		if (...)
      			work_budget = el3_rx(dev, work_budget);
      		if (...)
      			work_budget = el3_rx(dev, work_budget);
      		if (--work_budget < 0) {
      		        ...
      		        break;
      		}
      	}
      }
      The error path can occur 2 too early.
      Signed-off-by: NRoel Kluin <roel.kluin@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      b9bdcd9b