1. 11 7月, 2006 1 次提交
    • B
      [PATCH] powerpc: fix trigger handling in the new irq code · 6e99e458
      Benjamin Herrenschmidt 提交于
      This patch slightly reworks the new irq code to fix a small design error.  I
      removed the passing of the trigger to the map() calls entirely, it was not a
      good idea to have one call do two different things.  It also fixes a couple of
      corner cases.
      
      Mapping a linux virtual irq to a physical irq now does only that.  Setting the
      trigger is a different action which has a different call.
      
      The main changes are:
      
      - I no longer call host->ops->map() for an already mapped irq, I just return
        the virtual number that was already mapped.  It was called before to give an
        opportunity to change the trigger, but that was causing issues as that could
        happen while the interrupt was in use by a device, and because of the
        trigger change, map would potentially muck around with things in a racy way.
         That was causing much burden on a given's controller implementation of
        map() to get it right.  This is much simpler now.  map() is only called on
        the initial mapping of an irq, meaning that you know that this irq is _not_
        being used.  You can initialize the hardware if you want (though you don't
        have to).
      
      - Controllers that can handle different type of triggers (level/edge/etc...)
        now implement the standard irq_chip->set_type() call as defined by the
        generic code.  That means that you can use the standard set_irq_type() to
        configure an irq line manually if you wish or (though I don't like that
        interface), pass explicit trigger flags to request_irq() as defined by the
        generic kernel interfaces.  Also, using those interfaces guarantees that
        your controller set_type callback is called with the descriptor lock held,
        thus providing locking against activity on the same interrupt (including
        mask/unmask/etc...) automatically.  A result is that, for example, MPIC's
        own map() implementation calls irq_set_type(NONE) to configure the hardware
        to the default triggers.
      
      - To allow the above, the irq_map array entry for the new mapped interrupt
        is now set before map() callback is called for the controller.
      
      - The irq_create_of_mapping() (also used by irq_of_parse_and_map()) function
        for mapping interrupts from the device-tree now also call the separate
        set_irq_type(), and only does so if there is a change in the trigger type.
      
      - While I was at it, I changed pci_read_irq_line() (which is the helper I
        would expect most archs to use in their pcibios_fixup() to get the PCI
        interrupt routing from the device tree) to also handle a fallback when the
        DT mapping fails consisting of reading the PCI_INTERRUPT_PIN to know wether
        the device has an interrupt at all, and the the PCI_INTERRUPT_LINE to get an
        interrupt number from the device.  That number is then mapped using the
        default controller, and the trigger is set to level low.  That default
        behaviour works for several platforms that don't have a proper interrupt
        tree like Pegasos.  If it doesn't work for your platform, then either
        provide a proper interrupt tree from the firmware so that fallback isn't
        needed, or don't call pci_read_irq_line()
      
      - Add back a bit that got dropped by my main rework patch for properly
        clearing pending IPIs on pSeries when using a kexec
      Signed-off-by: NBenjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      6e99e458
  2. 06 7月, 2006 1 次提交
    • B
      [PATCH] powerpc: Fix loss of interrupts with MPIC · ba1826e5
      Benjamin Herrenschmidt 提交于
      With the new interrupt rework, an interrupt "host" map() callback can be
      called after the interrupt is already active.
      
      It's called again for an already mapped interrupt to allow changing the
      trigger setup, and currently this is not guarded with a test of wether
      the interrupt is requested or not.
      
      I plan to change some of this logic to be a bit less lenient against
      random reconfiguring of live interrupts but just not yet.
      
      The ported MPIC driver has a bug where when that happens, it will mask
      the interrupt.  This changes it to preserve the previous masking of the
      interrupt instead.
      Signed-off-by: NBenjamin Herrenschmidt <benh@kernel.crashing.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      ba1826e5
  3. 03 7月, 2006 4 次提交
  4. 01 7月, 2006 1 次提交
  5. 30 6月, 2006 2 次提交
    • I
      [PATCH] genirq: cleanup: merge irq_affinity[] into irq_desc[] · a53da52f
      Ingo Molnar 提交于
      Consolidation: remove the irq_affinity[NR_IRQS] array and move it into the
      irq_desc[NR_IRQS].affinity field.
      
      [akpm@osdl.org: sparc64 build fix]
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      a53da52f
    • I
      [PATCH] genirq: rename desc->handler to desc->chip · d1bef4ed
      Ingo Molnar 提交于
      This patch-queue improves the generic IRQ layer to be truly generic, by adding
      various abstractions and features to it, without impacting existing
      functionality.
      
      While the queue can be best described as "fix and improve everything in the
      generic IRQ layer that we could think of", and thus it consists of many
      smaller features and lots of cleanups, the one feature that stands out most is
      the new 'irq chip' abstraction.
      
      The irq-chip abstraction is about describing and coding and IRQ controller
      driver by mapping its raw hardware capabilities [and quirks, if needed] in a
      straightforward way, without having to think about "IRQ flow"
      (level/edge/etc.) type of details.
      
      This stands in contrast with the current 'irq-type' model of genirq
      architectures, which 'mixes' raw hardware capabilities with 'flow' details.
      The patchset supports both types of irq controller designs at once, and
      converts i386 and x86_64 to the new irq-chip design.
      
      As a bonus side-effect of the irq-chip approach, chained interrupt controllers
      (master/slave PIC constructs, etc.) are now supported by design as well.
      
      The end result of this patchset intends to be simpler architecture-level code
      and more consolidation between architectures.
      
      We reused many bits of code and many concepts from Russell King's ARM IRQ
      layer, the merging of which was one of the motivations for this patchset.
      
      This patch:
      
      rename desc->handler to desc->chip.
      
      Originally i did not want to do this, because it's a big patch.  But having
      both "desc->handler", "desc->handle_irq" and "action->handler" caused a
      large degree of confusion and made the code appear alot less clean than it
      truly is.
      
      I have also attempted a dual approach as well by introducing a
      desc->chip alias - but that just wasnt robust enough and broke
      frequently.
      
      So lets get over with this quickly.  The conversion was done automatically
      via scripts and converts all the code in the kernel.
      
      This renaming patch is the first one amongst the patches, so that the
      remaining patches can stay flexible and can be merged and split up
      without having some big monolithic patch act as a merge barrier.
      
      [akpm@osdl.org: build fix]
      [akpm@osdl.org: another build fix]
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      d1bef4ed
  6. 29 6月, 2006 3 次提交
  7. 28 6月, 2006 1 次提交
  8. 22 6月, 2006 1 次提交
  9. 21 6月, 2006 1 次提交
    • M
      [POWERPC] mpic: add support for serial mode interrupts · 868ea0c9
      Mark A. Greer 提交于
      On Tue, Jun 20, 2006 at 02:01:26PM +1000, Benjamin Herrenschmidt wrote:
      > On Mon, 2006-06-19 at 13:08 -0700, Mark A. Greer wrote:
      > > MPC10x-style interrupt controllers have a serial mode that allows
      > > several interrupts to be clocked in through one INT signal.
      > >
      > > This patch adds the software support for that mode.
      >
      > You hard code the clock ratio... why not add a separate call to be
      > called after mpic_init,
      > something like mpic_set_serial_int(int mpic, int enable, int
      > clock_ratio) ?
      
      How's this?
      --
      
      MPC10x-style interrupt controllers have a serial mode that allows
      several interrupts to be clocked in through one INT signal.
      
      This patch adds the software support for that mode.
      Signed-off-by: NMark A. Greer <mgreer@mvista.com>
      --
      
       arch/powerpc/sysdev/mpic.c |   20 ++++++++++++++++++++
       include/asm-powerpc/mpic.h |   10 ++++++++++
       2 files changed, 30 insertions(+)
      --
      Signed-off-by: NPaul Mackerras <paulus@samba.org>
      868ea0c9
  10. 15 6月, 2006 2 次提交
  11. 21 4月, 2006 1 次提交
    • O
      [PATCH] powerpc: Lower threshold for DART enablement to 1GB · 28897731
      Olof Johansson 提交于
      Turn on the DART already at 1GB. This is needed because of crippled
      devices in some systems, i.e. Airport Extreme cards, only supporting
      30-bit DMA addresses.
      
      Otherwise, users with between 1 and 2GB of memory will need to manually
      enable it with iommu=force, and that's no good.
      
      Some simple performance tests show that there's a slight impact of
      enabling DART, but it's in the 1-3% range (kernel build with disk I/O
      as well as over NFS).
      
      iommu=off can still be used for those who don't want to deal with the
      overhead (and don't need it for any devices).
      Signed-off-by: NOlof Johansson <olof@lixom.net>
      Signed-off-by: NPaul Mackerras <paulus@samba.org>
      28897731
  12. 24 2月, 2006 1 次提交
  13. 10 2月, 2006 1 次提交
  14. 08 2月, 2006 1 次提交
  15. 07 2月, 2006 3 次提交
  16. 14 1月, 2006 1 次提交
  17. 12 1月, 2006 1 次提交
  18. 11 1月, 2006 1 次提交
  19. 09 1月, 2006 5 次提交
  20. 23 11月, 2005 1 次提交
  21. 19 11月, 2005 1 次提交
  22. 10 11月, 2005 1 次提交
  23. 07 11月, 2005 2 次提交
    • D
      [PATCH] powerpc: Kill ppcdebug · dcad47fc
      David Gibson 提交于
      The ancient ppcdebug/PPCDBG mechanism is now only used in two places.
      First, in the hash setup code, one of the bits allows the size of the
      hash table to be reduced by a factor of 8 - which would be better
      accomplished with a command line option for that purpose.  The other
      was a bunch of bus walking related messages in the iSeries code, which
      would seem to be insufficient reason to keep the mechanism.
      
      This patch removes the last traces of this mechanism.
      
      Built and booted on iSeries and pSeries POWER5 LPAR (ARCH=powerpc).
      Signed-off-by: NDavid Gibson <dwg@au1.ibm.com>
      Signed-off-by: NPaul Mackerras <paulus@samba.org>
      dcad47fc
    • D
      [PATCH] powerpc: Fix i8259 cascade IRQ · 9d2ba6fa
      David Woodhouse 提交于
      setup_irq() aborts immediately if there's no handler for the IRQ in
      question. So i8259_init() should set up its handlers before trying to
      set up the cascade on IRQ 2.
      
      With this and the patch I sent a few days ago to fix initrd on ppc32, my
      Pegasos now runs the arch/powerpc kernel.
      Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>
      Signed-off-by: NPaul Mackerras <paulus@samba.org>
      9d2ba6fa
  24. 02 11月, 2005 1 次提交
  25. 01 11月, 2005 1 次提交
  26. 28 10月, 2005 1 次提交