1. 27 10月, 2015 8 次提交
    • A
      fix: lpfc_send_rscn_event sends bigger buffer size · 6599eaaa
      Ales Novak 提交于
      lpfc_send_rscn_event() allocates data for sizeof(struct
      lpfc_rscn_event_header) + payload_len, but claims that the data has size
      of sizeof(struct lpfc_els_event_header) + payload_len. That leads to
      buffer overruns.
      Signed-off-by: NAles Novak <alnovak@suse.cz>
      Signed-off-by: NJames Smart <james.smart@avagotech.com>
      Reviewed-by: NHannes Reinecke <hare@suse.de>
      Reviewed-by: NSebastian Herbszt <herbszt@gmx.de>
      Signed-off-by: NJames Bottomley <JBottomley@Odin.com>
      6599eaaa
    • S
      lpfc: remove set but not used variables · db6f1c2f
      Sebastian Herbszt 提交于
      Remove set but not used variables.
      Signed-off-by: NSebastian Herbszt <herbszt@gmx.de>
      Signed-off-by: NJames Smart <james.smart@avagotech.com>
      Reviewed-by: NHannes Reinecke <hare@suse.de>
      Signed-off-by: NJames Bottomley <JBottomley@Odin.com>
      db6f1c2f
    • N
      lpfc:Make the function lpfc_sli4_mbox_completions_pending static in order to... · 3bb11fc5
      Nicholas Krause 提交于
      lpfc:Make the function lpfc_sli4_mbox_completions_pending static in order to comply with function prototype
      
      This makes the function lpfc_sli4_mbox_completion's definition
      static now in order to comply with its prototype being also
      declared as static too.
      Signed-off-by: NNicholas Krause <xerofoify@gmail.com>
      Signed-off-by: NJames Smart <james.smart@avagotech.com>
      Reviewed-by: NSebastian Herbszt <herbszt@gmx.de>
      Reviewed-by: NHannes Reinecke <hare@suse.com>
      Signed-off-by: NJames Bottomley <JBottomley@Odin.com>
      3bb11fc5
    • I
      Fix kmalloc overflow in LPFC driver at large core count · c0365c06
      Ian Mitchell 提交于
      This patch allows the LPFC to start up without a fatal kernel bug based
      on an exceeded KMALLOC_MAX_SIZE and a too large NR_CPU-based maskbits
      field. The bug was based on the number of CPU cores in a system.
      Using the get_cpu_mask() function declared in kernel/cpu.c allows the
      driver to load on the community kernel 4.2 RC1.
      
      Below is the kernel bug reproduced:
      
      8<--------------------------------------------------------------------
      2199382.828437 (    0.005216)| lpfc 0003:02:00.0: enabling device (0140 -> 0142)
      2199382.999272 (    0.170835)| ------------[ cut here ]------------
      2199382.999337 (    0.000065)| WARNING: CPU: 84 PID: 404 at mm/slab_common.c:653 kmalloc_slab+0x2f/0x89()
      2199383.004534 (    0.005197)| Modules linked in: lpfc(+) usbcore(+) mptctl scsi_transport_fc sg lpc_ich i2c_i801 usb_common tpm_tis mfd_core tpm acpi_cpufreq button scsi_dh_alua scsi_dh_rdacusbcore: registered new device driver usb
      2199383.020568 (    0.016034)|
      2199383.020581 (    0.000013)|  scsi_dh_hp_sw scsi_dh_emc scsi_dh gru thermal sata_nv processor piix fan thermal_sysehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
      2199383.035288 (    0.014707)|
      2199383.035306 (    0.000018)|  hwmon ata_piix
      2199383.035336 (    0.000030)| CPU: 84 PID: 404 Comm: kworker/84:0 Not tainted 3.18.0-rc2-gat-00106-ga7ca10f2-dirty #178
      2199383.047077 (    0.011741)| ehci-pci: EHCI PCI platform driver
      2199383.047134 (    0.000057)| Hardware name: SGI UV2000/ROMLEY, BIOS SGI UV 2000/3000 series BIOS 01/15/2013
      2199383.056245 (    0.009111)| Workqueue: events work_for_cpu_fn
      2199383.066174 (    0.009929)|  000000000000028d ffff88eef827bbe8 ffffffff815a542f 000000000000028d
      2199383.069545 (    0.003371)|  ffffffff810ea142 ffff88eef827bc28 ffffffff8104365c ffff88eefe4006c8
      2199383.076214 (    0.006669)|  0000000000000000 00000000000080d0 0000000000000000 0000000000000004
      2199383.079213 (    0.002999)| Call Trace:
      2199383.084084 (    0.004871)|  [<ffffffff815a542f>] dump_stack+0x49/0x62
      2199383.087283 (    0.003199)|  [<ffffffff810ea142>] ? kmalloc_slab+0x2f/0x89
      2199383.091415 (    0.004132)|  [<ffffffff8104365c>] warn_slowpath_common+0x77/0x92
      2199383.095197 (    0.003782)|  [<ffffffff8104368c>] warn_slowpath_null+0x15/0x17
      2199383.103336 (    0.008139)|  [<ffffffff810ea142>] kmalloc_slab+0x2f/0x89
      2199383.107082 (    0.003746)|  [<ffffffff8110fd9e>] __kmalloc+0x13/0x16a
      2199383.112531 (    0.005449)|  [<ffffffffa01a8ed9>] lpfc_pci_probe_one_s4+0x105b/0x1644 [lpfc]
      2199383.115316 (    0.002785)|  [<ffffffff81302b92>] ? pci_bus_read_config_dword+0x75/0x87
      2199383.123431 (    0.008115)|  [<ffffffffa01a951f>] lpfc_pci_probe_one+0x5d/0xcb5 [lpfc]
      2199383.127364 (    0.003933)|  [<ffffffff81497119>] ? dbs_check_cpu+0x168/0x177
      2199383.136438 (    0.009074)|  [<ffffffff81496fa5>] ? gov_queue_work+0xb4/0xc0
      2199383.140407 (    0.003969)|  [<ffffffff8130b2a1>] local_pci_probe+0x1e/0x52
      2199383.143105 (    0.002698)|  [<ffffffff81052c47>] work_for_cpu_fn+0x13/0x1b
      2199383.147315 (    0.004210)|  [<ffffffff81054965>] process_one_work+0x222/0x35e
      2199383.151379 (    0.004064)|  [<ffffffff81054e76>] worker_thread+0x3d5/0x46e
      2199383.159402 (    0.008023)|  [<ffffffff81054aa1>] ? process_one_work+0x35e/0x35e
      2199383.163097 (    0.003695)|  [<ffffffff810599c6>] kthread+0xc8/0xd2
      2199383.167476 (    0.004379)|  [<ffffffff810598fe>] ? kthread_freezable_should_stop+0x5b/0x5b
      2199383.176434 (    0.008958)|  [<ffffffff815a8cac>] ret_from_fork+0x7c/0xb0
      2199383.180086 (    0.003652)|  [<ffffffff810598fe>] ? kthread_freezable_should_stop+0x5b/0x5b
      2199383.192333 (    0.012247)| ehci-pci 0000:00:1a.0: EHCI Host Controller
      -------------------------------------------------------------------->8
      
      The proposed solution was approved by James Smart at Emulex and tested
      on a UV2 machine with 6144 cores. With the fix, the LPFC module loads
      with no unwanted effects on the system.
      Signed-off-by: NIan Mitchell <imitchell@sgi.com>
      Signed-off-by: NAlex Thorlton <athorlton@sgi.com>
      Suggested-by: NRobert Elliot <elliott@hp.com>
      [james.smart: resolve unused variable warning]
      Signed-off-by: NJames Smart <james.smart@avagotech.com>
      Signed-off-by: NJames Bottomley <JBottomley@Odin.com>
      c0365c06
    • J
      lpfc: Destroy lpfc_hba_index IDR on module exit · 7973967f
      Johannes Thumshirn 提交于
      Destroy lpfc_hba_index IDR on module exit, reclaiming the allocated memory.
      
      This was detected by the following semantic patch (written by Luis Rodriguez
      <mcgrof@suse.com>)
      <SmPL>
      @ defines_module_init @
      declarer name module_init, module_exit;
      declarer name DEFINE_IDR;
      identifier init;
      @@
      
      module_init(init);
      
      @ defines_module_exit @
      identifier exit;
      @@
      
      module_exit(exit);
      
      @ declares_idr depends on defines_module_init && defines_module_exit @
      identifier idr;
      @@
      
      DEFINE_IDR(idr);
      
      @ on_exit_calls_destroy depends on declares_idr && defines_module_exit @
      identifier declares_idr.idr, defines_module_exit.exit;
      @@
      
      exit(void)
      {
       ...
       idr_destroy(&idr);
       ...
      }
      
      @ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @
      identifier declares_idr.idr, defines_module_exit.exit;
      @@
      
      exit(void)
      {
       ...
       +idr_destroy(&idr);
      }
      </SmPL>
      Signed-off-by: NJohannes Thumshirn <jthumshirn@suse.de>
      Signed-off-by: NJames Smart <james.smart@avagotech.com>
      Reviewed-by: NHannes Reinecke <hare@suse.de>
      Signed-off-by: NJames Bottomley <JBottomley@Odin.com>
      7973967f
    • B
      lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize · 5f406fae
      Bodo Stroesser 提交于
      Currently the module parameter lpfc_sg_seg_count does not have effect
      for sli3 devices.
      
      In lpfc_sli_driver_resource_setup(), which is used for sli3, the code
      writes the configured sg_seg_cnt into lpfc_template.sg_tablesize.
      But lpfc_template is the template used for sli4 only. Thus the value should
      correctly be written to lpfc_template_s3->sg_tablesize.
      
      This patch is for kernel 4.1-rc5, but is tested with lpfc 10.2.405.26 only.
      Signed-off-by: NBodo Stroesser <bstroesser@ts.fujitsu.com>
      Signed-off-by: NJames Smart <james.smart@avagotech.com>
      Reviewed-by: NSebastian Herbszt <herbszt@gmx.de>
      Reviewed-by: NHannes Reinecke <hare@suse.com>
      Signed-off-by: NJames Bottomley <JBottomley@Odin.com>
      5f406fae
    • F
      lpfc: Remove unnessary cast · c6cb9b4f
      Firo Yang 提交于
      kzalloc() returns a void pointer - no need to cast it in
      drivers/scsi/lpfc/lpfc_init.c::lpfc_sli_driver_resource_setup()
      Signed-off-by: NFiro Yang <firogm@gmail.com>
      Signed-off-by: NJames Smart <james.smart@avagotech.com>
      Signed-off-by: NJames Bottomley <JBottomley@Odin.com>
      c6cb9b4f
    • S
      lpfc: fix model description · 290237d2
      Sebastian Herbszt 提交于
      Remove trailing space from model description.
      Signed-off-by: NSebastian Herbszt <herbszt@gmx.de>
      Signed-off-by: NJames Smart <james.smart@avagotech.com>
      Reviewed-by: NHannes Reinecke <hare@suse.com>
      Signed-off-by: NJames Bottomley <JBottomley@Odin.com>
      290237d2
  2. 08 10月, 2015 1 次提交
  3. 02 10月, 2015 1 次提交
    • P
      scsi_dh: Use the correct module name when loading device handler · 1378889c
      Paul Mackerras 提交于
      This fixes a bug in recent kernels which results in failure to boot
      on systems that have multipath SCSI disks.  I observed this failure
      on a POWER8 server where all the disks are multipath SCSI disks.
      The symptoms are several messages like this on the console:
      
      [    3.018700] device-mapper: table: 253:0: multipath: error attaching hardware handler
      [    3.018828] device-mapper: ioctl: error adding target to table
      
      and the system does not find its disks, and therefore fails to boot.
      
      Bisection revealed that the bug was introduced in commit 566079c8,
      "dm-mpath, scsi_dh: request scsi_dh modules in scsi_dh, not dm-mpath".
      The specific reason for the failure is that where we previously loaded
      the "scsi_dh_alua" module, we are now trying to load the "alua" module,
      which doesn't exist.
      
      To fix this, we change the request_module call in scsi_dh_lookup()
      to prepend "scsi_dh_" to the name, just like the old code in
      drivers/md/dm-mpath.c:parse_hw_handler() used to do.
      
      [jejb: also fixes issue spotted by Sasha Levin that formatting
      characters could be passed in via sysfs and cause issues with
      request_module()]
      
      Fixes: 566079c8Signed-off-by: NPaul Mackerras <paulus@ozlabs.org>
      Cc: Sasha Levin <sasha.levin@oracle.com>
      Reviewed-by: NHannes Reinecke <hare@suse.com>
      Reviewed-by: NChristoph Hellwig <hch@lst.de>
      Signed-off-by: NJames Bottomley <JBottomley@Odin.com>
      1378889c
  4. 17 9月, 2015 1 次提交
  5. 12 9月, 2015 3 次提交
    • L
      thermal: fix intel PCH thermal driver mismerge · dfb22fc5
      Linus Torvalds 提交于
      I didn't notice this when merging the thermal code from Zhang, but his
      merge (commit 5a924a07: "Merge branches 'thermal-core' and
      'thermal-intel' of .git into next") of the thermal-core and
      thermal-intel branches was wrong.
      
      In thermal-core, commit 17e8351a ("thermal: consistently use int for
      temperatures") converted the thermal layer to use "int" for
      temperatures.
      
      But in parallel, in the thermal-intel branch commit d0a12625
      ("thermal: Add Intel PCH thermal driver") added support for the intel
      PCH thermal sensor using the old interfaces that used "unsigned long"
      pointers.
      
      This resulted in warnings like this:
      
        drivers/thermal/intel_pch_thermal.c:184:14: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
          .get_temp = pch_thermal_get_temp,
                      ^
        drivers/thermal/intel_pch_thermal.c:184:14: note: (near initialization for ‘tzd_ops.get_temp’)
        drivers/thermal/intel_pch_thermal.c:186:19: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
          .get_trip_temp = pch_get_trip_temp,
                           ^
        drivers/thermal/intel_pch_thermal.c:186:19: note: (near initialization for ‘tzd_ops.get_trip_temp’)
      
      This fixes it.
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      dfb22fc5
    • J
      fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void · 6798a8ca
      Joe Perches 提交于
      The seq_<foo> function return values were frequently misused.
      
      See: commit 1f33c41c ("seq_file: Rename seq_overflow() to
           seq_has_overflowed() and make public")
      
      All uses of these return values have been removed, so convert the
      return types to void.
      
      Miscellanea:
      
      o Move seq_put_decimal_<type> and seq_escape prototypes closer the
        other seq_vprintf prototypes
      o Reorder seq_putc and seq_puts to return early on overflow
      o Add argument names to seq_vprintf and seq_printf
      o Update the seq_escape kernel-doc
      o Convert a couple of leading spaces to tabs in seq_escape
      Signed-off-by: NJoe Perches <joe@perches.com>
      Cc: Al Viro <viro@ZenIV.linux.org.uk>
      Cc: Steven Rostedt <rostedt@goodmis.org>
      Cc: Mark Brown <broonie@kernel.org>
      Cc: Stephen Rothwell <sfr@canb.auug.org.au>
      Cc: Joerg Roedel <jroedel@suse.de>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      6798a8ca
    • C
      scsi_dh: fix randconfig build error · 294ab783
      Christoph Hellwig 提交于
      It looks like the Kconfig check that was meant to fix this (commit
      fe9233fb [SCSI] scsi_dh: fix kconfig related
      build errors) was actually reversed, but no-one noticed until the new set of
      patches which separated DM and SCSI_DH).
      
      Fixes: fe9233fbSigned-off-by: NChristoph Hellwig <hch@lst.de>
      Tested-by: NMike Snitzer <snitzer@redhat.com>
      Signed-off-by: NJames Bottomley <JBottomley@Odin.com>
      294ab783
  6. 11 9月, 2015 21 次提交
  7. 10 9月, 2015 5 次提交