1. 19 5月, 2012 1 次提交
    • S
      USB: Disable hub-initiated LPM for comms devices. · e1f12eb6
      Sarah Sharp 提交于
      Hub-initiated LPM is not good for USB communications devices.  Comms
      devices should be able to tell when their link can go into a lower power
      state, because they know when an incoming transmission is finished.
      Ideally, these devices would slam their links into a lower power state,
      using the device-initiated LPM, after finishing the last packet of their
      data transfer.
      
      If we enable the idle timeouts for the parent hubs to enable
      hub-initiated LPM, we will get a lot of useless LPM packets on the bus
      as the devices reject LPM transitions when they're in the middle of
      receiving data.  Worse, some devices might blindly accept the
      hub-initiated LPM and power down their radios while they're in the
      middle of receiving a transmission.
      
      The Intel Windows folks are disabling hub-initiated LPM for all USB
      communications devices under a xHCI USB 3.0 host.  In order to keep
      the Linux behavior as close as possible to Windows, we need to do the
      same in Linux.
      
      Set the disable_hub_initiated_lpm flag for for all USB communications
      drivers.  I know there aren't currently any USB 3.0 devices that
      implement these class specifications, but we should be ready if they do.
      Signed-off-by: NSarah Sharp <sarah.a.sharp@linux.intel.com>
      Cc: Marcel Holtmann <marcel@holtmann.org>
      Cc: Gustavo Padovan <gustavo@padovan.org>
      Cc: Johan Hedberg <johan.hedberg@gmail.com>
      Cc: Hansjoerg Lipp <hjlipp@web.de>
      Cc: Tilman Schmidt <tilman@imap.cc>
      Cc: Karsten Keil <isdn@linux-pingi.de>
      Cc: Peter Korsgaard <jacmet@sunsite.dk>
      Cc: Jan Dumon <j.dumon@option.com>
      Cc: Petko Manolov <petkan@users.sourceforge.net>
      Cc: Steve Glendinning <steve.glendinning@smsc.com>
      Cc: "John W. Linville" <linville@tuxdriver.com>
      Cc: Kalle Valo <kvalo@qca.qualcomm.com>
      Cc: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>
      Cc: Jouni Malinen <jouni@qca.qualcomm.com>
      Cc: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
      Cc: Senthil Balasubramanian <senthilb@qca.qualcomm.com>
      Cc: Christian Lamparter <chunkeey@googlemail.com>
      Cc: Brett Rudley <brudley@broadcom.com>
      Cc: Roland Vossen <rvossen@broadcom.com>
      Cc: Arend van Spriel <arend@broadcom.com>
      Cc: "Franky (Zhenhui) Lin" <frankyl@broadcom.com>
      Cc: Kan Yan <kanyan@broadcom.com>
      Cc: Dan Williams <dcbw@redhat.com>
      Cc: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
      Cc: Ivo van Doorn <IvDoorn@gmail.com>
      Cc: Gertjan van Wingerde <gwingerde@gmail.com>
      Cc: Helmut Schaa <helmut.schaa@googlemail.com>
      Cc: Herton Ronaldo Krzesinski <herton@canonical.com>
      Cc: Hin-Tak Leung <htl10@users.sourceforge.net>
      Cc: Larry Finger <Larry.Finger@lwfinger.net>
      Cc: Chaoming Li <chaoming_li@realsil.com.cn>
      Cc: Daniel Drake <dsd@gentoo.org>
      Cc: Ulrich Kunitz <kune@deine-taler.de>
      Signed-off-by: NSarah Sharp <sarah.a.sharp@linux.intel.com>
      e1f12eb6
  2. 15 5月, 2012 1 次提交
  3. 11 5月, 2012 1 次提交
    • J
      drivers/net: Convert compare_ether_addr to ether_addr_equal · 2e42e474
      Joe Perches 提交于
      Use the new bool function ether_addr_equal to add
      some clarity and reduce the likelihood for misuse
      of compare_ether_addr for sorting.
      
      Done via cocci script:
      
      $ cat compare_ether_addr.cocci
      @@
      expression a,b;
      @@
      -	!compare_ether_addr(a, b)
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	compare_ether_addr(a, b)
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!ether_addr_equal(a, b) == 0
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!ether_addr_equal(a, b) != 0
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	ether_addr_equal(a, b) == 0
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	ether_addr_equal(a, b) != 0
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!!ether_addr_equal(a, b)
      +	ether_addr_equal(a, b)
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2e42e474
  4. 24 4月, 2012 7 次提交
  5. 17 4月, 2012 2 次提交
    • A
      net/wireless: use module_pci_driver · 5b0a3b7e
      Axel Lin 提交于
      This patch converts the drivers in drivers/net/wireless/* to use
      module_pci_driver() macro which makes the code smaller and a bit simpler.
      Signed-off-by: NAxel Lin <axel.lin@gmail.com>
      Cc: "John W. Linville" <linville@tuxdriver.com>
      Cc: Jiri Slaby <jirislaby@gmail.com>
      Cc: Nick Kossifidis <mickflemm@gmail.com>
      Cc: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>
      Cc: Simon Kelley <simon@thekelleys.org.uk>
      Cc: Jouni Malinen <j@w1.fi>
      Cc: Lennert Buytenhek <buytenh@wantstofly.org>
      Cc: Christian Lamparter <chunkeey@googlemail.com>
      Cc: Ivo van Doorn <IvDoorn@gmail.com>
      Cc: Larry Finger <Larry.Finger@lwfinger.net>
      Cc: linux-wireless@vger.kernel.org
      Acked-by: NLennert Buytenhek <buytenh@wantstofly.org>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      5b0a3b7e
    • L
      rtlwifi: rtl8192ce: Remove false positives for kmemleak · f11bbfd8
      Larry Finger 提交于
      When rtl8192ce is in operation, kmemleak indicates a number of leaks, yet
      when the driver is removed all are gone. These false positives happen
      in two locations:
      
      unreferenced object 0xffff880041124000 (size 9536):
        comm "work_for_cpu", pid 9295, jiffies 4295037203 (age 20596.320s)
        hex dump (first 32 bytes):
          33 00 00 01 01 6d 00 00 00 00 b1 0e 21 0b 00 00  3....m......!...
          01 01 6d 00 00 00 00 8b 20 c0 e9 00 00 01 01 6d  ..m..... ......m
        backtrace:
          [<ffffffff8137a1b1>] kmemleak_alloc+0x21/0x50
          [<ffffffff8138d01f>] kmalloc_large_node+0x9a/0xa6
          [<ffffffff811335a5>] __kmalloc_node_track_caller+0x175/0x3b0
          [<ffffffff812ddfe3>] __alloc_skb+0x73/0x230
          [<ffffffff812de1b8>] dev_alloc_skb+0x18/0x30
          [<ffffffffa091a3b7>] rtl_pci_probe+0x10e0/0x17d2 [rtlwifi]
      -- snip --
      unreferenced object 0xffff8800b4d3f600 (size 256):
        comm "kworker/u:2", pid 13221, jiffies 4297830173 (age 9424.568s)
        hex dump (first 32 bytes):
          1c d6 45 b1 00 88 ff ff 1c d6 45 b1 00 88 ff ff  ..E.......E.....
          00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
        backtrace:
          [<ffffffff8137a1b1>] kmemleak_alloc+0x21/0x50
          [<ffffffff81130f43>] kmem_cache_alloc_node+0x153/0x270
          [<ffffffff812ddfb6>] __alloc_skb+0x46/0x230
          [<ffffffff812de1b8>] dev_alloc_skb+0x18/0x30
          [<ffffffffa093264a>] rtl92c_set_fw_rsvdpagepkt+0x22a/0x5c0 [rtl8192c_common]
      -- snip --
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      f11bbfd8
  6. 15 4月, 2012 1 次提交
  7. 13 4月, 2012 3 次提交
  8. 12 4月, 2012 3 次提交
  9. 11 4月, 2012 2 次提交
  10. 10 4月, 2012 5 次提交
  11. 27 3月, 2012 1 次提交
  12. 20 3月, 2012 1 次提交
  13. 07 3月, 2012 1 次提交
  14. 06 3月, 2012 3 次提交
  15. 28 2月, 2012 1 次提交
  16. 23 2月, 2012 4 次提交
  17. 13 2月, 2012 1 次提交
  18. 10 2月, 2012 2 次提交