1. 14 3月, 2012 1 次提交
  2. 13 3月, 2012 11 次提交
  3. 08 3月, 2012 3 次提交
    • T
      mac80211: fix smatch lock errors in mesh · f06c7885
      Thomas Pedersen 提交于
      smatch was complaining:
      
      CHECK   net/mac80211/mesh_pathtbl.c
      net/mac80211/mesh_pathtbl.c:562 mesh_path_add() error: double lock
      'bottom_half:'
      net/mac80211/mesh_pathtbl.c:580 mesh_path_add() error: double unlock
      'bottom_half:'
      net/mac80211/mesh_pathtbl.c:589 mesh_path_add() error: double unlock
      'bottom_half:'
      net/mac80211/mesh_pathtbl.c:691 mpp_path_add() error: double lock
      'bottom_half:'
      net/mac80211/mesh_pathtbl.c:707 mpp_path_add() error: double unlock
      'bottom_half:'
      net/mac80211/mesh_pathtbl.c:716 mpp_path_add() error: double unlock
      'bottom_half:'
      net/mac80211/mesh_pathtbl.c:814 mesh_path_flush_by_nexthop() error:
      double lock 'bottom_half:'
      net/mac80211/mesh_pathtbl.c:819 mesh_path_flush_by_nexthop() error:
      double unlock 'bottom_half:'
      net/mac80211/mesh_pathtbl.c:887 mesh_path_del() error: double lock
      'bottom_half:'
      net/mac80211/mesh_pathtbl.c:901 mesh_path_del() error: double unlock
      'bottom_half:'
      
      So don't lock / unlock with _bh() while bottom halves are already
      disabled.
      Reported-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NThomas Pedersen <thomas@cozybit.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      f06c7885
    • A
      mac80211: Fix potential null pointer dereferencing · 3d4f9699
      Ashok Nagarajan 提交于
      The patch "{nl,cfg,mac}80211: Implement RSSI threshold for mesh peering"
      has a potential null pointer dereferencing problem. Thanks to Dan Carpenter
      for pointing out. This patch will fix the issue.
      Signed-off-by: NAshok Nagarajan <ashok@cozybit.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      3d4f9699
    • P
      mac80211: Filter duplicate IE ids · fcff4f10
      Paul Stewart 提交于
      mac80211 is lenient with respect to reception of corrupted beacons.
      Even if the frame is corrupted as a whole, the available IE elements
      are still passed back and accepted, sometimes replacing legitimate
      data.  It is unknown to what extent this "feature" is made use of,
      but it is clear that in some cases, this is detrimental.  One such
      case is reported in http://crosbug.com/26832 where an AP corrupts
      its beacons but not its probe responses.
      
      One approach would be to completely reject frames with invaid data
      (for example, if the last tag extends beyond the end of the enclosing
      PDU).  The enclosed approach is much more conservative: we simply
      prevent later IEs from overwriting the state from previous ones.
      This approach hopes that there might be some salient data in the
      IE stream before the corruption, and seeks to at least prevent that
      data from being overwritten.  This approach will fix the case above.
      
      Further, we flag element structures that contain data we think might
      be corrupted, so that as we fill the mac80211 BSS structure, we try
      not to replace data from an un-corrupted probe response with that
      of a corrupted beacon, for example.
      
      Short of any statistics gathering in the various forms of AP breakage,
      it's not possible to ascertain the side effects of more stringent
      discarding of data.
      Signed-off-by: NPaul Stewart <pstew@chromium.org>
      Cc: Sam Leffler <sleffler@chromium.org>
      Cc: Eliad Peller <eliad@wizery.com>
      Acked-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      fcff4f10
  4. 07 3月, 2012 21 次提交
  5. 06 3月, 2012 4 次提交