1. 24 4月, 2009 1 次提交
    • A
      USB: g_file_storage: fix use-after-free bug when closing files · 82a10a81
      Alan Stern 提交于
      This patch (as1231) fixes a use-after-free bug in g_file_storage.  A
      device's name may not be available after the device is unregistered,
      even if the device structure itself is still allocated.  Since
      close_backing_file() prints a LUN's name for debugging, it shouldn't
      be called after the LUN has been unregistered.
      
      That whole area needed to be cleaned up; the backing files were
      getting closed in a couple of different places.  The patch fixes
      things so that they get closed in just one place, as part of the
      unbind procedure, immediately before the LUN is unregistered.
      Signed-off-by: NAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      82a10a81
  2. 25 3月, 2009 1 次提交
  3. 16 3月, 2009 1 次提交
    • J
      Use f_lock to protect f_flags · db1dd4d3
      Jonathan Corbet 提交于
      Traditionally, changes to struct file->f_flags have been done under BKL
      protection, or with no protection at all.  This patch causes all f_flags
      changes after file open/creation time to be done under protection of
      f_lock.  This allows the removal of some BKL usage and fixes a number of
      longstanding (if microscopic) races.
      Reviewed-by: NChristoph Hellwig <hch@lst.de>
      Cc: Al Viro <viro@ZenIV.linux.org.uk>
      Signed-off-by: NJonathan Corbet <corbet@lwn.net>
      db1dd4d3
  4. 28 2月, 2009 1 次提交
  5. 08 1月, 2009 2 次提交
  6. 06 1月, 2009 1 次提交
    • C
      add a vfs_fsync helper · 4c728ef5
      Christoph Hellwig 提交于
      Fsync currently has a fdatawrite/fdatawait pair around the method call,
      and a mutex_lock/unlock of the inode mutex.  All callers of fsync have
      to duplicate this, but we have a few and most of them don't quite get
      it right.  This patch adds a new vfs_fsync that takes care of this.
      It's a little more complicated as usual as ->fsync might get a NULL file
      pointer and just a dentry from nfsd, but otherwise gets afile and we
      want to take the mapping and file operations from it when it is there.
      
      Notes on the fsync callers:
      
       - ecryptfs wasn't calling filemap_fdatawrite / filemap_fdatawait on the
         	lower file
       - coda wasn't calling filemap_fdatawrite / filemap_fdatawait on the host
      	file, and returning 0 when ->fsync was missing
       - shm wasn't calling either filemap_fdatawrite / filemap_fdatawait nor
         taking i_mutex.  Now given that shared memory doesn't have disk
         backing not doing anything in fsync seems fine and I left it out of
         the vfs_fsync conversion for now, but in that case we might just
         not pass it through to the lower file at all but just call the no-op
         simple_sync_file directly.
      
      [and now actually export vfs_fsync]
      Signed-off-by: NChristoph Hellwig <hch@lst.de>
      Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
      4c728ef5
  7. 18 10月, 2008 2 次提交
  8. 17 10月, 2008 1 次提交
  9. 26 7月, 2008 1 次提交
  10. 22 7月, 2008 2 次提交
  11. 03 5月, 2008 1 次提交
  12. 25 4月, 2008 2 次提交
  13. 15 2月, 2008 1 次提交
  14. 02 2月, 2008 1 次提交
  15. 20 10月, 2007 1 次提交
  16. 13 10月, 2007 4 次提交
  17. 23 8月, 2007 2 次提交
  18. 18 7月, 2007 1 次提交
    • R
      Freezer: make kernel threads nonfreezable by default · 83144186
      Rafael J. Wysocki 提交于
      Currently, the freezer treats all tasks as freezable, except for the kernel
      threads that explicitly set the PF_NOFREEZE flag for themselves.  This
      approach is problematic, since it requires every kernel thread to either
      set PF_NOFREEZE explicitly, or call try_to_freeze(), even if it doesn't
      care for the freezing of tasks at all.
      
      It seems better to only require the kernel threads that want to or need to
      be frozen to use some freezer-related code and to remove any
      freezer-related code from the other (nonfreezable) kernel threads, which is
      done in this patch.
      
      The patch causes all kernel threads to be nonfreezable by default (ie.  to
      have PF_NOFREEZE set by default) and introduces the set_freezable()
      function that should be called by the freezable kernel threads in order to
      unset PF_NOFREEZE.  It also makes all of the currently freezable kernel
      threads call set_freezable(), so it shouldn't cause any (intentional)
      change of behaviour to appear.  Additionally, it updates documentation to
      describe the freezing of tasks more accurately.
      
      [akpm@linux-foundation.org: build fixes]
      Signed-off-by: NRafael J. Wysocki <rjw@sisk.pl>
      Acked-by: NNigel Cunningham <nigel@nigel.suspend2.net>
      Cc: Pavel Machek <pavel@ucw.cz>
      Cc: Oleg Nesterov <oleg@tv-sign.ru>
      Cc: Gautham R Shenoy <ego@in.ibm.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      83144186
  19. 13 7月, 2007 2 次提交
  20. 26 6月, 2007 1 次提交
  21. 12 2月, 2007 1 次提交
  22. 08 2月, 2007 2 次提交
  23. 21 12月, 2006 1 次提交
    • D
      USB: gadget driver unbind() is optional; section fixes; misc · 6bea476c
      David Brownell 提交于
      Allow gadget drivers to omit the unbind() method.  When they're
      statically linked, that's an appropriate memory saving tweak.
      
      Similarly, provide consistent/simpler handling for a should-not-happen
      error case:  removing a peripheral controller driver when a gadget
      driver is still loaded.  Such code dates back to early versions of the
      first implementation of the gadget API, and has never been triggered.
      
      Includes relevant section annotation fixs for gmidi.c, file_storage.c,
      and serial.c; we don't yet have an "init or exit" annotation.  Also
      some whitespace fixes in gmidi.c (space at EOL, before tabs, etc).
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      6bea476c
  24. 09 12月, 2006 1 次提交
  25. 08 12月, 2006 1 次提交
  26. 02 10月, 2006 1 次提交
    • S
      [PATCH] namespaces: utsname: use init_utsname when appropriate · 96b644bd
      Serge E. Hallyn 提交于
      In some places, particularly drivers and __init code, the init utsns is the
      appropriate one to use.  This patch replaces those with a the init_utsname
      helper.
      
      Changes: Removed several uses of init_utsname().  Hope I picked all the
      	right ones in net/ipv4/ipconfig.c.  These are now changed to
      	utsname() (the per-process namespace utsname) in the previous
      	patch (2/7)
      
      [akpm@osdl.org: CIFS fix]
      Signed-off-by: NSerge E. Hallyn <serue@us.ibm.com>
      Cc: Kirill Korotaev <dev@openvz.org>
      Cc: "Eric W. Biederman" <ebiederm@xmission.com>
      Cc: Herbert Poetzl <herbert@13thfloor.at>
      Cc: Andrey Savochkin <saw@sw.ru>
      Cc: Serge Hallyn <serue@us.ibm.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      96b644bd
  27. 29 9月, 2006 2 次提交
  28. 13 7月, 2006 1 次提交
    • D
      [PATCH] USB: gadget section fixups · a353678d
      David Brownell 提交于
      Recent section changes broke gadget builds on some platforms.  This patch
      is the best fix that's available until better section markings exist:
      
       - There's a lot of cleanup code that gets used in both init and exit paths;
         stop marking it as "__exit".
      
         (Best fix for this would be an "__init_or_exit" section marking, putting
         the cleanup in __init when __exit sections get discarded else in __exit.)
      
       - Stop marking the use-once probe routines as "__init" since references
         to those routines are not allowed from driver structures.  They're now
         marked "__devinit", which in practice is a net lose.
      
         (Best fix for this is likely to separate such use-once probe routines
         from the driver structure ... but in general, all busses that aren't
         hotpluggable will be forced to waste memory for all probe-only code.)
      
      In general these broken section rules waste an average of two to four kBytes
      per driver of code bloat ... because none of the relevant code can ever be
      reused after module initialization.
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      a353678d
  29. 01 7月, 2006 1 次提交