We will fail to probe without one.
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

We never set the GPIO from atomic context so there's no reason why we
can't support a GPIO that needs to sleep when configuring.
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

Fix warning by using format specifier %zu for type size_t

Sparse warning:
sound/soc/codecs/wm0010.c:411:2: warning:
        format ‘%d’ expects argument of type ‘int’,
        but argument 4 has type ‘size_t’ [-Wformat]
Signed-off-by: NEmil Goode <emilgoode@gmail.com>
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

We're holding the wm0010->lock mutex when we goto err_core.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

FYI, there are new coccinelle warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.7
head:   e3523e01
commit: e3523e01 [95/95] ASoC: wm0010: Add initial wm0010 DSP driver

All coccinelle warnings:

+ sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
--
+ sound/soc/codecs/wm0010.c:660:1-7: preceding lock on line 359

vim +850 sound/soc/codecs/wm0010.c
   847			trigger = IRQF_TRIGGER_FALLING;
   848		trigger |= IRQF_ONESHOT;
   849
 > 850		ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger,
   851					   "wm0010", wm0010);
   852		if (ret)
   853			dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n",

Please consider folding the attached diff :-)
Signed-off-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

This is more idimatic for modern drivers. Also fix a couple of return
codes while we're at it.
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

Make it scan better by writing ROM with capitals.
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

We are using devm_ to allocate the GPIO so it will be freed automatically.
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

Doesn't make any practical difference given that _SUSPEND and _OFF are
equivalent for the driver but it's what we're really doing.
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

Make it easier to integrate the management of the clock supplying the
WM0010 with DAPM by providing a dummy supply widget which supplies the
interface widgets, this can be connected to clock outputs by the machines.
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

With appropriate clocking configuration the WM0010 driver supports 44.1kHz
audio; enable that.
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>

The WM0010 is a compact digital signal processor that has been
highly optimised for low-power audio applications.  Extensive memory
resources and core optimisation allow the device to manage all audio
processing algorithms efficiently and autonomously, while the host
processor sleeps or performs other tasks.
Signed-off-by: NDimitris Papastamos <dp@opensource.wolfsonmicro.com>
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>