Logical and-ing of a struct and its member should be replaced by the
member only as the struct has already been NULL tested before.
Signed-off-by: NShivani Bhardwaj <shivanib134@gmail.com>
Reviewed-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

A variable is initialized and then assigned values in the code but is
never used and therefore, should be removed.
Semantic patch used:
@@
type T;
identifier i;
constant C;
position p != e.p;
@@

- T i@p;
  <+... when != i
- i = C;
  ...+>
Signed-off-by: NShivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The variable ret is only declared and initialized to 0, but never
referenced, so remove it.
Signed-off-by: NShivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The clock divisor calculations in setMasterClock and setMemoryClock
unnecessaryly cast unsigned int to unsigned int. Removing the casting.
Signed-off-by: NMike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The getChipClock is used to detect MXCLK frequency. Make it's name
reflect what the function is actually doing.
Signed-off-by: NMike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The getChipClock function is used only to get MXCLK frequency, which
makes most of getPllValue function unused and thus. The detection of
MXCLK frequency may be implemented directly in getChipClock rendering
getPllValue and calcPLL unused.
Signed-off-by: NMike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

My first attempt to fix the Kconfig logic for wilc1000 was incomplete,
as it missed the case where SPI is built-in while SDIO is modular
and wilc1000 is configured as built-in in SPI mode (or vice versa),
which would still lead to a link failure.

This works around the problem by adding an intermediate Kconfig
symbol "WILC1000_DRIVER" that controls visibility of the SDIO and
SPI sub-drivers, so we can control the dependencies better.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Fixes: 9535ebc5 ("staging/wilc1000: fix Kconfig dependencies")
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

A recent change to wilc1000 accidentally deleted an important
variable, so we now get a build error when the SPI mode is
selected:

ERROR: "wilc_spi_dev" [drivers/staging/wilc1000/wilc1000.ko] undefined!

This partially reverts the broken commit to put the variable back.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Fixes: 56293ff2 ("staging: wilc1000: linux_wlan_spi: include header")
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Boolean tests do not need explicit comparison to true or false.
Signed-off-by: NLuis de Bethencourt <luisbg@osg.samsung.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace kmalloc followed by memcpy with kmemdup
Problem found using coccicheck
Signed-off-by: NShraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>
Signed-off-by: NAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>
Signed-off-by: NAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gu8FlushedJoinReqDrvHandler to join_req_drv
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gu32FlushedInfoElemAsocSize to info_element_size
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gu32FlushedJoinReqSize to join_req_size
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gu8FlushedAuthType to auth_type
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gu8Flushed11iMode to mode_11i
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gu8FlushedInfoElemAsoc to info_element
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gu8FlushedJoinReq to join_req
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes unused the variable gu32WidConnRstHack.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gu8DelBcn to del_beacon
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gu32InactiveTime to inactive_time
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gs8GetIP to get_ip
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gs8SetIP to set_ip
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gu8Chnl to ch_no
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gs8lnkspd to link_speed.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gs8Rssi to rssi
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gbScanWhileConnected to scan_while_connected
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable gapu8RcvdAssocResp to rcv_assoc_resp
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable g_hPeriodicRSSI to periodic_rssi
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable hSemHostIntDeinit to hif_sema_deinit
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames variable hWaitResponse to hif_sema_wait_response
to avoid CamelCase naming convention.
Signed-off-by: NLeo Kim <leo.kim@atmel.com>
Signed-off-by: NTony Cho <tony.cho@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>