- 30 3月, 2010 1 次提交
-
-
由 Tejun Heo 提交于
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: NTejun Heo <tj@kernel.org> Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
-
- 15 3月, 2010 1 次提交
-
-
由 Dan Carpenter 提交于
There was a problem introduced in Jul 2008 by: 0e6f9d27 pcmcia: use pcmcia_loop_config in scsi pcmcia drivers Signed-off-by: NDan Carpenter <error27@gmail.com> Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
-
- 13 3月, 2010 1 次提交
-
-
由 Julia Lawall 提交于
The few lines below the kfree of hdr_buf may go to the label err_free which will also free hdr_buf. The most straightforward solution seems to be to just move the kfree of hdr_buf after these gotos. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier E; expression E1; iterator I; statement S; @@ *kfree(E); ... when != E = E1 when != I(E,...) S when != &E *kfree(E); // </smpl> Signed-off-by: NJulia Lawall <julia@diku.dk> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Cc: <stable@kernel.org> Signed-off-by: NAndrew Morton <akpm@linux-foundation.org> Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
-
- 09 3月, 2010 2 次提交
-
-
由 Meelis Roos 提交于
qlogicpti driver registers its irq with a name containing slash. This results in [ 71.049735] WARNING: at fs/proc/generic.c:316 __xlate_proc_name+0xa8/0xb8() [ 71.132815] name 'Qlogic/PTI' because proc_mkdir with the name of the irq fails. Fix it by just removing the slash from irq name. Discovered and tested on real hardware (Sun Ultra 1). Signed-off-by: NMeelis Roos <mroos@linux.ee> Signed-off-by: NDavid S. Miller <davem@davemloft.net>
-
由 Gal Rosen 提交于
The issue occur while deleting 60 virtual ports through the sys interface /sys/class/fc_vports/vport-X/vport_delete. It happen while in a mistake each request sent twice for the same vport. This interface is asynchronous, entering the delete request into a work queue, allowing more than one request to enter to the delete work queue. The result is a NULL pointer. The first request already delete the vport, while the second request got a pointer to the vport before the device destroyed. Re-create vport later cause system freeze. Solution: Check vport flags before entering the request to the work queue. [jejb: fixed int<->long problem on spinlock flags variable] Signed-off-by: NGal Rosen <galr@storwize.com> Acked-by: NJames Smart <james.smart@emulex.com> Cc: Stable Tree <stable@kernel.org> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
- 08 3月, 2010 1 次提交
-
-
由 Uwe Kleine-König 提交于
A pointer to a probe callback is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: David Brownell <dbrownell@users.sourceforge.net> Cc: Dmitri Vorobiev <dmitri.vorobiev@movial.fi> Cc: Henrik Kretzschmar <henne@nachtwindheim.de> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: peter fuerst <post@pfrst.de> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Acked-by: NRalf Baechle <ralf@linux-mips.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
- 07 3月, 2010 22 次提交
-
-
由 Krishna Gudipati 提交于
Upgrade the upstream driver from 2.0.0.0 to 2.1.2.1. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
When IO is completed with underrun and with good SCSI status, check if the transferred bytes against scsi_cmnd->underflow, which is set to minimum number of bytes that must be transferred for this command, if is less than required minimum, complete the IO with DID_ERROR. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
MS module did not invoke fdmi offline in all cases, call fdmi offline when ms module receives a port offline, so that fdmi offline is from one place in the ms module. Make changes to handle 10G speed in the conversion routine. Replaced the usage of bfa_adapter_attr_s struct with specific API's. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Modified the portstats get/clear logic for port physical/FCoE/QoS stats. Added more stats to FC Fixed some issues with FCoE stats collection. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
bfa_ioc_attr_s is a big structure and some times could cause stack overflow if defined locally, so add specific APIs that are needed to replace the use of ioc_attr local var. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Rename pport structures to fcport in BFA FCS, to resolve confusion about the port structures in the firmware, and make sure the SG page is setup correctly. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Currently BFA was not checking for IOC down condition when issuing getstats/clearstats Add check to see if IOC is operational, before issuing getstats/clearstats. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Use dummy interrupt handlers till chip initialization is complete. Install real interrupt handlers after chip initialization. Also removed msix installation code in bfa_iocfc_init(). Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Fixed the issue of not acknowledging the command queue full-to-non-full interrupt. Implemented separate acknowledging functions for different ASIC and interrupt mode. Fixed the case of missing CPE interrupt by always processing the pending requests in the completion path. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
ioc_recover failed to work in fcmode. Fixed the code to initialize the ioc_regs.err_set during the notify_hbfail. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Replace enum types with int and rearrange the fields to fix some alignment issue. Local var ioc_attr is causing the stack to overflow, so removed the usage of the local ioc_attr var and now invoking an API to return the ioc_type. Fix some AEN issues. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Introduce a link notification state machine to handle next incoming link events while the current event is being delivered to the driver. When the event has been processed by the driver, the link notification state machine will queue the next event (if there is any) to the driver. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Made FCS authentication related changes to state machines and header files. Made changes in FCS state machines to handle the case when secret string is NULL. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Changed PCI VPD to incorporate specific OEM vendors. Added FCoE specific interrupt latency and delay params. Added some variables needed by FIP 2.0. Added some new logging and tracing definitions. Added reserved members to make the structures (IOC, IOCFC) 64bit aligned. Changed the module identifiers, as some files were moved. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Copy fpma MAC when requested by user space application. Added FPMA mac address to the lport attributes structure. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Make sure that in direct attach mode, we do not query the name server after a target is marked offline. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Replace bfa_assert() with bfa_sm_fault() to get unhandled events for debugging. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Clear LL_HALT and PSS_ERR bit in the interrupt status register on an IOC crash. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Add support for faster IOC recovery after failure. Split bfa_ioc.c into three files: bfa_ioc.c: Common code shared between crossbow and catapult ASIC's. bfa_ioc_cb.c: Code specific to the crossbow, reg mapping and interrupt related routines. bfa_ioc_ct.c: Code specific to the catapult, reg mapping and interrupt related routines. Fix to make sure IOC reinitialize's properly on enable request - update the ioc_fwstate reg with BFI_IOC_FAIL on ioc disable mbox cmd timeout. Makefile changes to support the 2 newly added files bfa_ioc_cb.c and bfa_ioc_ct.c. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
- 04 3月, 2010 8 次提交
-
-
由 Krishna Gudipati 提交于
bfad.c & bfad_drv.h: * Created a kernel thread from pci_probe that does the bfad start operations after BFA init done on a firmware mismatch. * The kernel thread on a fw mismatch waits for an event from IOC call back and is woken up from bfa_cb_init() on BFA init success. * In normal cases of no firmware mismatch this thread is terminated in pci_probe. bfa_fcs_lport.c, fabric.c, fcs_lport.h & vport.c: * Split the lport init to attach time and init time code, so that proper config attributes are set after firmware mismatch. bfa_iocfc.c: * Handle an IOC timer issue, where the IOC timer would expire before the init completion and send Init fail event to the driver, however IOC init continues and completes successfully at the later stage. The bfa and driver were not handling this kind of deferred init completion. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Brocade CNA currently supports only 190 vports (instead of 191), since there are only 192 unicast cam entries reserved for FCoE. Brocade CNA has a total of 256 unicast cam entries (192 FCoE + 64 LL) 192 cam entries = 1 burned in mac + 1 baseport FPMA mac + 190 vport FPMA macs. Made changes to the code to support only 190 vports. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Split bfa_fcs_init() into bfa_fcs_attach() and bfa_fcs_init(). Removed empty function definitions in FCS modules Modified driver to call bfa_fcs_attach() and bfa_fcs_init() as needed. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Added a FCS function to be called during driver init, to set the FDMI Driver parameter. fdmi.c: Created a disabled state when fdmi is disabled. bfad.c: * Added fdmi_enable driver parameter. * Added support to call bfa_fcs_set_fdmi_param() to initialize fcs fdmi setting. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
bfa_intr.c: Enable new halt interrupt in BFA. bfi_ctreg.h: Expose new halt interrupt bit definition to host. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
bfa_ioc.c: - Enable IOC auto-recovery by default. - When CNA is in FC mode, return IOC type as FC (not FCoE) bfa_iocfc.c: - Set fcmode before pci initialization/setup. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Clear virtual links was not propagated upwards to bfa from fw. This resulted in HBA and switch being in an inconsistent state. So defined a new LPS event for clear virtual link on a vport, and also now clear virtual link on a baseport, is sent as a link down event from the fw. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Krishna Gudipati 提交于
Added separate MSI-X module parameters to selectively enable / disable MSI-X interrupts for both Brocade HBA and CNA's. Signed-off-by: NKrishna Gudipati <kgudipat@brocade.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
- 03 3月, 2010 4 次提交
-
-
由 James Bottomley 提交于
RAID attributes uses scsi_is_sdev_device() to gate some SCSI specific checking code. This causes two problems. Firstly if SCSI == n just defining scsi_is_sdev_device() to return false might not be enough to prevent gcc from emitting the code (and thus referring to undefined symbols), so this needs surrounding with an ifdef. Secondly, using scsi_is_sdev_device() when SCSI is either y or m gives a subtle problem in the m case: raid_attrs must also be m to use the symbol. Do the usual Kconfig jiggery-pokery to fix this. Reported-by: NRandy Dunlap <randy.dunlap@oracle.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Boaz Harrosh 提交于
Doing CHECK="smatch --two-passes gives: drivers/scsi/osd/osd_initiator.c +1435 osd_finalize_request warning: assignment to 'ret' was never used Which is an unchecked possible allocation failure, Fixed. Reported-by: NDan Carpenter <error27@gmail.com> Signed-off-by: NBoaz Harrosh <bharrosh@panasas.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 Martin K. Petersen 提交于
Commit e3deec09 incorrectly assumed that the B0 and B1 page lengths were limited to 32 bytes. The B0 VPD page length is defined to be 64 bytes when the device supports thin provisioning. B1 is always defined to be 64 bytes. Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com> Reported-by: NDan Carpenter <error27@gmail.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-
由 James Smart 提交于
Signed-off-by: NJames Smart <james.smart@emulex.com> Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
-