Write-only ioctls should have a const argument in the ioctl op.
Do this conversion for vidioc_s_crop.
Adding const for write-only ioctls was decided during the 2012 Media Workshop.
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Rename all PCI drivers with their own directory under
drivers/media/video into drivers/media/pci and update the
building system.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

media_build/v4l/cx25821-core.c: In function 'cx_i2c_read_print':
media_build/v4l/cx25821-core.c:386:6: warning: variable 'value' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-core.c: In function 'cx25821_dev_setup':
media_build/v4l/cx25821-core.c:899:6: warning: variable 'io_size' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-core.c: In function 'cx25821_irq':
media_build/v4l/cx25821-core.c:1321:18: warning: variable 'pci_mask' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-i2c.c: In function 'cx25821_i2c_read':
media_build/v4l/cx25821-i2c.c:365:6: warning: variable 'retval' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-medusa-video.c: In function 'medusa_enable_bluefield_output':
media_build/v4l/cx25821-medusa-video.c:39:6: warning: variable 'ret_val' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-medusa-video.c: In function 'medusa_set_resolution':
media_build/v4l/cx25821-medusa-video.c:435:6: warning: variable 'ret_val' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-medusa-video.c: In function 'medusa_set_decoderduration':
media_build/v4l/cx25821-medusa-video.c:498:6: warning: variable 'ret_val' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-video.c: In function 'cx25821_dump_video_queue':
media_build/v4l/cx25821-video.c:116:25: warning: variable 'buf' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-video.c: In function 'cx25821_buffer_prepare':
media_build/v4l/cx25821-video.c:561:20: warning: variable 'line1_offset' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-video.c: In function 'video_ioctl_set':
media_build/v4l/cx25821-video.c:1834:6: warning: variable 'value' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-video-upstream.c: In function 'cx25821_upstream_irq':
media_build/v4l/cx25821-video-upstream.c:641:6: warning: variable 'msk_stat' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-video-upstream-ch2.c: In function 'cx25821_upstream_irq_ch2':
media_build/v4l/cx25821-video-upstream-ch2.c:591:6: warning: variable 'msk_stat' set but not used [-Wunused-but-set-variable]
media_build/v4l/cx25821-audio-upstream.c: In function 'cx25821_upstream_irq_audio':
media_build/v4l/cx25821-audio-upstream.c:589:6: warning: variable 'msk_stat' set but not used [-Wunused-but-set-variable]
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Fix indent of statements to improve readability.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Move operator in complex expression to the end of the line to preserve
consistency.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change multiple definitions in one statement into multiple statements
with one definition per statement.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change double assignment in one statement into two assignment
statements.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change double spaces between lexemes into single spaces.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Delete unnecessary empty line.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

If "i" is 2 then when we call cx25821_video_mux() we'd end up going
past the end of the cx25821_boards[dev->board]->input[].

The INPUT() macro obfuscates what's going on in that function so it's
a bit hard to follow.  And as Mauro points out the hard coded 2 is
not very helpful.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

This driver had the major issues already fixed. Move it out
of staging.
Acked-by: NGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Replace :? operator by equivalent if-else statement where in improves
readability. Don't add else branch if it is not needed.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Delete braces around single statements.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Change indent with spaces to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>