1. 11 4月, 2010 1 次提交
  2. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  3. 03 3月, 2010 1 次提交
  4. 18 2月, 2010 1 次提交
  5. 19 1月, 2010 1 次提交
    • G
      [SCSI] lpfc: restore MSI-X/MSI support · 8605c46c
      George Kadianakis 提交于
      A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx interrupts.
      This patch restores lpfc's ability to support MSI-X/MSI interrupts that the
      "Addition of SLI4 Interface - Base Support" patch [2] broke.
      It reestablishes MSI-X as the default interrupt method and in case MSI-X is not
      supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.
      
      [1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
      [2]: commit da0436e9
      
      [James Smart:
      Background:
      Nothing Broke. This was intended.
      
      We had originally enabled MSI-X by default, but in qualification within the
      last 12 months, we encountered a major catch-22:
      
      There were at least 4 platforms, from 2 major OEMs, that :
      - Say they support MSI-X - platform routines work and act as if they do.
      - We enable it, generate a test interrupt to check they really do deliver it,
      and it works.
      - But shortly after attachment, the system hangs or loses interrupts,
      resulting in a bad system behavior.
      
      Given the distro's picking up the 2.6.32 kernel, we had to stick with a
      default of MSI-X off, with user-enabled MSI-X as these platforms couldn't get
      fixed.
      
      However, we're also now encountering platforms that require MSI-X and never
      INTx, so we must change. It's desired also for also for performance reasons.
      
      So - now (2.6.33) is the right time to re-enable MSI-X by default.
      ]
      [jejb: fix up comment on default values]
      Signed-off-by: NGeorge Kadianakis <desnacked@gmail.com>
      Acked-by: NJames Smart  <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      8605c46c
  6. 05 12月, 2009 5 次提交
  7. 04 12月, 2009 1 次提交
  8. 23 8月, 2009 2 次提交
  9. 15 6月, 2009 1 次提交
    • J
      [SCSI] lpfc 8.3.3 : Fix various SLI-3 vs SLI-4 differences · f1126688
      James Smart 提交于
      Contains the following changes
      - Set the CT field of FDISC to 3
      - Fixed over allocation of SCSI buffers on SLI4
      - Removed unused jump table entries
      - Increase LPFC_WQE_DEF_COUNT to 256
      - Updated FDISC context to VPI
      - Fixed immediate SCSI command for LUN reset translation to WQE
      - Extended mailbox handling to allow MBX_POLL commands in between async
        MBQ commands
      - Fixed SID used for FDISC
      - Fix crash when accessing ctlregs from sysfs for SLI4 HBAs
      - Fix SLI4 firmware version not being saved or displayed correctly
      - Expand CQID field in WQE structure to 16 bits
      - Fix post header template mailbox command timing out
      - Removed FCoE PCI device ID 0x0705
      Signed-off-by: NJames Smart <James.Smart@emulex.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@HansenPartnership.com>
      f1126688
  10. 09 6月, 2009 6 次提交
  11. 27 4月, 2009 2 次提交
    • J
      [SCSI] lpfc 8.3.1: misc fixes/changes · a257bf90
      James Smart 提交于
      8.3.1 Fixes/Changes :
      
      - Fix incorrect byte-swapping on word 4 of IOCB (data length) which
        caused LUNs to not be discovered on big-endian (e.g. PPC)
      
      - Remove a bad cast of MBslimaddr which loses the __iomem (sparse)
      
      - Make lpfc_debugfs_mask_disc_trc static (sparse)
      
      - Correct misspelled word BlockGuard in lpfc_logmsg.h comment
      
      - Replaced repeated code segment for canceling IOCBs from a list with
        a function call, lpfc_sli_cancel_iocbs().
      
      - Increased HBQ buffers to support 40KB SSC sequences.
      
      - Added sysfs interface to update speed and topology parameter without
        link bounce.
      
      - Fixed bug with sysfs fc_host WWNs not being updated after changing
        the WWNs.
      
      - Check if the active mailbox is NULL in the beginning of the mailbox
        timeout handler - fixes panic in the mailbox timeout handler while
        running IO stress test
      
      - Fixed system panic in lpfc_pci_remove_one() due to ndlp indirect
        reference to phba through vport
      
      - Removed de-reference of scsi device after call to scsi_done() to fix
        panic in scsi completion path while accessing scsi device after
        scsi_done is called.
      
      - Fixed "Nodelist not empty" message when unloading the driver after
        target reboot test
      
      - Added LP2105 HBA model description
      
      - Added code to print all 16 words of unrecognized ASYNC events
      
      - Fixed memory leak in vport create + delete loop
      
      - Added support for handling dual error bit from HBA
      
      - Fixed a driver NULL pointer dereference in lpfc_sli_process_sol_iocb
      
      - Fixed a discovery bug with FC switch reboot in lpfc_setup_disc_node
      
      - Take NULL termintator into account when calculating available buffer space
      Signed-off-by: NJames Smart <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@HansenPartnership.com>
      a257bf90
    • J
  12. 30 12月, 2008 3 次提交
  13. 13 10月, 2008 6 次提交
  14. 12 7月, 2008 1 次提交
    • J
      [SCSI] lpfc 8.2.7 : Miscellaneous Fixes · 495a714c
      James Smart 提交于
      Miscellaneous Fixes:
      - Fix bug in mbox sysfs interface that locked in EAGAIN if discovery stalled.
      - Fix missing error message when npiv and loop are true when link up occurs.
      - Fix panic in lpfc_scsi_cmd_iocb_cmpl: scsi_buf was NULL, but created
        race conditions with other code paths.
      - Fix error in sysfs mailbox structure that didn't rezero on next use.
      - Add missing mempool_free() to attachment failure path
      - Fix missing put of ndlp structure during driver unload.
      - Fix applications unable to send mailbox commands during discovery.
      - Remove unused argument (type) from function lpfc_post_buffer() API
      - Fix vport name is not shown after hbacmd vportcreate.
      - Remove repeated code statements.
      Signed-off-by: NJames Smart <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@HansenPartnership.com>
      495a714c
  15. 23 4月, 2008 1 次提交
  16. 20 4月, 2008 1 次提交
  17. 10 4月, 2008 2 次提交
    • J
      [SCSI] lpfc 8.2.6 : Miscellaneous Fixes · 97eab634
      James Smart 提交于
      Miscellaneous Fixes
      - Allow WRITE_VPARAM command when the virtual port is in a stopped state
      - Fixed handling of our queue depth max that was unconditionally raising
        the depth on all vports, rather than just the vport affected.
      - Fix race in interrupt handler for mailbox processing that did not take
        out the host lock.
      - Removed unused functions: find_node, findnode_rpi, and fabric_abort_flogi
      - Correct misspelled word unsolicited in message 0146
      - Correct HW-error 5 handling - it should not reset the adapter
      - Correct handling of IOCBs, which did not null out our pCmd field before
        invoking the midlayer io done function.
      - Changed our maximum supported target id to 4096
      Signed-off-by: NJames Smart <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@HansenPartnership.com>
      97eab634
    • J
      [SCSI] lpfc 8.2.6 : Multiple discovery fixes · 58da1ffb
      James Smart 提交于
      Multiple Discovery Fixes:
      - Fix race on discovery due to link events coinciding with vport_delete.
      - Use NLP_FABRIC state to filter out switch-based pseudo initiators that
         reuse the same WWNs.
      - Correct erroneous setting of DID=0 in lpfc_matchdid()
      - Correct extra reference count that was in the lookup path for the
        remoteid from an unsolicited ELS.
      - Correct double-free bug in els abort path.
      - Correct FDMI server discovery logic for switch that return a WWN of 0.
      - Fix bugs in ndlp mgmt when a node changes address
      - Correct bug that did not delete RSCNs for vports upon link transitions
      - Fix "0216 Link event during NS query" error which pops up when vports
        are swapped to different switch ports.
      - Add sanity checks on ndlp structures
      - Fix devloss log message to dump WWN correctly
      - Hold off mgmt commands that were interferring with discovery mailbox cmds
      - Remove unnecessary FC_ESTABLISH_LINK logic.
      - Correct some race conditions in the worker thread, resulting in devloss:
        - Clear the work_port_events field before handling the work port events
        - Clear the deferred ring event before handling a deferred ring event
        - Hold the hba lock when waking up the work thread
        - Send an acc for the rscn even when we aren't going to handle it
      - Fix locking behavior that was not properly protecting the ACTIVE flag,
        thus allowing mailbox command order to shift.
      Signed-off-by: NJames Smart <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@HansenPartnership.com>
      58da1ffb
  18. 12 2月, 2008 3 次提交
  19. 24 1月, 2008 1 次提交