1. 18 3月, 2009 1 次提交
  2. 08 3月, 2009 1 次提交
    • C
      x86: UV: remove uv_flush_tlb_others() WARN_ON · 3a450de1
      Cliff Wickman 提交于
      In uv_flush_tlb_others() (arch/x86/kernel/tlb_uv.c),
      the "WARN_ON(!in_atomic())" fails if CONFIG_PREEMPT is not enabled.
      
      And CONFIG_PREEMPT is not enabled by default in the distribution that
      most UV owners will use.
      
      We could #ifdef CONFIG_PREEMPT the warning, but that is not good form.
      And there seems to be no suitable fix to in_atomic() when CONFIG_PREMPT
      is not on.
      
      As Ingo commented:
      
        > and we have no proper primitive to test for atomicity. (mainly
        > because we dont know about atomicity on a non-preempt kernel)
      
      So we drop the WARN_ON.
      Signed-off-by: NCliff Wickman <cpw@sgi.com>
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      3a450de1
  3. 18 2月, 2009 2 次提交
  4. 31 1月, 2009 1 次提交
  5. 29 1月, 2009 1 次提交
  6. 21 1月, 2009 1 次提交
    • T
      x86: uv cleanup · bdbcdd48
      Tejun Heo 提交于
      Impact: cleanup
      
      Make the following uv related cleanups.
      
      * collect visible uv related definitions and interfaces into uv/uv.h
        and use it.  this cleans up the messy situation where on 64bit, uv
        is defined properly, on 32bit generic it's dummy and on the rest
        undefined.  after this clean up, uv is defined on 64 and dummy on
        32.
      
      * update uv_flush_tlb_others() such that it takes cpumask of
        to-be-flushed cpus as argument, instead of that minus self, and
        returns yet-to-be-flushed cpumask, instead of modifying the passed
        in parameter.  this interface change will ease dummy implementation
        of uv_flush_tlb_others() and makes uv tlb flush related stuff
        defined in tlb_uv proper.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      bdbcdd48
  7. 16 1月, 2009 1 次提交
  8. 12 1月, 2009 1 次提交
    • R
      x86: change flush_tlb_others to take a const struct cpumask · 4595f962
      Rusty Russell 提交于
      Impact: reduce stack usage, use new cpumask API.
      
      This is made a little more tricky by uv_flush_tlb_others which
      actually alters its argument, for an IPI to be sent to the remaining
      cpus in the mask.
      
      I solve this by allocating a cpumask_var_t for this case and falling back
      to IPI should this fail.
      
      To eliminate temporaries in the caller, all flush_tlb_others implementations
      now do the this-cpu-elimination step themselves.
      
      Note also the curious "cpus_or(f->flush_cpumask, cpumask, f->flush_cpumask)"
      which has been there since pre-git and yet f->flush_cpumask is always zero
      at this point.
      Signed-off-by: NRusty Russell <rusty@rustcorp.com.au>
      Signed-off-by: NMike Travis <travis@sgi.com>
      4595f962
  9. 03 1月, 2009 1 次提交
    • C
      x86, UV: remove erroneous BAU initialization · 46814dde
      Cliff Wickman 提交于
      Impact: fix crash on x86/UV
      
      UV is the SGI "UltraViolet" machine, which is x86_64 based.
      BAU is the "Broadcast Assist Unit", used for TLB shootdown in UV.
      
      This patch removes the allocation and initialization of an unused table.
      
      This table is left over from a development test mode.  It is unused in
      the present code.
      
      And it was incorrectly initialized: 8 entries allocated but 17 initialized,
      causing slab corruption.
      
      This patch should go into 2.6.27 and 2.6.28 as well as the current tree.
      
      Diffed against 2.6.28 (linux-next, 12/30/08)
      Signed-off-by: NCliff Wickman <cpw@sgi.com>
      Cc: <stable@kernel.org>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      46814dde
  10. 11 11月, 2008 1 次提交
  11. 22 10月, 2008 1 次提交
  12. 20 8月, 2008 1 次提交
  13. 08 7月, 2008 7 次提交
    • C
      x86, SGI UV: uv_ptc_proc_write fix · e7eb8726
      Cliff Wickman 提交于
      Someone could write 0 bytes to /proc/sgi_uv/ptc_statistics,
      causing
        optstr[count - 1] = '\0';
      to write to who-knows-where.
      
      (Andi Kleen noticed this need from a patch I sent for
       similar code in the ia64 world (sn2_ptc_proc_write()).)
      
      (count less than zero is not possible here, as count is unsigned)
      Signed-off-by: NCliff Wickman <cpw@sgi.com>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      e7eb8726
    • C
      x86, SGI UV: TLB shootdown using broadcast assist unit, v6 · cef53278
      Cliff Wickman 提交于
      v6: 6/19 close the security hole in uv_ptc_proc_write())
      
        > Found a potential security hole while doing that:
        > static ssize_t uv_ptc_proc_write(struct file *file, const char __user *user,
        >                              size_t count, loff_t *data)
        >     if (copy_from_user(optstr, user, count))
        >             return -EFAULT;
        >
        > is count guaranteed to never be larger than 64?
      
      is fixed below.
      
      It adds tlb_uv.o to the Makefile.
      Signed-off-by: NCliff Wickman <cpw@sgi.com>
      Cc: mingo@elte.hu
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      cef53278
    • I
      SGI UV: TLB shootdown using broadcast assist unit, fix · d400524a
      Ingo Molnar 提交于
      fix:
      
      arch/x86/kernel/tlb_uv.c: In function ‘uv_table_bases_init':
      arch/x86/kernel/tlb_uv.c:612: error: ‘bau_tabsp' undeclared (first use in this function)
      arch/x86/kernel/tlb_uv.c:612: error: (Each undeclared identifier is reported only once
      arch/x86/kernel/tlb_uv.c:612: error: for each function it appears in.)
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      d400524a
    • I
      SGI UV: clean up arch/x86/kernel/tlb_uv.c · b4c286e6
      Ingo Molnar 提交于
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      b4c286e6
    • I
      SGI UV: TLB shootdown using broadcast assist unit · dc163a41
      Ingo Molnar 提交于
      TLB shootdown for SGI UV.
      
      v5: 6/12 corrections/improvements per Ingo's second review
      Signed-off-by: NCliff Wickman <cpw@sgi.com>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      dc163a41
    • C
      SGI UV: TLB shootdown using broadcast assist unit, cleanups · b194b120
      Cliff Wickman 提交于
      TLB shootdown for SGI UV.
      
      v1: 6/2 original
      v2: 6/3 corrections/improvements per Ingo's review
      v3: 6/4 split atomic operations off to a separate patch (Jeremy's review)
      v4: 6/12 include <mach_apic.h> rather than <asm/mach-bigsmp/mach_apic.h>
               (fixes a !SMP build problem that Ingo found)
               fix the index on uv_table_bases[blade]
      Signed-off-by: NCliff Wickman <cpw@sgi.com>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      b194b120
    • C
      x86, SGI UV: TLB shootdown using broadcast assist unit · 1812924b
      Cliff Wickman 提交于
      TLB shootdown for SGI UV.
      
      Depends on patch (in tip/x86/irq):
         x86-update-macros-used-by-uv-platform.patch   Jack Steiner May 29
      
      This patch provides the ability to flush TLB's in cpu's that are not on
      the local node.  The hardware mechanism for distributing the flush
      messages is the UV's "broadcast assist unit".
      
      The hook to intercept TLB shootdown requests is a 2-line change to
      native_flush_tlb_others() (arch/x86/kernel/tlb_64.c).
      
      This code has been tested on a hardware simulator. The real hardware
      is not yet available.
      
      The shootdown statistics are provided through /proc/sgi_uv/ptc_statistics.
      The use of /sys was considered, but would have required the use of
      many /sys files.  The debugfs was also considered, but these statistics
      should be available on an ongoing basis, not just for debugging.
      
      Issues to be fixed later:
      - The IRQ for the messaging interrupt is currently hardcoded as 200
        (see UV_BAU_MESSAGE).  It should be dynamically assigned in the future.
      - The use of appropriate udelay()'s is untested, as they are a problem
        in the simulator.
      Signed-off-by: NCliff Wickman <cpw@sgi.com>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      1812924b