Skip to content

R
raspberrypi-kernel

openeuler / raspberrypi-kernel

通知 13
Star 1
Fork 0
R
raspberrypi-kernel
切换分支/标签
  1. 12 6月, 2012 2 次提交
  3. 11 6月, 2012 3 次提交
  5. 09 6月, 2012 9 次提交
  7. 08 6月, 2012 3 次提交
  9. 07 6月, 2012 4 次提交
  11. 06 6月, 2012 5 次提交
  13. 05 6月, 2012 9 次提交
  15. 04 6月, 2012 4 次提交
    • J
      can: cc770: Fix likely misuse of | for & · dc605dbd
      由 Joe Perches 提交于 
      Using | with a constant is always true.
Likely this should have be &.
Signed-off-by: NJoe Perches <joe@perches.com>
Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      dc605dbd
    • A
      can: c_can: fix race condition in c_can_open() · f461f27a
      由 AnilKumar Ch 提交于 
      Fix the issue of C_CAN interrupts getting disabled forever when canconfig
utility is used multiple times. According to NAPI usage we disable all
the hardware interrupts in ISR and re-enable them in poll(). Current
implementation calls napi_enable() after hardware interrupts are enabled.
If we get any interrupts between these two steps then we do not process
those interrupts because napi is not enabled. Mostly these interrupts
come because of STATUS is not 0x7 or ERROR interrupts. If napi_enable()
happens before HW interrupts enabled then c_can_poll() function will be
called eventual re-enabling.

This patch moves the napi_enable() call before interrupts enabled.

Cc: stable@kernel.org # 2.6.39+
Signed-off-by: NAnilKumar Ch <anilkumar@ti.com>
Acked-by: NWolfgang Grandegger <wg@grandegger.com>
Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      f461f27a
    • A
      can: c_can: fix an interrupt thrash issue with c_can driver · 148c87c8
      由 AnilKumar Ch 提交于 
      This patch fixes an interrupt thrash issue with c_can driver.

In c_can_isr() function interrupts are disabled and enabled only in
c_can_poll() function. c_can_isr() & c_can_poll() both read the
irqstatus flag. However, irqstatus is always read as 0 in c_can_poll()
because all C_CAN interrupts are disabled in c_can_isr(). This causes
all interrupts to be re-enabled in c_can_poll() which in turn causes
another interrupt since the event is not really handled. This keeps
happening causing a flood of interrupts.

To fix this, read the irqstatus register in isr and use the same cached
value in the poll function.

Cc: stable@kernel.org # 2.6.39+
Signed-off-by: NAnilKumar Ch <anilkumar@ti.com>
Acked-by: NWolfgang Grandegger <wg@grandegger.com>
Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      148c87c8
    • A
      can: c_can: fix "BUG! echo_skb is occupied!" during transmit · 617cacce
      由 AnilKumar Ch 提交于 
      This patch fixes an issue with transmit routine, which causes
"can_put_echo_skb: BUG! echo_skb is occupied!" message when
using "cansequence -p" on D_CAN controller.

In c_can driver, while transmitting packets tx_echo flag holds
the no of can frames put for transmission into the hardware.

As the comment above c_can_do_tx() indicates, if we find any packet
which is not transmitted then we should stop looking for more.
In the current implementation this is not taken care of causing the
said message.

Also, fix the condition used to find if the packet is transmitted
or not. Current code skips the first tx message object and ends up
checking one extra invalid object.

While at it, fix the comment on top of c_can_do_tx() to use the
terminology "packet" instead of "package" since it is more
standard.

Cc: stable@kernel.org # 2.6.39+
Signed-off-by: NAnilKumar Ch <anilkumar@ti.com>
Acked-by: NWolfgang Grandegger <wg@grandegger.com>
Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      617cacce
  17. 03 6月, 2012 1 次提交