1. 03 10月, 2012 2 次提交
  2. 02 10月, 2012 2 次提交
  3. 14 8月, 2012 1 次提交
  4. 11 1月, 2012 1 次提交
  5. 31 12月, 2011 3 次提交
  6. 08 11月, 2011 1 次提交
  7. 04 9月, 2011 1 次提交
  8. 20 5月, 2011 1 次提交
  9. 19 4月, 2011 2 次提交
  10. 21 10月, 2010 1 次提交
    • M
      V4L/DVB: tda18271: Add some hint about what tda18217 reg ID returned · bfc3d57f
      Mauro Carvalho Chehab 提交于
      Instead of doing:
      
      [   82.581639] tda18271 4-0060: creating new instance
      [   82.588411] Unknown device detected @ 4-0060, device not supported.
      [   82.594695] tda18271_attach: [4-0060|M] error -22 on line 1272
      [   82.600530] tda18271 4-0060: destroying instance
      
      Print:
      [  468.740392] Unknown device (0) detected @ 4-0060, device not supported.
      
      for the error message, to help detecting what's going wrong with the
      device.
      
      This helps to detect when the driver is using the wrong I2C bus (or have
      the i2g gate switch pointing to the wrong place), on devices like cx231xx
      that just return 0 on reads to a non-existent i2c device.
      Reviewed-by: NMichael Krufky <mkrufky@kernellabs.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      bfc3d57f
  11. 03 8月, 2010 1 次提交
    • M
      V4L/DVB: tda18271: fix error detection during initialization of first instance · fab9bfbe
      Michael Krufky 提交于
      Fix error detection of failures during initialization of first instance:
      Dont pass a function into the tda_fail macro. Instead, save the function
      return value and pass that into the tda_fail macro.
      
      This prevents the function from being called twice in cases of failure,
      for example:
      
      [19026.074070] tuner 4-0060: chip found @ 0xc0 (device #0)
      [19026.087755] tda18271 4-0060: creating new instance
      [19026.089965] Unknown device detected @ 4-0060, device not supported.
      [19026.092233] Unknown device detected @ 4-0060, device not supported.
      [19026.092241] tda18271_attach: [4-0060|M] error -22 on line 1275
      [19026.092327] tda18271 4-0060: destroying instance
      Signed-off-by: NMichael Krufky <mkrufky@kernellabs.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      fab9bfbe
  12. 06 12月, 2009 10 次提交
  13. 07 11月, 2009 2 次提交
    • S
      V4L/DVB (13109): tda18271: fix signedness issue in tda18271_rf_tracking_filters_init · a57c1dcb
      Seth Barry 提交于
      While having tda18271 module set with debug=17 (cal & info prints) and
      cal=0 (delay calibration process until first use) - I discovered that
      during the calibration process, if the frequency test for 69750000
      returned a bcal of 0 (see tda18721-fe.c in tda18271_powerscan func) that
      the tuner wouldn't be able to pickup any of the frequencies in the range
      (all the other frequencies bands returned bcal=1).  I spent some time
      going over the code and the NXP's tda18271 spec (ver.4 of it i think) and
      adding a lot of debug prints and walking/stepping through the calibration
      process.  I found that when the powerscan fails to find a frequency, the
      rf calibration is not run and the default value is supposed to be used in
      its place (pulled from the RF_CAL_map table) - but something was getting
      goofed up there.
      
      Now, my c coding skills are very rusty, but i think root of the problem is
      a signedness issue with the math operation for calculating the rf_a1 and
      rf_a2 values in tda18271_rf_tracking_filters_init func, which results in
      values like 20648 for rf_a1 (when it should probably have a value like 0,
      or so slightly negative that it should be zero - this bad value for rf_a1
      would in turn makes the approx calc within
      tda18271c2_rf_tracking_filters_correction go out of whack).  The simplest
      solution i found was to explicitly convert the signedness of the
      denominator to avoid the implicit conversion.  The values placed into the
      u32 rf_freq array should never exceed about 900mhz, so i think the s32 max
      value shouldn't be an issue in this case.
      
      I've tested it out a little, and even when i get a bcal=0 with the
      modified code, the default calibration value gets used, rf_a1 is zero, and
      the tuner seems to lock on the stream and mythtv seems to play it fine.
      Signed-off-by: NSeth Barry <seth@cyberseth.com>
      Signed-off-by: NMichael Krufky <mkrufky@kernellabs.com>
      CC: stable@kernel.org
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      a57c1dcb
    • M
      V4L/DVB (13107): tda18271: fix overflow in FM radio frequency calculation · 4d831787
      Michael Krufky 提交于
      Multiplication by 62500 causes an overflow in the 32 bit freq variable,
      which is later divided by 1000 when using FM radio.
      
      This patch prevents the overflow by scaling the frequency value correctly
      upfront.  Thanks to Henk Vergonet for spotting the problem and providing
      a preliminary patch, which this changeset was based upon.
      
      Cc: Henk Vergonet <Henk.Vergonet@gmail.com>
      Signed-off-by: NMichael Krufky <mkrufky@kernellabs.com>
      CC: stable@kernel.org
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      4d831787
  14. 19 9月, 2009 9 次提交
  15. 12 9月, 2009 1 次提交
  16. 30 3月, 2009 1 次提交
  17. 12 10月, 2008 1 次提交