1. 30 3月, 2010 2 次提交
    • L
      ext3: fix broken handling of EXT3_STATE_NEW · de329820
      Linus Torvalds 提交于
      In commit 9df93939 ("ext3: Use bitops to read/modify
      EXT3_I(inode)->i_state") ext3 changed its internal 'i_state' variable to
      use bitops for its state handling.  However, unline the same ext4
      change, it didn't actually change the name of the field when it changed
      the semantics of it.
      
      As a result, an old use of 'i_state' remained in fs/ext3/ialloc.c that
      initialized the field to EXT3_STATE_NEW.  And that does not work
      _at_all_ when we're now working with individually named bits rather than
      values that get masked.  So the code tried to mark the state to be new,
      but in actual fact set the field to EXT3_STATE_JDATA.  Which makes no
      sense at all, and screws up all the code that checks whether the inode
      was newly allocated.
      
      In particular, it made the xattr code unhappy, and caused various random
      behavior, like apparently
      
      	https://bugzilla.redhat.com/show_bug.cgi?id=577911
      
      So fix the initialization, and rename the field to match ext4 so that we
      don't have this happen again.
      
      Cc: James Morris <jmorris@namei.org>
      Cc: Stephen Smalley <sds@tycho.nsa.gov>
      Cc: Daniel J Walsh <dwalsh@redhat.com>
      Cc: Eric Paris <eparis@redhat.com>
      Cc: Jan Kara <jack@suse.cz>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      de329820
    • D
      SLOW_WORK: CONFIG_SLOW_WORK_PROC should be CONFIG_SLOW_WORK_DEBUG · a53f4f9e
      David Howells 提交于
      CONFIG_SLOW_WORK_PROC was changed to CONFIG_SLOW_WORK_DEBUG, but not in all
      instances.  Change the remaining instances.  This makes the debugfs file
      display the time mark and the owner's description again.
      Signed-off-by: NDavid Howells <dhowells@redhat.com>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      a53f4f9e
  2. 27 3月, 2010 1 次提交
  3. 25 3月, 2010 6 次提交
  4. 24 3月, 2010 4 次提交
  5. 23 3月, 2010 1 次提交
  6. 22 3月, 2010 2 次提交
  7. 21 3月, 2010 3 次提交
  8. 20 3月, 2010 1 次提交
  9. 19 3月, 2010 7 次提交
  10. 18 3月, 2010 2 次提交
    • G
      of: Fix comparison of "compatible" properties · 1976152f
      Grant Likely 提交于
      Commit 7c7b60cb
      "of: put default string compare and #a/s-cell values into common header"
      
      Breaks various things on powerpc due to using strncasecmp instead of
      strcasecmp for comparing against "compatible" strings.
      
      This causes things like the 4xx PCI code to fail miserably due to the
      partial matches in code like this:
      
             for_each_compatible_node(np, NULL, "ibm,plb-pcix")
                     ppc4xx_probe_pcix_bridge(np);
             for_each_compatible_node(np, NULL, "ibm,plb-pci")
                     ppc4xx_probe_pci_bridge(np);
      
      It's not quite right to do partial name match. Entries in a compatible
      list are meant to be matched whole. If a device is compatible with both
      "foo" and "foo1", then the device should have both strings in its
      "compatible" property.
      
      This patch reverts powerpc and microblaze us to use strcasecmp.
      Signed-off-by: NBenjamin Herrenschmidt <benh@kernel.crashing.org>
            (for patch description)
      Signed-off-by: NGrant Likely <grant.likely@secretlab.ca>
      Acked-by: NDavid S. Miller <davem@davemloft.net>
      Acked-by: NMichal Simek <michal.simek@petalogix.com>
      1976152f
    • H
      memory hotplug: allow setting of phys_device · bc32df00
      Heiko Carstens 提交于
      /sys/devices/system/memory/memoryX/phys_device is supposed to contain the
      number of the physical device that the corresponding piece of memory
      belongs to.
      
      In case a physical device should be replaced or taken offline for whatever
      reason it is necessary to set all corresponding memory pieces offline.
      The current implementation always sets phys_device to '0' and there is no
      way or hook to change that.  Seems like there was a plan to implement that
      but it wasn't finished for whatever reason.
      
      So add a weak function which architectures can override to actually set
      the phys_device from within add_memory_block().
      Signed-off-by: NHeiko Carstens <heiko.carstens@de.ibm.com>
      Cc: Dave Hansen <haveblue@us.ibm.com>
      Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
      Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      bc32df00
  11. 17 3月, 2010 4 次提交
  12. 16 3月, 2010 3 次提交
    • L
      rcu: Fix tracepoints & lockdep false positive · 7f5b7742
      Lai Jiangshan 提交于
      tracepoint.h uses rcu_dereference(), which triggers this warning:
      
      [    0.701161] ===================================================
      [    0.702211] [ INFO: suspicious rcu_dereference_check() usage. ]
      [    0.702716] ---------------------------------------------------
      [    0.703203] include/trace/events/workqueue.h:68 invoked rcu_dereference_check() without protection!
      [    0.703971] [ 0.703990] other info that might help us debug this:
      [    0.703993]
      [    0.705590]
      [    0.705604] rcu_scheduler_active = 1, debug_locks = 0
      [    0.706712] 1 lock held by swapper/1:
      [    0.707229]  #0:  (cpu_add_remove_lock){+.+.+.}, at: [<c0142f54>] cpu_maps_update_begin+0x14/0x20
      [    0.710097]
      [    0.710106] stack backtrace:
      [    0.712602] Pid: 1, comm: swapper Not tainted 2.6.34-rc1-tip-01613-g72662bb #168
      [    0.713231] Call Trace:
      [    0.713997]  [<c017174d>] lockdep_rcu_dereference+0x9d/0xb0
      [    0.714746]  [<c015a117>] create_workqueue_thread+0x107/0x110
      [    0.715353]  [<c015aee0>] ? worker_thread+0x0/0x340
      [    0.715845]  [<c015a8e8>] __create_workqueue_key+0x138/0x240
      [    0.716427]  [<c0142f92>] ? cpu_maps_update_done+0x12/0x20
      [    0.717012]  [<c086b12f>] init_workqueues+0x6f/0x80
      [    0.717530]  [<c08576d2>] kernel_init+0x102/0x1f0
      [    0.717570]  [<c08575d0>] ? kernel_init+0x0/0x1f0
      [    0.718944]  [<c01030fa>] kernel_thread_helper+0x6/0x10
      Signed-off-by: NLai Jiangshan <laijs@cn.fujitsu.com>
      Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
      Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
      Cc: Steven Rostedt <rostedt@goodmis.org>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      LKML-Reference: <4B9F48AD.4000404@cn.fujitsu.com>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      7f5b7742
    • P
      rcu: Make rcu_read_lock_bh_held() allow for disabled BH · e3818b8d
      Paul E. McKenney 提交于
      Disabling BH can stand in for rcu_read_lock_bh(), and this patch
      updates rcu_read_lock_bh_held() to allow for this.  In order to
      avoid include-file hell, this function is moved out of line to
      kernel/rcupdate.c.
      
      This fixes a false positive RCU warning.
      Reported-by: NArnd Bergmann <arnd@arndb.de>
      Reported-by: NEric Dumazet <eric.dumazet@gmail.com>
      Signed-off-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Acked-by: NLai Jiangshan <laijs@cn.fujitsu.com>
      Cc: dipankar@in.ibm.com
      Cc: mathieu.desnoyers@polymtl.ca
      Cc: josh@joshtriplett.org
      Cc: dvhltc@us.ibm.com
      Cc: niv@us.ibm.com
      Cc: peterz@infradead.org
      Cc: rostedt@goodmis.org
      Cc: Valdis.Kletnieks@vt.edu
      Cc: dhowells@redhat.com
      LKML-Reference: <20100316000343.GA25857@linux.vnet.ibm.com>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      e3818b8d
    • N
      Remove GENHD_FL_DRIVERFS · 97fedbbe
      NeilBrown 提交于
      This flag is not used, so best discarded.
      Signed-off-by: NNeilBrown <neilb@suse.de>
      --
      Hi Jens,
       I came across this recently - these are the only two occurances
       of "GENHD_FL_DRIVERFS" in the kernel, so it cannot be needed.
      NeilBrown
      Signed-off-by: NJens Axboe <jens.axboe@oracle.com>
      97fedbbe
  13. 15 3月, 2010 4 次提交