1. 06 7月, 2006 8 次提交
    • J
      [netdrvr] Use dev_printk() when ethernet interface isn't available · 2e8a538d
      Jeff Garzik 提交于
      For messages prior to register_netdev(), prefer dev_printk() because
      that prints out both our driver name and our [PCI | whatever] bus id.
      
      Updates: 8139{cp,too}, b44, bnx2, cassini, {eepro,epic}100, fealnx,
      	 hamachi, ne2k-pci, ns83820, pci-skeleton, r8169.
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      2e8a538d
    • J
      [netdrvr] via-velocity: remove io_size struct member, it is invariant · cabb7667
      Jeff Garzik 提交于
      Replace io_size struct members with VELOCITY_IO_SIZE constant.
      
      Also, constify chip_info_table[].
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      cabb7667
    • J
      [netdrvr] via-velocity: misc. cleanups · e54f4893
      Jeff Garzik 提交于
      - const-ify pci_device_id table
      - clean up pci_device_id table with PCI_DEVICE()
      - don't store internal pointer in pci_device_id table,
        use pci_device_id::driver_data as an integer index
      - use dev_printk() for messages where eth%d prefix is unavailable
      - formatting fixes
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      e54f4893
    • J
      [netdrvr] minor cleanups in Becker-derived drivers · 46009c8b
      Jeff Garzik 提交于
      - fealnx: convert #define to enum
      - fealnx, sundance: mark chip info table __devinitdata
      - fealnx: use dev_printk() during probe
      - fealnx: formatting cleanups
      - starfire: remove obsolete comment
      - sundance, via-rhine: add some whitespace where useful, in tables
      - sundance: prefer "{ }" table terminator
      - via-rhine: mark PCI probe table const
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      46009c8b
    • J
      8ab6f3f7
    • J
      [netdrvr] Remove Becker-template 'io_size' member, when invariant · c3d8e682
      Jeff Garzik 提交于
      Becker-derived drivers often have the 'io_size' member in their chip
      info struct, indicating the minimum required size of the I/O resource
      (usually a PCI BAR).  For many situations, this number is either
      constant or irrelevant (due to pci_iomap convenience behavior).
      
      This change removes the io_size invariant member, and replaces it with a
      compile-time constant.
      
      Drivers updated: fealnx, gt96100eth, winbond-840, yellowfin
      
      Additionally,
      - gt96100eth: unused 'drv_flags' removed from gt96100eth
      - winbond-840: unused struct match_info removed
      - winbond-840: mark pci_id_tbl[] const, __devinitdata
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      c3d8e682
    • J
      [netdrvr] Remove Linux-specific changelogs from several Becker template drivers · 03a8c661
      Jeff Garzik 提交于
      When in-kernel net drivers branched from Donald Becker's vanilla driver
      set, in the days before BitKeeper and git, a driver changelog was
      maintained in the driver source code.  These days, the kernel's
      changelog is far superior and much more accurate, so the in-driver
      changelogs are removed.
      
      Another relic of the Becker/kernel split was version numbering, using
      "foo-LKx.y.z" notation, resulting in weird version numbers like
      "1.17b-LK1.1.9".  These drivers are for older hardware, and see few
      changes these days, so the version numbers were all bumped to something
      more simple.
      
      Finally, in xircom_tulip_cb specifically, an additional cleanup removes
      the always-enabled CARDBUS cpp macro.
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      03a8c661
    • J
      [netdrvr] epic100: minor cleanups · 36e1e847
      Jeff Garzik 提交于
      - Remove in-source changelog, it's in the global kernel history.
      - convert silly and useless version to useful one
      - replace invariant pci_id_tbl[]::io_size uses with EPIC_TOTAL_SIZE
      - remove now-unused io_size member from pci_id_tbl[]
      - current kernel style prefers dev_printk() for the rare ethernet driver
        messages that cannot print an 'eth%d' prefix.
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      36e1e847
  2. 05 7月, 2006 1 次提交
    • Z
      [PATCH] mthca: initialize send and receive queue locks separately · a46f9484
      Zach Brown 提交于
      mthca: initialize send and receive queue locks separately
      
      lockdep identifies a lock by the call site of its initialization.  By
      initializing the send and receive queue locks in mthca_wq_init() we confuse
      lockdep.  It warns that that the ordered acquiry of both locks in
      mthca_modify_qp() is recursive acquiry of one lock:
      
        =============================================
        [ INFO: possible recursive locking detected ]
        ---------------------------------------------
        modprobe/1192 is trying to acquire lock:
         (&wq->lock){....}, at: [<f892b4db>] mthca_modify_qp+0x60/0xa7b [ib_mthca]
        but task is already holding lock:
         (&wq->lock){....}, at: [<f892b4ce>] mthca_modify_qp+0x53/0xa7b [ib_mthca]
      
      Initializing the locks separately in mthca_alloc_qp_common() stops the
      warning and will let lockdep enforce proper ordering on paths that acquire
      both locks.
      Signed-off-by: NZach Brown <zach.brown@oracle.com>
      Cc: Roland Dreier <rolandd@cisco.com>
      Cc: Arjan van de Ven <arjan@linux.intel.com>
      Cc: Ingo Molnar <mingo@elte.hu>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      a46f9484
  3. 04 7月, 2006 31 次提交