1. 23 5月, 2005 1 次提交
    • B
      [PATCH] ppc64: Fix booting on latest G5 models · 1263cc67
      Benjamin Herrenschmidt 提交于
      The latest speedbumped Apple G5 models have a "bug" in the Open Firmware
      device tree that lacks the proper interrupt routing information for the
      northbridge i2c controller.  Apple's driver silently falls back into a
      sub-optimal "polled" mode (heh, maybe they didn't even notice the bug
      because of that :), our driver didn't properly check and crashes :(
      
      This patch fixes our driver to not crash, and adds code to the
      prom_init() OF trampoline code that detects the "bug" and adds the
      missing information back for this chipset revision.  This fixes booting
      and thermal control on these models.
      Signed-off-by: NBenjamin Herrenschmidt <benh@kernel.crashing.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      1263cc67
  2. 26 4月, 2005 1 次提交
  3. 25 4月, 2005 1 次提交
  4. 19 4月, 2005 2 次提交
    • J
      [PATCH] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers · 1d66c64c
      Jean Delvare 提交于
      The it87 and via686a hardware monitoring drivers each create a sysfs
      file named "alarms" in R/W mode, while they should really create it in
      read-only mode. Since we don't provide a store function for these files,
      write attempts to these files will do something undefined (I guess) and
      bad (I am sure). My own try resulted in a locked terminal (where I
      attempted the write) and a 100% CPU load until next reboot.
      
      As a side note, wouldn't it make sense to check, when creating sysfs
      files, that readable files have a non-NULL show method, and writable
      files have a non-NULL store method? I know drivers are not supposed to
      do stupid things, but there is already a BUG_ON for several conditions
      in sysfs_create_file, so maybe we could add two more?
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      1d66c64c
    • J
      [PATCH] I2C: via686a cleanups · 86b5ac87
      Jean Delvare 提交于
      Here comes a small cleanup patch for the via686a driver. I noticed the
      following two non-fatal problems:
      
      1* The device parent is explicitely set, but it's not needed because the
      i2c core will do as the client is registered.
      
      2* snprintf is used where strlcpy would suffice.
      
      Fixing them brings the via686a driver in line with what other similar
      drivers do.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      86b5ac87
  5. 17 4月, 2005 2 次提交