1. 24 6月, 2005 27 次提交
  2. 23 6月, 2005 13 次提交
    • M
      e1000: fix spinlock bug · b2b3d824
      Mitch Williams 提交于
      This patch fixes an obvious and nasty bug where we could exit the transmit
      routine while holding tx_lock.
      Signed-off-by: NMitch Williams <mitch.a.williams@intel.com>
      b2b3d824
    • L
    • L
    • G
      [PATCH] driver core: Fix up the device_attach() error handling in bus_add_device() · d377e85b
      Greg Kroah-Hartman 提交于
      Don't error out if something "bad" happens when trying to bind a driver to a
      device.  We want the sysfs attributes to be present for later when we try to
      tear down the device.
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      d377e85b
    • S
      [PATCH] USB: fix hid core to return proper error code from probe · 479f6ea8
      Stelian Pop 提交于
      Drivers need to return -ENODEV when they can't bind to a device.
      Anything else stops the "bind a device to a driver" search.
      
      From: Stelian Pop <stelian@popies.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      479f6ea8
    • N
      [LTPC]: Replace schedule_timeout() with ssleep()/msleep() · 2c4ee8f9
      Nishanth Aravamudan 提交于
      Use ssleep() / msleep() [as appropriate]
      instead of schedule_timeout() to guarantee the task delays as expected.
      Signed-off-by: NNishanth Aravamudan <nacc@us.ibm.com>
      Acked-by: NArnaldo Carvalho de Melo <acme@conectiva.com.br>
      Signed-off-by: NMaximilian Attems <janitor@sternwelten.at>
      Signed-off-by: NDomen Puncer <domen@coderock.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2c4ee8f9
    • S
      [X25]: Fast select with no restriction on response · ebc3f64b
      Shaun Pereira 提交于
      This patch is a follow up to patch 1 regarding "Selective Sub Address
      matching with call user data".  It allows use of the Fast-Select-Acceptance
      optional user facility for X.25.
      
      This patch just implements fast select with no restriction on response
      (NRR).  What this means (according to ITU-T Recomendation 10/96 section
      6.16) is that if in an incoming call packet, the relevant facility bits are
      set for fast-select-NRR, then the called DTE can issue a direct response to
      the incoming packet using a call-accepted packet that contains
      call-user-data.  This patch allows such a response.  
      
      The called DTE can also respond with a clear-request packet that contains
      call-user-data.  However, this feature is currently not implemented by the
      patch.
      
      How is Fast Select Acceptance used?
      By default, the system does not allow fast select acceptance (as before).
      To enable a response to fast select acceptance,  
      After a listen socket in created and bound as follows
      	socket(AF_X25, SOCK_SEQPACKET, 0);
      	bind(call_soc, (struct sockaddr *)&locl_addr, sizeof(locl_addr));
      but before a listen system call is made, the following ioctl should be used.
      	ioctl(call_soc,SIOCX25CALLACCPTAPPRV);
      Now the listen system call can be made
      	listen(call_soc, 4);
      After this, an incoming-call packet will be accepted, but no call-accepted 
      packet will be sent back until the following system call is made on the socket
      that accepts the call
      	ioctl(vc_soc,SIOCX25SENDCALLACCPT);
      The network (or cisco xot router used for testing here) will allow the 
      application server's call-user-data in the call-accepted packet, 
      provided the call-request was made with Fast-select NRR.
      Signed-off-by: NShaun Pereira <spereira@tusc.com.au>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      ebc3f64b
    • S
      [X25]: Selective sub-address matching with call user data. · cb65d506
      Shaun Pereira 提交于
      From: Shaun Pereira <spereira@tusc.com.au>
      
      This is the first (independent of the second) patch of two that I am
      working on with x25 on linux (tested with xot on a cisco router).  Details
      are as follows.
      
      Current state of module:
      
      A server using the current implementation (2.6.11.7) of the x25 module will
      accept a call request/ incoming call packet at the listening x.25 address,
      from all callers to that address, as long as NO call user data is present
      in the packet header.
      
      If the server needs to choose to accept a particular call request/ incoming
      call packet arriving at its listening x25 address, then the kernel has to
      allow a match of call user data present in the call request packet with its
      own.  This is required when multiple servers listen at the same x25 address
      and device interface.  The kernel currently matches ALL call user data, if
      present.
      
      Current Changes:
      
      This patch is a follow up to the patch submitted previously by Andrew
      Hendry, and allows the user to selectively control the number of octets of
      call user data in the call request packet, that the kernel will match.  By
      default no call user data is matched, even if call user data is present. 
      To allow call user data matching, a cudmatchlength > 0 has to be passed
      into the kernel after which the passed number of octets will be matched. 
      Otherwise the kernel behavior is exactly as the original implementation.
      
      This patch also ensures that as is normally the case, no call user data
      will be present in the Call accepted / call connected packet sent back to
      the caller 
      
      Future Changes on next patch:
      
      There are cases however when call user data may be present in the call
      accepted packet.  According to the X.25 recommendation (ITU-T 10/96)
      section 5.2.3.2 call user data may be present in the call accepted packet
      provided the fast select facility is used.  My next patch will include this
      fast select utility and the ability to send up to 128 octets call user data
      in the call accepted packet provided the fast select facility is used.  I
      am currently testing this, again with xot on linux and cisco.  
      Signed-off-by: NShaun Pereira <spereira@tusc.com.au>
      
      (With a fix from Alexey Dobriyan <adobriyan@gmail.com>)
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      cb65d506
    • J
      [EBTABLES]: vfree() checking cleanups · 68d31872
      James Lamanna 提交于
      From: jlamanna@gmail.com
      
      ebtables.c vfree() checking cleanups.
      
      Signed-off by: James Lamanna <jlamanna@gmail.com>
      Signed-off-by: NDomen Puncer <domen@coderock.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      68d31872
    • N
      [ATALK] aarp: replace schedule_timeout() with msleep() · 285b3afe
      Nishanth Aravamudan 提交于
      From: Nishanth Aravamudan <nacc@us.ibm.com>
      
      Use msleep() instead of schedule_timeout() to guarantee the task
      delays as expected. The current code is not wrong, but it does not account for
      early return due to signals, so I think msleep() should be appropriate.
      Signed-off-by: NNishanth Aravamudan <nacc@us.ibm.com>
      Signed-off-by: NDomen Puncer <domen@coderock.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      285b3afe
    • C
      [IPV4]: Fix route.c gcc4 warnings · 7abaa27c
      Chuck Short 提交于
      Signed-off by: Chuck Short <zulcss@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      7abaa27c
    • J
      [NETPOLL]: allow multiple netpoll_clients to register against one interface · fbeec2e1
      Jeff Moyer 提交于
      This patch provides support for registering multiple netpoll clients to the
      same network device.  Only one of these clients may register an rx_hook,
      however.  In practice, this restriction has not been problematic.  It is
      worth mentioning, though, that the current design can be easily extended to
      allow for the registration of multiple rx_hooks.
      
      The basic idea of the patch is that the rx_np pointer in the netpoll_info
      structure points to the struct netpoll that has rx_hook filled in.  Aside
      from this one case, there is no need for a pointer from the struct
      net_device to an individual struct netpoll.
      
      A lock is introduced to protect the setting and clearing of the np_rx
      pointer.  The pointer will only be cleared upon netpoll client module
      removal, and the lock should be uncontested.
      Signed-off-by: NJeff Moyer <jmoyer@redhat.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      fbeec2e1
    • J
      [NETPOLL]: Introduce a netpoll_info struct · 115c1d6e
      Jeff Moyer 提交于
      This patch introduces a netpoll_info structure, which the struct net_device
      will now point to instead of pointing to a struct netpoll.  The reason for
      this is two-fold: 1) fields such as the rx_flags, poll_owner, and poll_lock
      should be maintained per net_device, not per netpoll;  and 2) this is a first
      step in providing support for multiple netpoll clients to register against the
      same net_device.
      
      The struct netpoll is now pointed to by the netpoll_info structure.  As
      such, the previous behaviour of the code is preserved.
      Signed-off-by: NJeff Moyer <jmoyer@redhat.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      115c1d6e