1. 07 2月, 2006 2 次提交
  2. 27 1月, 2006 2 次提交
    • R
      [PATCH] S2io: Large Receive Offload (LRO) feature(v2) for Neterion (s2io)... · 7d3d0439
      Ravinandan Arakali 提交于
      [PATCH] S2io: Large Receive Offload (LRO) feature(v2) for Neterion (s2io) 10GbE Xframe PCI-X and PCI-E NICs
      
      Hi,
      Below is a patch for the Large Receive Offload feature.
      Please review and let us know your comments.
      
      LRO algorithm was described in an OLS 2005 presentation, located at
      ftp.s2io.com
      user: linuxdocs
      password: HALdocs
      
      The same ftp site has Programming Manual for Xframe-I ASIC.
      LRO feature is supported on Neterion Xframe-I, Xframe-II and
      Xframe-Express 10GbE NICs.
      
      Brief description:
      The Large Receive Offload(LRO) feature is a stateless offload
      that is complementary to TSO feature but on the receive path.
      The idea is to combine and collapse(upto 64K maximum) in the
      driver, in-sequence TCP packets belonging to the same session.
      It is mainly designed to improve 1500 mtu receive performance,
      since Jumbo frame performance is already close to 10GbE line
      rate. Some performance numbers are attached below.
      
      Implementation details:
      1. Handle packet chains from multiple sessions(current default
      MAX_LRO_SESSSIONS=32).
      2. Examine each packet for eligiblity to aggregate. A packet is
      considered eligible if it meets all the below criteria.
        a. It is a TCP/IP packet and L2 type is not LLC or SNAP.
        b. The packet has no checksum errors(L3 and L4).
        c. There are no IP options. The only TCP option supported is timestamps.
        d. Search and locate the LRO object corresponding to this
           socket and ensure packet is in TCP sequence.
        e. It's not a special packet(SYN, FIN, RST, URG, PSH etc. flags are not set).
        f. TCP payload is non-zero(It's not a pure ACK).
        g. It's not an IP-fragmented packet.
      3. If a packet is found eligible, the LRO object is updated with
         information such as next sequence number expected, current length
         of aggregated packet and so on. If not eligible or max packets
         reached, update IP and TCP headers of first packet in the chain
         and pass it up to stack.
      4. The frag_list in skb structure is used to chain packets into one
         large packet.
      
      Kernel changes required: None
      
      Performance results:
      Main focus of the initial testing was on 1500 mtu receiver, since this
      is a bottleneck not covered by the existing stateless offloads.
      
      There are couple disclaimers about the performance results below:
      1. Your mileage will vary!!!! We initially concentrated on couple pci-x
      2.0 platforms that are powerful enough to push 10 GbE NIC and do not
      have bottlenecks other than cpu%;  testing on other platforms is still
      in progress. On some lower end systems we are seeing lower gains.
      
      2. Current LRO implementation is still (for the most part) software based,
      and therefore performance potential of the feature is far from being realized.
      Full hw implementation of LRO is expected in the next version of Xframe ASIC.
      
      Performance delta(with MTU=1500) going from LRO disabled to enabled:
      IBM 2-way Xeon (x366) : 3.5 to 7.1 Gbps
      2-way Opteron : 4.5 to 6.1 Gbps
      Signed-off-by: NRavinandan Arakali <ravinandan.arakali@neterion.com>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      7d3d0439
    • A
      [PATCH] s2io: scatter-gather fix · efd51b5c
      Ananda Raju 提交于
      	There is a problem with fragmented skb in s2io driver version 2.0.9.4
      	available in 2.6.16-rc1 kernel. The adapter will fail to transmit if
      	any scatter-gather skb arrives.  This patch provides fix for the above
      	described problem.
      Signed-off-by: NAnanda Raju <ananda.raju@neterion.com>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      efd51b5c
  3. 17 1月, 2006 1 次提交
  4. 24 12月, 2005 1 次提交
    • A
      [PATCH] git-netdev-all: s2io warning fix · 26b7625c
      Andrew Morton 提交于
      drivers/net/s2io.c: In function `s2io_txdl_getskb':
      drivers/net/s2io.c:2023: warning: cast from pointer to integer of different size
      drivers/net/s2io.c: In function `s2io_open':
      drivers/net/s2io.c:3325: warning: long long unsigned int format, u64 arg (arg 3)
      drivers/net/s2io.c:3333: warning: long long unsigned int format, u64 arg (arg 3)
      drivers/net/s2io.c: In function `s2io_eeprom_test':
      drivers/net/s2io.c:4749: warning: long long unsigned int format, long unsigned int arg (arg 3)
      drivers/net/s2io.c:4749: warning: long long unsigned int format, u64 arg (arg 4)
      drivers/net/s2io.c:4768: warning: long long unsigned int format, long unsigned int arg (arg 3)
      drivers/net/s2io.c:4768: warning: long long unsigned int format, u64 arg (arg 4)
      
      I had to update this patch because more warnings have just appeared.
      
      You cannot print a u64 with %l or %ll.  You do not know what type the
      architecture is using.  It must be cast to a type which matches the printf
      control string - unsigned long long.
      
      The patch also fixes some overly-long strings.  Please try to keep the code
      looking neat in an 80-col window.
      
      Cc: Jeff Garzik <jgarzik@pobox.com>
      Cc: Ananda Raju <Ananda.Raju@neterion.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      26b7625c
  5. 16 12月, 2005 1 次提交
  6. 19 11月, 2005 1 次提交
  7. 09 11月, 2005 1 次提交
    • O
      [PATCH] changing CONFIG_LOCALVERSION rebuilds too much, for no good reason · 733482e4
      Olaf Hering 提交于
      This patch removes almost all inclusions of linux/version.h.  The 3
      #defines are unused in most of the touched files.
      
      A few drivers use the simple KERNEL_VERSION(a,b,c) macro, which is
      unfortunatly in linux/version.h.
      
      There are also lots of #ifdef for long obsolete kernels, this was not
      touched.  In a few places, the linux/version.h include was move to where
      the LINUX_VERSION_CODE was used.
      
      quilt vi `find * -type f -name "*.[ch]"|xargs grep -El '(UTS_RELEASE|LINUX_VERSION_CODE|KERNEL_VERSION|linux/version.h)'|grep -Ev '(/(boot|coda|drm)/|~$)'`
      
      search pattern:
      /UTS_RELEASE\|LINUX_VERSION_CODE\|KERNEL_VERSION\|linux\/\(utsname\|version\).h
      Signed-off-by: NOlaf Hering <olh@suse.de>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      733482e4
  8. 08 11月, 2005 1 次提交
  9. 06 11月, 2005 2 次提交
    • J
      [netdrvr s2io] warning fixes · 50eb8006
      Jeff Garzik 提交于
      From Andrew Morton.
      50eb8006
    • A
      [PATCH] S2io: Multi buffer mode support · da6971d8
      Ananda Raju 提交于
      Hi,
      This patch  provides dynamic two buffer-mode and 3 buffer-mode options.
      Previously 2 buffer-mode was compilation option. Now with this patch applied
      one can load driver in 2 buffer-mode with module-load parameter
      
      ie.
      #insmod s2io.ko rx_ring_mode=2
      
      This patch also provides 3 buffer-mode which provides header separation
      functionality. In 3 buffer-mode skb->data will have L2/L3/L4 headers and
      "skb_shinfo(skb)->frag_list->data" will have have L4 payload.
      one can load driver in 3 buffer-mode with same above module-load parameter
      
      ie.
      #insmod s2io.ko rx_ring_mode=3
      
      Please review the patch.
      Signed-off-by: NAnanda Raju <ananda.raju@neterion.com>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      da6971d8
  10. 30 10月, 2005 2 次提交
  11. 29 10月, 2005 1 次提交
  12. 19 10月, 2005 2 次提交
    • A
      [PATCH] s2io build fix · 92383340
      Andrew Morton 提交于
      Cc: Jeff Garzik <jgarzik@pobox.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      92383340
    • R
      [PATCH] S2io: Offline diagnostics fixes · ad4ebed0
      ravinandan.arakali@neterion.com 提交于
      This patch fixes the following bugs with offline diagnostics
      code(run with "ethtool -t").
      
      1. After running offline diagnostics, adapter would report
      corrupted packets on receive. This was because of adapter not
      being brought out of "RLDRAM test mode".
      2. Current EEPROM test works only for Xframe I. Since Xframe II
      uses different interface(SPI), support for this interface has
      been added. Also, since SPI supports write access to all areas
      of EEPROM, negative testing is done only for Xframe I.
      3. Return values from subfunctions of offline diagnostics have
      been corrected.
      4. In register test, expected value from rx_queue_cfg register
      is made to depend on adapter type.
      5. After the test, need to restore values at EEPROM offsets
      0x4F0 and 0x7F0. These locations were modified as part of test.
      6. Use macro SPECIAL_REG_WRITE for write access to mc_rldram_test_ctrl
      register. Also, couple of unnecessary writes to mc_rldram_test_ctrl
      have been removed.
      Signed-off-by: NRavinandan Arakali <ravinandan.arakali@neterion.com>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      ad4ebed0
  13. 04 10月, 2005 3 次提交
  14. 14 9月, 2005 1 次提交
    • A
      [PATCH] s2io warning fixes · 6b4d617d
      Andrew Morton 提交于
      drivers/net/s2io.c: In function `init_shared_mem':
      drivers/net/s2io.c:431: warning: cast from pointer to integer of different size
      drivers/net/s2io.c: In function `free_shared_mem':
      drivers/net/s2io.c:662: warning: cast from pointer to integer of different size
      
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jeff Garzik <jgarzik@pobox.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      6b4d617d
  15. 08 9月, 2005 1 次提交
  16. 07 9月, 2005 1 次提交
    • R
      [PATCH] S2io: Hardware and miscellaneous fixes · 776bd20f
      ravinandan.arakali@neterion.com 提交于
      Hi,
      This patch contains the following hardware related fixes and other
      miscellaneous bug fixes.
      
      1. Updated the definition of single and double-bit ECC errors
      2. Earlier we were allocating Transmit descriptors equal to
         MAX_SKB_FRAGS. This was causing a boundary condition failure.
         Need to allocate MAX_SKB_FRAGS+1 descriptors.
      3. On some platforms(like PPC), pci_alloc_consistent() can return
         a zero DMA address. Since the NIC cannot handle zero-addresses,
         a workaround has been provided. Basically, we don't use such
         that page. We reallocate.
      4. If list_info allocation failed during driver load, check for
         it during driver exit and return instead of trying to dereference
         NULL pointer.
      5. Increase the debug level of few non-critical debug messages.
      6. Reset the card on critical ECC double errors only in case of
         XframeI since XframeII can recover from such errors.
      7. Print copyright message on driver load.
      8. Bumped up the driver version no. to 2.0.8.1
      Signed-off-by: NRavinandan Arakali <ravinandan.arakali@neterion.com>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      776bd20f
  17. 06 9月, 2005 1 次提交
  18. 20 8月, 2005 1 次提交
  19. 11 8月, 2005 13 次提交
  20. 29 6月, 2005 1 次提交
    • D
      [NET]: Remove gratuitous use of skb->tail in network drivers. · 689be439
      David S. Miller 提交于
      Many drivers use skb->tail unnecessarily.
      
      In these situations, the code roughly looks like:
      
      	dev = dev_alloc_skb(...);
      
      	[optional] skb_reserve(skb, ...);
      
      	... skb->tail ...
      
      But even if the skb_reserve() happens, skb->data equals
      skb->tail.  So it doesn't make any sense to use anything
      other than skb->data in these cases.
      
      Another case was the s2io.c driver directly mucking with
      the skb->data and skb->tail pointers.  It really just wanted
      to do an skb_reserve(), so that's what the code was changed
      to do instead.
      
      Another reason I'm making this change as it allows some SKB
      cleanups I have planned simpler to merge.  In those cleanups,
      skb->head, skb->tail, and skb->end pointers are removed, and
      replaced with skb->head_room and skb->tail_room integers.
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      Acked-by: NJeff Garzik <jgarzik@pobox.com>
      689be439
  21. 27 6月, 2005 1 次提交