1. 09 8月, 2010 1 次提交
    • Y
      via82cxxx: fix typo for VT6415 PCIE PATA IDE Host Controller support. · 2a800b7b
      Yann Dirson 提交于
      Without this fix, init of the via82cxxx driver causes a oops with a
      stack resembling the one below, and the boot blocks between init of
      USB devices and launch of init (was easy to bisect by booting with
      init=/bin/sh).
      
       Pid: 279, comm: work_for_cpu Not tainted 2.6.34.1-00003-ga42ea77 #2
       Call Trace:
        [<ffffffff81045691>] ? warn_slowpath_common+0x76/0x8c
        [<ffffffff810456f9>] ? warn_slowpath_fmt+0x40/0x45
        [<ffffffff812eb5a1>] ? printk+0x40/0x47
        [<ffffffff8108e1fd>] ? enable_irq+0x3e/0x64
        [<ffffffffa0003900>] ? ide_probe_port+0x55c/0x589 [ide_core]
        [<ffffffffa0003f22>] ? ide_host_register+0x273/0x628 [ide_core]
        [<ffffffffa00083e3>] ? ide_pci_init_two+0x4da/0x5c5 [ide_core]
        [<ffffffff8106117e>] ? up+0xe/0x36
        [<ffffffff81045d7e>] ? release_console_sem+0x17e/0x1ae
        [<ffffffff812d945b>] ? klist_iter_exit+0x14/0x1e
        [<ffffffff8120ed23>] ? bus_find_device+0x75/0x83
        [<ffffffffa0022832>] ? via_init_one+0x269/0x28a [via82cxxx]
        [<ffffffffa00223a2>] ? init_chipset_via82cxxx+0x0/0x1ea [via82cxxx]
        [<ffffffff81059f25>] ? do_work_for_cpu+0x0/0x1b
        [<ffffffff81190c65>] ? local_pci_probe+0x12/0x16
        [<ffffffff81059f30>] ? do_work_for_cpu+0xb/0x1b
        [<ffffffff8105d0dd>] ? kthread+0x75/0x7d
        [<ffffffff810097e4>] ? kernel_thread_helper+0x4/0x10
        [<ffffffff8105d068>] ? kthread+0x0/0x7d
        [<ffffffff810097e0>] ? kernel_thread_helper+0x0/0x10
       ---[ end trace 89c8cb70379b5bda ]---
      
      The typo was introduced in a354ae87,
      and affects 2.6.33-rc4 and later.
      Signed-off-by: NYann Dirson <ydirson@altern.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2a800b7b
  2. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  3. 27 3月, 2010 1 次提交
  4. 19 1月, 2010 9 次提交
  5. 22 5月, 2009 1 次提交
  6. 25 3月, 2009 2 次提交
  7. 03 2月, 2009 1 次提交
  8. 15 1月, 2009 1 次提交
  9. 07 1月, 2009 1 次提交
  10. 22 10月, 2008 1 次提交
  11. 14 10月, 2008 1 次提交
  12. 11 10月, 2008 2 次提交
  13. 19 8月, 2008 1 次提交
  14. 06 8月, 2008 1 次提交
  15. 25 7月, 2008 7 次提交
  16. 24 7月, 2008 1 次提交
    • B
      ide: filter out "default" transfer mode values in set_xfer_rate() · 3b2a5c71
      Bartlomiej Zolnierkiewicz 提交于
      * Filter out "default" transfer mode values (0x00 - default PIO mode,
        0x01 - default PIO mode w/ IORDY disabled) in write handler for obsoleted
        /proc/ide/hd?/settings:current_speed setting.
      
        Allowing "default" transfer mode values is a dangerous thing to do as
        we don't support programming controller to the "default" transfer mode
        and devices often use different values for the default and maximum PIO
        mode (i.e. PIO2 default and PIO4 maximum) so the controller will stay
        programmed for higher PIO mode while device will use the lower PIO mode.
      
        There is no functionality loss as by using special IOCTLs device can
        still be programmed to "default" transfer modes (it is only useful for
        debugging/testing purposes anyway).
      
      * Remove no longer needed IDE_HFLAG_ABUSE_SET_DMA_MODE host flag, it was
        previously used by few host drivers to program the controller to PIO0
        timings for "default" transfer mode == 0x01 (although some host drivers
        would program invalid PIO timings instead).
      
      * Cleanup ide_set_xfer_rate() and add BUG_ON().
      Suggested-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      3b2a5c71
  17. 17 7月, 2008 1 次提交
    • B
      ide: convert ide-timing.h to ide-timings.c library (take 2) · f06ab340
      Bartlomiej Zolnierkiewicz 提交于
      * Don't include ide-timing.h in cs5535 and sis5513 host drivers
        (they don't need it currently).
      
      * Convert ide-timing.h to ide-timings.c library and add CONFIG_IDE_TIMINGS
        config option to be selected by host drivers using the library.
      
      While at it:
      
      - fix ide_timing_find_mode() placement
      
      v2:
      * Add missing EXPORT_SYMBOLs. (Stephen Rothwell <sfr@canb.auug.org.au>)
      
      There should be no functional changes caused by this patch.
      
      Cc: Stephen Rothwell <sfr@canb.auug.org.au>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      f06ab340
  18. 16 7月, 2008 2 次提交
  19. 27 4月, 2008 2 次提交
  20. 26 4月, 2008 2 次提交
  21. 19 2月, 2008 1 次提交