1. 05 11月, 2009 6 次提交
  2. 23 10月, 2009 1 次提交
    • X
      isdn: fix possible circular locking dependency · 2bd9af04
      Xiaotian Feng 提交于
      There's a circular locking dependency:
      
      ---> isdn_net_get_locked_lp
          --->lock &nd->queue_lock
          --->lock &nd->queue->xmit_lock
          .....................
          ---->unlock &nd->queue_lock
      
      ---> isdn_net_writebuf_skb (called with &nd->queue->xmit_lock locked)
          ---->isdn_net_inc_frame_cnt
               ---->isdn_net_device_busy
                    ----> lock &nd->queue_lock
      
      This will trigger lockdep warnings:
      
       =======================================================
       [ INFO: possible circular locking dependency detected ]
       2.6.32-rc4-testing #7
       -------------------------------------------------------
       ipppd/28379 is trying to acquire lock:
       (&netdev->queue_lock){......}, at: [<e62ad0fd>] isdn_net_device_busy+0x2c/0x74 [isdn]
      
       but task is already holding lock:
       (&netdev->local->xmit_lock){+.....}, at: [<e62aefc2>] isdn_net_write_super+0x3f/0x6e [isdn]
      
       which lock already depends on the new lock.
       .......
      
       We don't need to lock nd->queue->xmit_lock to protect single
      isdn_net_lp_busy(). This can fix above lockdep warnings.
      Reported-and-tested-by: NTilman Schmidt <tilman@imap.cc>
      Signed-off-by: NXiaotian Feng <xtfeng@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2bd9af04
  3. 07 10月, 2009 11 次提交
  4. 01 10月, 2009 1 次提交
  5. 29 9月, 2009 1 次提交
    • R
      isdn: fix netjet/isdnhdlc build errors · 8823ad31
      Randy Dunlap 提交于
      Commit cb3824ba didn't fix this problem.
      
      Fix build errors in netjet, using isdnhdlc module:
      
      drivers/built-in.o: In function `mode_tiger':
      netjet.c:(.text+0x1ca0c7): undefined reference to `isdnhdlc_rcv_init'
      netjet.c:(.text+0x1ca0d4): undefined reference to `isdnhdlc_out_init'
      drivers/built-in.o: In function `fill_dma':
      netjet.c:(.text+0x1ca2bd): undefined reference to `isdnhdlc_encode'
      drivers/built-in.o: In function `read_dma':
      netjet.c:(.text+0x1ca614): undefined reference to `isdnhdlc_decode'
      drivers/built-in.o: In function `nj_irq':
      netjet.c:(.text+0x1cb07a): undefined reference to `isdnhdlc_encode'
      
      drivers/built-in.o: In function `isdnhdlc_decode':
      (.text+0x1c2088): undefined reference to `crc_ccitt_table'
      drivers/built-in.o: In function `isdnhdlc_encode':
      (.text+0x1c2339): undefined reference to `crc_ccitt_table'
      Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      8823ad31
  6. 23 9月, 2009 1 次提交
  7. 22 9月, 2009 1 次提交
  8. 21 9月, 2009 2 次提交
  9. 20 9月, 2009 1 次提交
  10. 01 9月, 2009 1 次提交
  11. 03 8月, 2009 2 次提交
  12. 29 7月, 2009 1 次提交
  13. 27 7月, 2009 2 次提交
  14. 26 7月, 2009 9 次提交