Fixed multiple brace coding style issue.
Signed-off-by: NJason Wong <tsanghan@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The wait_ibsyclr function is supposed to return the status of the I2C
cycle.  Currently it will always return FALSE because the IIC_CSR2
register is not re-read in order to update the cached register value.
This results in the NEW_CYCLE bit still being 1.

The current code actually works correctly only because the return
value of {Read|Write}I2C is not checked in the driver.

Fix wait_ibsyclr by actually reading the IIC_CSR2 register to get the
updated status.  While here, change the return type to be an actual
errno instead of the private TRUE/FALSE define and remove the now
obvious comments about the return value.

Also, remove the local variable 'writestat' in WriteI2C and just
return the result of wait_ibsyclr.
Signed-off-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove duplicated #include('s) in
  drivers/staging/sep/sep_driver.c
Signed-off-by: NHuang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove unused #include <linux/version.h>('s) in
  drivers/staging/dt3155/allocator.c
  drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
  drivers/staging/vme/boards/vme_vmivme7805.c
Signed-off-by: NHuang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove duplicated #include('s) in
  drivers/staging/wlan-ng/p80211wext.c
Signed-off-by: NHuang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

These patches fixes some whitspace and indentation warnings from
checkpatch.pl

Also these changed #includes:
	bc_dts_glob_lnx.h:43: WARNING: Use #include <linux/param.h> instead of <asm/param.h>
	rystalhd_lnx.h:45: WARNING: Use #include <linux/io.h> instead of <asm/io.h>
	crystalhd_lnx.h:49: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

It all compiles fine, but I don't have the hardware to test with..
Signed-off-by: NLars Lindley <lindley@coyote.org>
Cc: Jarod Wilson <jarod@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use IS_ERR() instead of comparing to NULL.
Signed-off-by: NJani Nikula <ext-jani.1.nikula@nokia.com>
Cc: Jarod Wilson <jarod@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patches mds.c to replace all the C99 style comments (//) with C89
style (/* ... */), as reported by checkpatch.pl.
Signed-off-by: NMike Sheldon <mike@mikeasoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

a4_exists is an integer used as a boolean type so the original code
works.  But all the other conditions use && and this makes it
consistent.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Patch for smtcfb.c that removes spaces before tabs in the comments at
the beginning of the file.
Signed-off-by: NPatrick Rooney <candyguitar@googlemail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is a patch to the crystalhd_hw.c file that fixes up a white space
and brace warnings found by the checkpatch.pl tool
Signed-off-by: NTomas Dabasinskas <tomas.it@gmail.com>
Acked-by: NJarod Wilson <jarod@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is a patch to the et131x driver that fixes up almost all coding
style issues
Signed-off-by: NMichael Sprecher <sprecher.m@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is a patch for p80211req.c. An 'if' statement that spanned 80
characters has been split onto 2 lines and one of the tabs preceding
a comment has been removed.
Signed-off-by: NPatrick Rooney <candyguitar@googlemail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fixed multiple coding style issue.
Signed-off-by: NJason Wong <tsanghan@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Solves warnings found by the checkpatch.pl tool: spaces before tabs.
Signed-off-by: NPieter De Praetere <pieterc.depraetere@ugent.be>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is a patch to the adl_pci9111.c to fix up a brace warnging found by
the checkpatch.pl tool
Signed-off-by: NRich Folsom <rich.folsom@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch cleans up the dt2814.c driver file from issues found by
checkpatch.pl tool.
Signed-off-by: NFelipe de Oliveira Tanus <fotanus@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,e3,e4;
@@

- memset(e1,e2,e3);
  memcpy(e1,e4,e3);
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

fixed a bunch of coding-style issues generated from checkpatch.pl
Signed-off-by: NHenrik Hautakoski <henrik.hautakoski@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,e3,e4;
@@

- memset(e1,e2,e3);
  memcpy(e1,e4,e3);
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is a patch to the netwave_cs.c file that fixes up all the
trailing whitespace errors found by the checkpatch.pl tool.
Signed-off-by: NPrashant P. Shah <pshah.mumbai@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is a patch to fix the "missing KERN_facility level" error found
when running the checkpatch.pl script
Signed-off-by: NAseem Sethi <aseemsethi@yahoo.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Some fixes to receive handling:
  * Dieing with assertion failure when running out of memory is not ok
  * Use newer alloc function to get aligned skb
  * Dropped statistic is supposed to be incremented only by
    driver it was responsible for the drop.

Compile tested only.
Signed-off-by: NStephen Hemminger <shemminger@vyatta.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The network device structure has space already reserved for statistics.

Compile tested only.
Signed-off-by: NStephen Hemminger <shemminger@vyatta.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The Intel Restricted Access Region Handler provides a buffer allocation
mechanism to RAR users.  Since the intended usage model is to lock out
CPU access to RAR (the CPU will not be able to access RAR memory), this
driver does not access RAR memory, and merely keeps track of what areas
of RAR memory are in use.  It has it's own simple allocator that does
not rely on existing kernel allocators (SLAB, etc) since those
allocators are too tightly coupled with the paging mechanism, which isn't
needed for the intended RAR use cases.

An mmap() implementation is provided for debugging purposes to simplify
RAR memory access from the user space.  However, it will effectively be
a no-op when RAR access control is enabled since the CPU will not be
able to access RAR.

This driver should not be confused with the rar_register driver.  That
driver exposes an interface to access RAR registers on the Moorestown
platform.  The RAR handler driver relies on the rar_register driver for
low level RAR register reads and writes.

This patch was generated and built against the latest linux-2.6 master
branch.
Signed-off-by: NOssama Othman <ossama.othman@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch changes the use of semaphores in alphatrack.c and tranzport.c to
mutexes at the suggestion of checkpatch.pl
Signed-off-by: NEli Lindsey <eli@siliconsprawl.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is a patch to tranzport.c that changes a use of simple_strtoul to
strict_strtoul at the suggestion of checkpatch.pl
Signed-off-by: NEli Lindsey <eli@siliconsprawl.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is a patch to the adl_pci6208.c file that fixes up a space before
tabs warning found by checkpatch.pl tool.
Signed-off-by: NJaakko Niemelä <mato@kyborgi.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is a patch in hfa834x_usb.c to fix typedef declarations and long lines.
Signed-off-by: NEdgardo Hames <ehames@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The code is trying to say that if the offset is higher than the max it
should be set to the max, but there is an off by one bug and it sets it
one passed the end of the array.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch removes unecessary whitespace before quoted newlines
in two files.
One warning in each file remains unresolved.
Signed-off-by: NMichael Tate <michael.tate@wanadoo.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NFlorian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

removed extern keyword from rtl819x_watchdog_wqcallback.
removed static declaration from variable check_reset_cnt.
changed NumRxOkInPeriod and NumTxOkInPeriod comparison
in function rtl819x_watchdog_wqcallback to 666; we're not on windows.
plus cosmetics.
Signed-off-by: NFlorian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

variable i is declared integer in rtl8192SU_ConfigAdapterInfo8192SForAutoLoadFail.
a few lines down it is re-declared u8.
removed the re-declaration.
plus cosmetics
Signed-off-by: NFlorian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

this is basically a port of Larry Fingers Patch for rtl8187se to rtl8192su.
also removed some dead code.
plus cosmetics.
Signed-off-by: NFlorian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This revised patch fixes 2 brace coding style issues reported by checkpatch.pl
One warning line > 80 chars not resolved on maintainers advice.
Signed-off-by: NMichael Tate <michael.tate@wanadoo.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

fix all but one of the errors reported by checkpatch.pl tool.
Errors included wayward braces, white space issues(trailing
and prohibited), C99 issues, and foo* issues
Signed-off-by: NJohn Sheehan <john.d.sheehan@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Some confusion was caused by the ___iio_init_ring_buffer and equivalent
in ring_sw handling both init of spin locks etc and allocation and
of the actual buffer.  This resulted in ring->use_lock being held
before it was initialized and actually during the initialization.

Some of the recent cleanups in the spin lock code seem to have triggered
the bug actually causing traceable crashes.

The following patch should fix this but hasn't been extensively tested
as of yet and there may well be some side effects I haven't thought of.
Just wanted to get this out there before anyone else runs into it!
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>