- 29 3月, 2017 40 次提交
-
-
由 Suniel Mahesh 提交于
Prefer and make it generic by using %s and __func__ to print functions name instead of embedding functions name in print statements Signed-off-by: NSuniel Mahesh <suniel.spartan@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Derek Robson 提交于
Fixed style of block comments Found using checkpatch Signed-off-by: NDerek Robson <robsonde@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Pushkar Jambhlekar 提交于
ftrace can be used to trace functions. Removing function tracing using dev_dbg/info Signed-off-by: NPushkar Jambhlekar <pushkar.iit@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Pushkar Jambhlekar 提交于
dev_err: replacing hardcoded function name with '%s' and __func__ Signed-off-by: NPushkar Jambhlekar <pushkar.iit@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Tobin C. Harding 提交于
TODO file lists task to remove unnecessary error messages. There are no unnecessary error messages in the driver, this must have been done already. Remove task from TODO file. Signed-off-by: NTobin C. Harding <me@tobin.cc> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Tobin C. Harding 提交于
Driver contains dead code, guarded with #ifdef's. We can safely remove this, it will be in the git history if it is later needed. Remove dead code. Signed-off-by: NTobin C. Harding <me@tobin.cc> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Tobin C. Harding 提交于
Driver uses magic number members within structs, this is an antiquated method of catching data errors. We don't do things that way any more. Remove magic number struct members. Remove all checks to magic numbers. Signed-off-by: NTobin C. Harding <me@tobin.cc> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Tobin C. Harding 提交于
TODO file lists task to remove unnecessary comments. Make initial attempt at removing unnecessary comments. Choose not to be to vicious in removal. We can remove more once the driver is cleaned up/tested some more. For functions with internal linkage, reduce the function comment where possible. For functions with external linkage, migrate the function comment to kernel doc format. Signed-off-by: NTobin C. Harding <me@tobin.cc> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Tobin C. Harding 提交于
Pre-processor header guards use double underscore, typically kernel code uses single underscore when defining header guards. 'endif' statement should include what is ending as a comment string. Remove double underscore, add comment string to 'endif' Signed-off-by: NTobin C. Harding <me@tobin.cc> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Tobin C. Harding 提交于
TODO file has task: remove unnecessary comments. Driver uses some custom comment format. Driver would be better if it used kernel doc format. Audit header file comments. Replace struct comments with kernel doc format comments. Remove unnecessary comments. Signed-off-by: NTobin C. Harding <me@tobin.cc> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The function unisys_vmcall was returning VMCALL specific errors and the calling code was ignoring which error was actually returned. Instead we should be mapping the VMCALL error into a proper Linux error and then returning that, since we now have an error we know what to do with, we don't have to drop it but we can send it up the stack. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The only one using unisys_vmcall was visorchipset.c, it can be moved into the visorchipset file directly instead of being in a header file. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The comment at the beginning of the vmcallinterface.h file references IO Virtualization. It should be more specific that it is referencing s-Par Virtualization. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The macro ISSUE_IO_VMCALL was a wrapper around the function unisys_vmcall. It doesn't need to exist and was just being noisy, so get rid of it. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
We shouldn't be checking if VMCALL_CONTROLVM_ADDR is defined, remove it. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
We had several if statements inside of if statements that should be consolidated into an if statement with an && to clean up the code some more. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Remove braces around single line if statements, they are not needed. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
If there is an error in chipset_device_pause/resume don't try to respond, error out and let the calling functions respond to this error just like any other error they encounter. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Clean up the function to remove some if statments that should be done in the calling function. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
If we fail to register the visordriver, don't call unregister, just return with the error. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Don't override the visorchannel_read_error, just return the error that it generates. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The function dev_set_name can return an error, don't just ignore it. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The add_uevent_var returns an error. Don't overwrite the error with -ENOMEM, just pass the error code back up. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The forcenomatch parameter was not being used, so get rid of it. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The forcematch parameter was not being used, so get rid of it. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Create bus_type was just calling register_bustype. Since we control how many times we call create_bus_type it was extraneous keeping a counter if the bus was already registered, so the functions were no longer needed. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The function get_vbus_header_info returns errors that were being handled incorrectly. Fix the error handling in create_bus_instance. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Add error handling to visorbus_enable_channel_interrupt. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Report errors if we have a problem in dev_start_periodic_work. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
We only have one version of spar_check_channel, get rid of the client at the end and help save space. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The macro SPAR_VBUS_CHANNEL_CLIENT_OK was noisy and only used in one place so get rid of it. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Move vbuschannel_print_devinfo from vbuchannel.h to visorbus_main.c since it is only referenced in visorbus_main.c. Since it is in a .c file, get rid of the inline for it. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
With all the code churn, bus_responder and device_responder have become identical, consolidate them to the same function. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Adds error handling to the chipset_device_create message. If it returns a failure, it is assumed it has not signaled the s-Par firmware of the failure and the caller must do that. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Since signalinsert/remove now return valid error codes, we need to check them when we call them in visornic. The error codes need to propagate out to the calling functions. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Sameer Wadgaonkar 提交于
Added the __packed keyword to all structures in controlvmchannel.h to ensure alignment and size in memory. Signed-off-by: NSameer Wadgaonkar <sameer.wadgaonkar@unisys.com> Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The function chipset_bus_create should return an error. If an error is returned, it is assumed the response has not been sent by bus_create. Correctly handle when the error has been returned in visorchipset. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The ret variable was only returning an error, so changing it to err to be more consistent across the file. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The ret variable was only returning an error, so changing it to err to be more consistent across the file. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The ret variable was only returning an error, so changing it to err to be more consistent across the file. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NReviewed-by: Tim Sell <timothy.sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-