1. 12 1月, 2014 1 次提交
    • M
      [media] em28xx-audio: don't hardcode audio URB calculus · 1b3fd2d3
      Mauro Carvalho Chehab 提交于
      The current code hardcodes the number of audio URBs, the number
      of packets per URB and the maximum URB size.
      
      This is not a good idea, as it:
      
      - wastes more bandwidth than necessary, by using a very
        large number of packets;
      
      - those constants are bound to an specific scenario, with
        a bandwidth of 48 kHz;
      
      - don't take the maximum endpoint size into account;
      
      - with urb->interval = 1 on xHCI, those constraints cause a "funny"
        setup: URBs with 64 packets inside, with only 24 bytes total. E. g.
        a complete waste of space.
      
      Change the code to do dynamic URB audio calculus and allocation.
      
      For now, use the same constraints as used before this patch, to
      avoid regressions.
      
      A good scenario (tested) seems to use those defines, instead:
      
      	#define EM28XX_MAX_AUDIO_BUFS          8
      	#define EM28XX_MIN_AUDIO_PACKETS       2
      
      But let's not do such change here, letting the optimization to
      happen on latter patches, after more tests.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      1b3fd2d3
  2. 10 1月, 2014 2 次提交
  3. 07 1月, 2014 3 次提交
  4. 05 1月, 2014 2 次提交
  5. 21 12月, 2013 1 次提交
  6. 19 12月, 2013 1 次提交
  7. 11 12月, 2013 6 次提交
  8. 31 10月, 2013 2 次提交
  9. 19 6月, 2013 1 次提交
  10. 21 5月, 2013 1 次提交
  11. 29 3月, 2013 4 次提交
  12. 20 3月, 2013 1 次提交
  13. 19 3月, 2013 3 次提交
  14. 05 3月, 2013 8 次提交
  15. 06 2月, 2013 1 次提交
    • F
      [media] em28xx: get rid of the dependency on module ir-kbd-i2c · 768da3db
      Frank Schaefer 提交于
      We already have the key polling functions and the polling infrastructure in
      em28xx-input, so we can easily get rid of the dependency on module ir-kbd-i2c.
      For maximum safety, do not touch the key reporting mechanism for those devices.
      Code size could be improved further but would have minor peformance impacts.
      Tested with device "Terratec Cinergy 200 USB" (EM2800_BOARD_TERRATEC_CINERGY_200)
      
      [mchehab@redhat.com: Fix two checkpatch.pl warnings:
       ERROR: "foo * bar" should be "foo *bar" (line 465)
       WARNING: kfree(NULL) is safe this check is probably not required (line 725)]
      Signed-off-by: NFrank Schäfer <fschaefer.oss@googlemail.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      768da3db
  16. 05 1月, 2013 3 次提交