1. 04 7月, 2015 1 次提交
  2. 27 3月, 2015 1 次提交
  3. 24 10月, 2014 1 次提交
  4. 15 1月, 2014 1 次提交
  5. 16 4月, 2013 1 次提交
  6. 18 12月, 2012 1 次提交
    • N
      kvm: fix i8254 counter 0 wraparound · d4b06c2d
      Nickolai Zeldovich 提交于
      The kvm i8254 emulation for counter 0 (but not for counters 1 and 2)
      has at least two bugs in mode 0:
      
      1. The OUT bit, computed by pit_get_out(), is never set high.
      
      2. The counter value, computed by pit_get_count(), wraps back around to
         the initial counter value, rather than wrapping back to 0xFFFF
         (which is the behavior described in the comment in __kpit_elapsed,
         the behavior implemented by qemu, and the behavior observed on AMD
         hardware).
      
      The bug stems from __kpit_elapsed computing the elapsed time mod the
      initial counter value (stored as nanoseconds in ps->period).  This is both
      unnecessary (none of the callers of kpit_elapsed expect the value to be
      at most the initial counter value) and incorrect (it causes pit_get_count
      to appear to wrap around to the initial counter value rather than 0xFFFF).
      Removing this mod from __kpit_elapsed fixes both of the above bugs.
      Signed-off-by: NNickolai Zeldovich <nickolai@csail.mit.edu>
      Reviewed-by: NMarcelo Tosatti <mtosatti@redhat.com>
      Signed-off-by: NGleb Natapov <gleb@redhat.com>
      d4b06c2d
  7. 01 8月, 2012 3 次提交
  8. 28 4月, 2012 1 次提交
    • J
      KVM: x86: Run PIT work in own kthread · b6ddf05f
      Jan Kiszka 提交于
      We can't run PIT IRQ injection work in the interrupt context of the host
      timer. This would allow the user to influence the handler complexity by
      asking for a broadcast to a large number of VCPUs. Therefore, this work
      was pushed into workqueue context in 9d244caf2e. However, this prevents
      prioritizing the PIT injection over other task as workqueues share
      kernel threads.
      
      This replaces the workqueue with a kthread worker and gives that thread
      a name in the format "kvm-pit/<owner-process-pid>". That allows to
      identify and adjust the kthread priority according to the VM process
      parameters.
      Signed-off-by: NJan Kiszka <jan.kiszka@siemens.com>
      Signed-off-by: NMarcelo Tosatti <mtosatti@redhat.com>
      b6ddf05f
  9. 27 12月, 2011 1 次提交
  10. 25 12月, 2011 1 次提交
    • J
      KVM: x86: Prevent starting PIT timers in the absence of irqchip support · 0924ab2c
      Jan Kiszka 提交于
      User space may create the PIT and forgets about setting up the irqchips.
      In that case, firing PIT IRQs will crash the host:
      
      BUG: unable to handle kernel NULL pointer dereference at 0000000000000128
      IP: [<ffffffffa10f6280>] kvm_set_irq+0x30/0x170 [kvm]
      ...
      Call Trace:
       [<ffffffffa11228c1>] pit_do_work+0x51/0xd0 [kvm]
       [<ffffffff81071431>] process_one_work+0x111/0x4d0
       [<ffffffff81071bb2>] worker_thread+0x152/0x340
       [<ffffffff81075c8e>] kthread+0x7e/0x90
       [<ffffffff815a4474>] kernel_thread_helper+0x4/0x10
      
      Prevent this by checking the irqchip mode before starting a timer. We
      can't deny creating the PIT if the irqchips aren't set up yet as
      current user land expects this order to work.
      Signed-off-by: NJan Kiszka <jan.kiszka@siemens.com>
      Signed-off-by: NMarcelo Tosatti <mtosatti@redhat.com>
      0924ab2c
  11. 26 9月, 2011 1 次提交
    • S
      KVM: Intelligent device lookup on I/O bus · 743eeb0b
      Sasha Levin 提交于
      Currently the method of dealing with an IO operation on a bus (PIO/MMIO)
      is to call the read or write callback for each device registered
      on the bus until we find a device which handles it.
      
      Since the number of devices on a bus can be significant due to ioeventfds
      and coalesced MMIO zones, this leads to a lot of overhead on each IO
      operation.
      
      Instead of registering devices, we now register ranges which points to
      a device. Lookup is done using an efficient bsearch instead of a linear
      search.
      
      Performance test was conducted by comparing exit count per second with
      200 ioeventfds created on one byte and the guest is trying to access a
      different byte continuously (triggering usermode exits).
      Before the patch the guest has achieved 259k exits per second, after the
      patch the guest does 274k exits per second.
      
      Cc: Avi Kivity <avi@redhat.com>
      Cc: Marcelo Tosatti <mtosatti@redhat.com>
      Signed-off-by: NSasha Levin <levinsasha928@gmail.com>
      Signed-off-by: NAvi Kivity <avi@redhat.com>
      743eeb0b
  12. 24 10月, 2010 2 次提交
  13. 17 8月, 2010 1 次提交
  14. 15 8月, 2010 1 次提交
    • X
      KVM: destroy workqueue on kvm_create_pit() failures · 3185bf8c
      Xiaotian Feng 提交于
      kernel needs to destroy workqueue if kvm_create_pit() fails, otherwise
      after pit is freed, the workqueue is leaked.
      Signed-off-by: NXiaotian Feng <dfeng@redhat.com>
      Cc: Avi Kivity <avi@redhat.com>
      Cc: Marcelo Tosatti <mtosatti@redhat.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: "H. Peter Anvin" <hpa@zytor.com>
      Cc: Gleb Natapov <gleb@redhat.com>
      Cc: "Michael S. Tsirkin" <mst@redhat.com>
      Cc: Gregory Haskins <ghaskins@novell.com>
      Signed-off-by: NAvi Kivity <avi@redhat.com>
      3185bf8c
  15. 02 8月, 2010 2 次提交
    • X
      KVM: PIT: stop vpit before freeing irq_routing · aea924f6
      Xiao Guangrong 提交于
      Fix:
      general protection fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
      ......
      Call Trace:
       [<ffffffffa0159bd1>] ? kvm_set_irq+0xdd/0x24b [kvm]
       [<ffffffff8106ea8b>] ? trace_hardirqs_off_caller+0x1f/0x10e
       [<ffffffff813ad17f>] ? sub_preempt_count+0xe/0xb6
       [<ffffffff8106d273>] ? put_lock_stats+0xe/0x27
      ...
      RIP  [<ffffffffa0159c72>] kvm_set_irq+0x17e/0x24b [kvm]
      
      This bug is triggered when guest is shutdown, is because we freed
      irq_routing before pit thread stopped
      Signed-off-by: NXiao Guangrong <xiaoguangrong@cn.fujitsu.com>
      Signed-off-by: NMarcelo Tosatti <mtosatti@redhat.com>
      aea924f6
    • J
      KVM: fix lock imbalance in kvm_create_pit() · 673813e8
      Jiri Slaby 提交于
      Stanse found that there is an omitted unlock in kvm_create_pit in one fail
      path. Add proper unlock there.
      Signed-off-by: NJiri Slaby <jirislaby@gmail.com>
      Cc: Avi Kivity <avi@redhat.com>
      Cc: Marcelo Tosatti <mtosatti@redhat.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: "H. Peter Anvin" <hpa@zytor.com>
      Cc: x86@kernel.org
      Cc: Gleb Natapov <gleb@redhat.com>
      Cc: "Michael S. Tsirkin" <mst@redhat.com>
      Cc: Gregory Haskins <ghaskins@novell.com>
      Cc: kvm@vger.kernel.org
      Signed-off-by: NAvi Kivity <avi@redhat.com>
      673813e8
  16. 01 8月, 2010 2 次提交
  17. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  18. 01 3月, 2010 4 次提交
  19. 10 2月, 2010 1 次提交
  20. 10 12月, 2009 1 次提交
  21. 03 12月, 2009 1 次提交
  22. 16 10月, 2009 1 次提交
  23. 10 9月, 2009 10 次提交