提交 · 13122f98c6479ddbfc308eb4253f84aaf4a2b45e · openeuler / raspberrypi-kernel

26 4月, 2013 2 次提交

[media] dib8000: fix a warning · 13122f98

由 Mauro Carvalho Chehab 提交于 4月 25, 2013

drivers/media/dvb-frontends/dib8000.c: In function 'dib8000_wait_lock':
drivers/media/dvb-frontends/dib8000.c:3972:1: warning: 'value' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/media/dvb-frontends/dib8000.c:2419:6: note: 'value' was declared here
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

13122f98

[media] dib8000: Fix sub-channel range · 746f7ae0

由 Mauro Carvalho Chehab 提交于 4月 25, 2013

isdbt_sb_subchannel is unsigned with 8 bits. So, it will
never be -1. Instead, any value bigger than 13 is invalid.

As is, the current code generates the following warnings:

drivers/media/dvb-frontends/dib8000.c: In function 'dib8000_set_isdbt_common_channel':
drivers/media/dvb-frontends/dib8000.c:2358:3: warning: comparison is always true due to limited range of data type [-Wtype-limits]
drivers/media/dvb-frontends/dib8000.c: In function 'dib8000_tune':
drivers/media/dvb-frontends/dib8000.c:3107:8: warning: comparison is always false due to limited range of data type [-Wtype-limits]
drivers/media/dvb-frontends/dib8000.c:3153:9: warning: comparison is always false due to limited range of data type [-Wtype-limits]
drivers/media/dvb-frontends/dib8000.c:3160:5: warning: comparison is always false

It should also be noticed that ARIB STD-B31, item
"3.15.6.8 Number of segments" at TMCC table defines the
value 15 for unused segment, and 14 as reserved.

So, better to change the check to consider any value
bigger than 13 to mean that sub-channels should be
disabled, fixing the warning and doing the right thing
even if an invalid value is filled by userspace.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

746f7ae0

25 4月, 2013 36 次提交

[media] dib8000: store dtv_property_cache in a temp var · c82056d0

由 Mauro Carvalho Chehab 提交于 4月 25, 2013

dtv_property_cache is used on several places on very long lines.

On all places it is used, a long list of struct reference is done.

Instead of doing it, at the routines where it is used more than once,
replace it by one temporary var. That may help the compiler to
use a better code. It also makes easier to review the code, as the
lines becomes closer to 80 columns, making them a way clearer
to read.

No functional changes.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

c82056d0

[media] dib8000: warning fix: declare internal functions as static · 6f7ee06f

由 Mauro Carvalho Chehab 提交于 4月 25, 2013

drivers/media/dvb-frontends/dib8000.c:2412:5: warning: no previous prototype for 'dib8000_wait_lock' [-Wmissing-prototypes]
drivers/media/dvb-frontends/dib8000.c:2688:5: warning: no previous prototype for 'dib8000_get_symbol_duration' [-Wmissing-prototypes]
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

6f7ee06f

[media] r820t: quiet gcc warning on n_ring · 619ab8f6

由 Fengguang Wu 提交于 4月 20, 2013

drivers/media/tuners/r820t.c: In function 'r820t_imr':
drivers/media/tuners/r820t.c:1871:8: warning: 'n_ring' may be used uninitialized in this function [-Wmaybe-uninitialized]
Mauro: This is a FALSE POSITIVE: the loop will always return a value
for n_ring, as the last test will fill it with 15, if the loop fails.
Signed-off-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

619ab8f6

[media] r820t: memory leak in release() · ef0c8700

由 Dan Carpenter 提交于 4月 18, 2013

I've moved the kfree(fe->tuner_priv) one line earlier, otherwise it is
a no-op.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

ef0c8700

[media] r820t: precendence bug in r820t_xtal_check() · f7a12fdf

由 Dan Carpenter 提交于 4月 18, 2013

The test as written is always false.  It looks like the intent was to
test that the bit was not set.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

f7a12fdf

[media] anysee: Grammar s/report the/report to/ · 542b329f

由 Geert Uytterhoeven 提交于 4月 24, 2013

[mchehab@redhat.com: Fix a merge conflict]
Signed-off-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

542b329f

[media] anysee: Initialize ret = 0 in anysee_frontend_attach() · ecb52ab8

由 Geert Uytterhoeven 提交于 4月 24, 2013

drivers/media/usb/dvb-usb-v2/anysee.c: In function ‘anysee_frontend_attach’:
drivers/media/usb/dvb-usb-v2/anysee.c:641: warning: ‘ret’ may be used uninitialized in this function
And gcc is right (see the ANYSEE_HW_507T case), so initialize ret to zero
to fix this.
Signed-off-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

ecb52ab8

[media] media: videobuf2: fix the length check for mmap · 7f841459

由 Mauro Carvalho Chehab 提交于 4月 19, 2013

Memory maps typically require that the buffer size to be page
aligned. Currently, two memops drivers do such alignment
internally, but videobuf-vmalloc doesn't.
Also, the buffer overflow check doesn't take it into account.
So, instead of doing it at each memops driver, enforce it at
VB2 core.
Reported-by: NPrabhakar lad <prabhakar.csengg@gmail.com>
Acked-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: NMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

7f841459

[media] em28xx: save isoc endpoint number for DVB only if endpoint has alt... · b3404a8e

由 Frank Schaefer 提交于 4月 08, 2013

[media] em28xx: save isoc endpoint number for DVB only if endpoint has alt settings with xMaxPacketSize != 0

X-Patchwork-Delegate: mchehab@redhat.com
In addition to commit 72cc9ba3 "em28xx: ignore isoc DVB USB endpoints with
wMaxPacketSize = 0 bytes for all alt settings" we should not save the endpoint
number of the isoc DVB endpoint before it has been validated.
While the current code works fine, dev->dvb_ep_isoc != 0 could be interpreted
as indicator that the device provides DVB support.
Signed-off-by: NFrank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

b3404a8e

[media] videobuf-dma-contig: remove support for cached mem · cb132cd5

由 Mauro Carvalho Chehab 提交于 4月 17, 2013

videobuf_queue_dma_contig_init_cached() is not used anywhere.
Drop support for it, cleaning up the code a little bit.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Acked-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

cb132cd5

[media] mem2mem_testdev: set timestamp_type and add debug param · d95d7c64

由 Hans Verkuil 提交于 4月 17, 2013

While testing v4l2-ctl I noticed that this m2m driver didn't set timestamp_type
and that it spammed the kernel log with debug messages. Set timestamp_type
correctly and add debug module option to enable debug messages.
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NKamil Debski <k.debski@samsung.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

d95d7c64

[media] mx2-emmaprp: Add copy time stamp handling · a8c9c345

由 Kamil Debski 提交于 4月 25, 2013

Since the introduction of the timestamp_type field, it is necessary that
the driver chooses which type it will use. This patch adds support for
the timestamp_type.
Signed-off-by: NKamil Debski <k.debski@samsung.com>
Signed-off-by: NKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

a8c9c345

[media] m2m-deinterlace: Add copy time stamp handling · 7f1e8f19