1. 06 7月, 2006 7 次提交
  2. 04 7月, 2006 2 次提交
    • A
      [PATCH] lockdep: annotate hostap netdev ->xmit_lock · cd11acdd
      Arjan van de Ven 提交于
      On Fri, 2006-06-30 at 15:45 -0700, Miles Lane wrote:
      > Okay, I rebuilt my kernel with your combo patch applied.
      > Then, I inserted my US Robotics USR2210 PCMCIA wifi card,
      > ran "pccardutil eject", popped out the card and then inserted
      > a Compaq iPaq wifi card.  This triggered the following.
      >
      > [ INFO: possible circular locking dependency detected ]
      > -------------------------------------------------------
      > syslogd/1886 is trying to acquire lock:
      >  (&dev->queue_lock){-+..}, at: [<c11a50b5>] dev_queue_xmit+0x120/0x24b
      >
      > but task is already holding lock:
      >  (&dev->_xmit_lock){-+..}, at: [<c11a5118>] dev_queue_xmit+0x183/0x24b
      >
      > which lock already depends on the new lock.
      
      ok this appears to be hostap playing games... it has 2 network devices
      for one piece of hardware and one calls the other via the networking
      layer; there is thankfully a natural ordering between the two, so just
      making the slave one a separate type ought to make this work.
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      Cc: Arjan van de Ven <arjan@linux.intel.com>
      Cc: "John W. Linville" <linville@tuxdriver.com>
      Cc: Jeff Garzik <jeff@garzik.org>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      cd11acdd
    • S
      kbuild: introduce utsrelease.h · 63104eec
      Sam Ravnborg 提交于
      include/linux/version.h contained both actual KERNEL version
      and UTS_RELEASE that contains a subset from git SHA1 for when
      kernel was compiled as part of a git repository.
      This had the unfortunate side-effect that all files including version.h
      would be recompiled when some git changes was made due to changes SHA1.
      Split it out so we keep independent parts in separate files.
      
      Also update checkversion.pl script to no longer check for UTS_RELEASE.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      63104eec
  3. 03 7月, 2006 1 次提交
  4. 01 7月, 2006 3 次提交
  5. 28 6月, 2006 1 次提交
  6. 27 6月, 2006 2 次提交
  7. 23 6月, 2006 3 次提交
    • H
      [NET]: Avoid allocating skb in skb_pad · 5b057c6b
      Herbert Xu 提交于
      First of all it is unnecessary to allocate a new skb in skb_pad since
      the existing one is not shared.  More importantly, our hard_start_xmit
      interface does not allow a new skb to be allocated since that breaks
      requeueing.
      
      This patch uses pskb_expand_head to expand the existing skb and linearize
      it if needed.  Actually, someone should sift through every instance of
      skb_pad on a non-linear skb as they do not fit the reasons why this was
      originally created.
      
      Incidentally, this fixes a minor bug when the skb is cloned (tcpdump,
      TCP, etc.).  As it is skb_pad will simply write over a cloned skb.  Because
      of the position of the write it is unlikely to cause problems but still
      it's best if we don't do it.
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      5b057c6b
    • A
      [PATCH] skb_padto()-area fixes in 8390, wavelan · aa95abef
      Alan Cox 提交于
      Ar Iau, 2006-06-22 am 21:29 +1000, ysgrifennodd Herbert Xu:
      > Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
      > >
      > > The 8390 change (corrected version) also makes 8390.c faster so should
      > > be applied anyway, and the orinoco one fixes some code that isn't even
      > > needed and someone forgot to remove long ago. Otherwise the skb_padto
      >
      > Yeah I agree totally.  However, I haven't actually seen the fixed 8390
      > version being posted yet or at least not to netdev :)
      
      Ah the resounding clang of a subtle hint ;)
      Signed-off-by: NAlan Cox <alan@redhat.com>
      
      - Return 8390.c to the old way of handling short packets (which is also
      faster)
      
      - Remove the skb_padto from orinoco. This got left in when the padding bad
      write patch was added and is actually not needed. This is fixing a merge
      error way back when.
      
      - Wavelan can also use the stack based buffer trick if you want
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      aa95abef
    • E
      [PATCH] Array overrun in drivers/net/wireless/wavelan.c · a192491a
      Eric Sesterhenn 提交于
      hi,
      
      this is another array overrun spotted by coverity (#id 507)
      we should check the index against array size before using it.
      Not sure why the driver doesnt use ARRAY_SIZE instead of its
      own macro.
      Signed-off-by: NEric Sesterhenn <snakebyte@gmx.de>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      a192491a
  8. 18 6月, 2006 1 次提交
    • H
      [NET]: Add netif_tx_lock · 932ff279
      Herbert Xu 提交于
      Various drivers use xmit_lock internally to synchronise with their
      transmission routines.  They do so without setting xmit_lock_owner.
      This is fine as long as netpoll is not in use.
      
      With netpoll it is possible for deadlocks to occur if xmit_lock_owner
      isn't set.  This is because if a printk occurs while xmit_lock is held
      and xmit_lock_owner is not set can cause netpoll to attempt to take
      xmit_lock recursively.
      
      While it is possible to resolve this by getting netpoll to use
      trylock, it is suboptimal because netpoll's sole objective is to
      maximise the chance of getting the printk out on the wire.  So
      delaying or dropping the message is to be avoided as much as possible.
      
      So the only alternative is to always set xmit_lock_owner.  The
      following patch does this by introducing the netif_tx_lock family of
      functions that take care of setting/unsetting xmit_lock_owner.
      
      I renamed xmit_lock to _xmit_lock to indicate that it should not be
      used directly.  I didn't provide irq versions of the netif_tx_lock
      functions since xmit_lock is meant to be a BH-disabling lock.
      
      This is pretty much a straight text substitution except for a small
      bug fix in winbond.  It currently uses
      netif_stop_queue/spin_unlock_wait to stop transmission.  This is
      unsafe as an IRQ can potentially wake up the queue.  So it is safer to
      use netif_tx_disable.
      
      The hamradio bits used spin_lock_irq but it is unnecessary as
      xmit_lock must never be taken in an IRQ handler.
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      932ff279
  9. 16 6月, 2006 4 次提交
  10. 06 6月, 2006 3 次提交
  11. 27 5月, 2006 2 次提交
  12. 24 5月, 2006 1 次提交
  13. 23 5月, 2006 2 次提交
  14. 18 5月, 2006 2 次提交
  15. 06 5月, 2006 6 次提交