There is a typo so we have && instead of &.

Fixes: ff8f8370 ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Acked-by: NAndrew Duggan <aduggan@synaptics.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The powermate driver expects at least one valid USB endpoint in its
probe function.  If given malicious descriptors that specify 0 for
the number of endpoints, it will crash.  Validate the number of
endpoints on the interface before using them.

The full report for this issue can be found here:
http://seclists.org/bugtraq/2016/Mar/85Reported-by: NRalf Spenneberg <ralf@spenneberg.net>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: NJosh Boyer <jwboyer@fedoraproject.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

On error syscon_regmap_lookup_by_phandle() returns ERR_PTR() value,
which makes a check for NULL invalid and may lead to oops on error
path.
Signed-off-by: NVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add devicetree binding for SPI devices.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Acked-by: NRob Herring <robh@kernel.org>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add the transport driver for devices using RMI4 over SPI.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

RMI4 F30 supports input from clickpad buttons and controls LEDs located
on the touchpad PCB. This patch adds support of the clickpad buttons and
defers supporting LEDs for the future.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Signed-off-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Function 12 implements 2D touch position sensor for newer Synaptics touch
devices. It replaces F11 and no device will contain both functions.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Signed-off-by: NChristopher Heiny <cheiny@synaptics.com>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

2D sensors have several parameter which can be set in the platform data.
This patch adds support for getting those values from devicetree.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

RMI4 currently defines two functions for reporting data for 2D sensors
(F11 and F12). This patch adds the common functionality which is shared
by devices with 2D reporting along with implementing functionality for
F11.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Signed-off-by: NChristopher Heiny <cheiny@synaptics.com>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add devicetree binding for I2C devices and add bindings for optional
parameters in the function drivers. Parameters for function drivers are
defined in child nodes for each of the functions.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Acked-by: NRob Herring <robh@kernel.org>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add the transport driver for devices using RMI4 over I2C.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Signed-off-by: NChristopher Heiny <cheiny@synaptics.com>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Synaptics uses the Register Mapped Interface (RMI) protocol as a
communications interface for their devices. This driver adds the core
functionality needed to interface with RMI4 devices.

RMI devices can be connected to the host via several transport protocols
and can supports a wide variety of functionality defined by RMI functions.
Support for transport protocols and RMI functions are implemented in
individual drivers. The RMI4 core driver uses a bus architecture to
facilitate the various combinations of transport and function drivers
needed by a particular device.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Signed-off-by: NChristopher Heiny <cheiny@synaptics.com>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add device tree support for the I2C and SPI variant of AD7879(-1).
This allows to specify the touchscreen controller as a I2C client
node or SPI slave device. Most of the options available in platform
data are also available as device tree properties, the only exception
being GPIO capabilities, which can not be activated through device
tree currently.
Signed-off-by: NStefan Agner <stefan@agner.ch>
Acked-by: NRob Herring <robh@kernel.org>
Acked-by: NMichael Hennerich <michael.hennerich@analog.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The X/Y position measurements read from the controller are interpreted
wrong. The first measurement X+ contains the Y position, and the second
measurement Y+ the X position (see also Table 11 Register Table in the
data sheet).

The problem is already known and a swap option has been introduced:
commit 6680884a ("Input: ad7879 - add option to correct xy axis")

However, the meaning of the new boolean is inverted since the underlying
values are already swapped. Let ts->swap_xy set to true actually be the
swapped configuration of the two axis.
Signed-off-by: NStefan Agner <stefan@agner.ch>
Acked-by: NMichael Hennerich <michael.hennerich@analog.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The header file is used by the SPI and I2C variant of the driver.
Therefore, move it to a more generic place under platform_data.
Signed-off-by: NStefan Agner <stefan@agner.ch>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The Technologic Systems TS-4800 is an i.MX515 board, so its drivers
are useless unless building a SOC_IMX51 kernel, except for build
testing purposes.
Signed-off-by: NJean Delvare <jdelvare@suse.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

When changing the scan rate as part of runtime-resume process we may lose
some of the events, because:

1) for gen3 trackpads, the driver must msleep() some time to ensure that
the device is ready to accept next command;

2) for gen5 and later trackpads, the queue dumping function will simply
ignore the events when waiting for the set power mode command response.

The solution is to keep polling and report those valid events when the set
power mode command is in progress.
Signed-off-by: NDudley Du <dudl@cypress.com>
Tested-by: NJeremiah Mahler <jmmahler@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

A dependency on ARCH_SHMOBILE seems to be the best option for sh_keysc:

* For Super H based SoCs: sh_keysc is used on SH_MIGOR, SH_ECOVEC, SH_KFR2R09,
  SH_7722_SOLUTION_ENGINE, and SH_7724_SOLUTION_ENGINE, which depend on
  either CPU_SUBTYPE_SH7722 or CPU_SUBTYPE_SH7724, and both select
  ARCH_SHMOBILE.

* For ARM Based SoCs: Since the removal of legacy (non-multiplatform) support
  this driver has not been used by any Renesas ARM based SoCs. The Renesas
  ARM based SoCs currently select ARCH_SHMOBILE, however, it is planned
  that this will no longer be the case.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.
Signed-off-by: NSimon Horman <horms+renesas@verge.net.au>
Acked-by: NGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add support for retrieving device resolution (pixels per mm) from firmware
and using it when setting up input device.
Signed-off-by: NSangwon Jee <jeesw@melfas.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This changes how the used gpios are stored (i.e. a struct gpio_descs
instead of two struct gpio_desc) and as with >2 gpios the states are
numbered differently the function rotary_encoder_get_state returns
unencoded numbers instead of grey encoded numbers before. The latter has
some implications on how the returned value is used and so the change is
bigger than one might expect at first.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: NRob Herring <robh@kernel.org>
Acked-by: NDaniel Mack <daniel@zonque.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Drop support for platform data passed via a C-structure and switch to
device properties instead, which should make the driver compatible with all
platforms: OF, ACPI and static boards. Static boards should use property
sets to communicate device parameters to the driver.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

commit e4b88e19
"Input: stmpe-ts - enforce device tree only mode"
removed platform data but accidentally stripped away useful
kerneldoc, so reintroduce it.
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The SNVS power key driver has suspend/resume functions that
are accessed using SIMPLE_DEV_PM_OPS, which hide the reference
when CONFIG_PM_SLEEP is not set, resulting in a warning about
unused functions:

drivers/input/keyboard/snvs_pwrkey.c:183:12: error: 'imx_snvs_pwrkey_suspend' defined but not used [-Werror=unused-function]
drivers/input/keyboard/snvs_pwrkey.c:194:12: error: 'imx_snvs_pwrkey_resume' defined but not used [-Werror=unused-function]

This adds __maybe_unused annotations to let the compiler know
it can silently drop the function definition.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NFrank Li <Frank.Li@nxp.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The spear keyboard driver uses #ifdef CONFIG_PM to hide its
power management functions, but then uses references from
SIMPLE_DEV_PM_OPS that are only present if both CONFIG_PM
and CONFIG_PM_SLEEP are set, resulting in a warning about unused
functions:

drivers/input/keyboard/spear-keyboard.c:292:12: error: 'spear_kbd_suspend' defined but not used [-Werror=unused-function]
drivers/input/keyboard/spear-keyboard.c:345:12: error: 'spear_kbd_resume' defined but not used [-Werror=unused-function]

This removes the #ifdef and instead uses a __maybe_unused
annotation.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add ACPI binding to the goldfish events driver.
Signed-off-by: NJason Hu <jia-cheng.hu@intel.com>
Signed-off-by: NJin Qian <jinqian@android.com>
Signed-off-by: NAlan <alan@linux.intel.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add device tree bindings to the Goldfish virtual platform event driver.
Signed-off-by: NGreg Hackmann <ghackmann@google.com>
Signed-off-by: NJin Qian <jinqian@android.com>
Signed-off-by: NAlan <alan@linux.intel.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of manipulating capability bits directly let's use appropriate
helpers. Also there is no need to explicitly set EV_ABS when calling
input_set_abs_params().
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of using old GPIO API, let's switch to GPIOD API, which
automatically handles polarity.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of guarding PM methods with #ifdef let's mark them as
__maybe_unused as it allows for better compile coverage.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Convert to use threaded IRQs to support GPIOs that can sleep.
Protect the irq handler with mutex as it can be triggered from
two different irq lines accessing the same state.

This allows using GPIO expanders behind I2C or SPI bus.
Signed-off-by: NTimo Teräs <timo.teras@iki.fi>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This is an input driver for MELFAS MIP4 Touchscreen devices, such as
MMS400, MMS500, MCS8000, MIT200, MIT300, MIT400, MFS10. All devices
implementing MIP4 protocol (MELFAS Interface Protocol Version 4) should
be supported by this driver.
Signed-off-by: NSangwon Jee <jeesw@melfas.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This patch fix spelling typos found in printk and Kconfig.
Signed-off-by: NMasanari Iida <standby24x7@gmail.com>
Acked-by: NRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: NJiri Kosina <jkosina@suse.cz>

drivers/input/touchscreen/colibri-vf50-ts.c: In function ‘vf50_ts_probe’:
drivers/input/touchscreen/colibri-vf50-ts.c:302: error: implicit declaration of function ‘of_property_read_u32’
Signed-off-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The adp5589 has row 5, don't skip it when creating the GPIO mapping.
Otherwise the pin gets reserved as used and it is not possible to use it as
a GPIO.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Acked-by: NMichael Hennerich <michael.hennerich@analog.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

A recent patch broke parsing the gain, offset, and threshold parameters
from device tree. Instead of setting the cached values and writing them
to the correct registers during probe, it would write the values from DT
into the register address variables and never write them to the chip
during normal operation.

Fixes: 2e23b7a9 ("Input: edt-ft5x06 - use generic properties API")
Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
functionality only, can still be compiled if GPIOLIB is not enabled.

If COMPILE_TEST is enabled, relax the dependency on GPIOLIB for the
recently introduced or relaxed symbols TOUCHSCREEN_GOODIX and
TOUCHSCREEN_COLIBRI_VF50.
Signed-off-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Driver for the BYD BTP10463 touchpad, found in PC Specialist `Lafite'
laptops. This patch sends the magic command sequence which causes the
touchpad to stream intellimouse-style packets.

Gestures are detected inside the touchpad, and exposed as special
values in the Z component of each packet - absolute coordinates are
not supported, even in the Windows driver. At present, this supports
two-finger vertical and horizontal scrolling, and provides the
framework to expose the other gestures it can recognize.
Signed-off-by: NChris Diamand <chris@diamand.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We should set device's capabilities first, and then register it,
otherwise various handlers already present in the kernel will not be
able to connect to the device.
Reported-by: NLauri Kasanen <cand@gmx.com>
Cc: stable@vger.kernel.org
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Now serio_find_driver() will print warnings in case device_attach()
returns -EPROBE_DEFER. Those warnings are obsolete, in genral, because:
- DD core can report the same if required
- since commit 013c074f ("PM / sleep: prohibit devices probing
during suspend/hibernation") the devices probing is prohibited during
System suspend and deferred device will be carefully reprobed once
Resume is finished.

Hence, drop warnings in case of EPROBE_DEFER from serio_find_driver().
Signed-off-by: NGrygorii Strashko <grygorii.strashko@ti.com>
Acked-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

for_each_child_of_node performs an of_node_get on each iteration, so
to break out of the loop an of_node_put is required.

Found using Coccinelle.
Signed-off-by: NAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>