Body of an "if" statement wasn't indented.  Add a tab.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Reorder struct hisi_pcie to put generic fields first.  No functional change
intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Only interfaces used from outside the driver, e.g., those called by the
DesignWare core, need to accept pointers to the generic struct pcie_port.
Internal interfaces can accept pointers to the device-specific struct,
which makes them more straightforward.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Include the PCIE_HIP06_CTRL_OFF block base in the PCIE_SYS_STATE4 register
address so reads of PCIE_SYS_STATE4 don't have to mention both.  No
functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Reorder struct dra7xx_pcie to put generic fields first.  No functional
change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

The xilinx-nwl driver never uses the platform drvdata pointer, so don't
bother setting it.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Use a local "struct device *dev" for brevity and consistency with other
drivers.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

xilinx_pcie_assign_msi() doesn't use the struct xilinx_pcie_port pointer
passed to it, so remove the argument completely.  No functional change
intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

The xilinx driver never uses the platform drvdata pointer, so don't
bother setting it.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Use a local "struct device *dev" for brevity and consistency with other
drivers.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Add device-specific register accessors for consistency across host drivers.
No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Pass the struct xgene_pcie_port pointer, not addresses, to setup functions.
This enables future simplifications.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

The xgene driver never uses the platform drvdata pointer, so don't
bother setting it.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

The tegra driver never uses the platform drvdata pointer, so don't
bother setting it.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Use a local "struct device *dev" for brevity and consistency with other
drivers.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

The tegra_pcie_phy_disable() path called pads_writel() with arguments in
the wrong order.  Swap them to be the "value, offset" order expected by
pads_writel().

Fixes: 6fe7c187 ("PCI: tegra: Support per-lane PHYs")
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>
Acked-by: NThierry Reding <treding@nvidia.com>
CC: stable@vger.kernel.org	# v4.7+

The rockchip driver never uses the platform drvdata pointer, so don't
bother setting it.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>
Acked-by: NShawn Lin <shawn.lin@rock-chips.com>

Use a local "struct device *dev" for brevity and consistency with other
drivers.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>
Acked-by: NSimon Horman <horms+renesas@verge.net.au>

The DRV_NAME macro is only used once, so there's no real advantage to
having the macro at all.  Remove it and use the "rcar-pcie" name directly
in the struct platform_driver.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>
Acked-by: NSimon Horman <horms+renesas@verge.net.au>

rcar_pcie_get_resources() doesn't use the platform_device pointer passed to
it, so remove it.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>
Acked-by: NSimon Horman <horms+renesas@verge.net.au>

The rcar driver never uses the platform drvdata pointer, so don't bother
setting it.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>
Acked-by: NSimon Horman <horms+renesas@verge.net.au>

Reorder struct qcom_pcie to put generic fields first.  No functional change
intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Remove the struct qcom_pcie.dev member, which is a duplicate of the generic
pp.dev member.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Remove the struct qcom_pcie.dbi member, which is a duplicate of the generic
pp.dbi_base member.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

The qcom driver never uses the platform drvdata pointer, so don't bother
setting it.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Use the existing "np" pointer instead of looking up dev->of_node again.  No
functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Use a local "struct device *dev" for brevity and consistency with other
drivers.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Reorder struct ls_pcie to put generic fields first.  No functional change
intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

ls_add_pcie_port() doesn't use the platform_device pointer passed to it, so
remove it.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Do the basic pcie_port setup in the probe function for consistency with
other drivers.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Only interfaces used from outside the driver, e.g., those called by the
DesignWare core, need to accept pointers to the generic struct pcie_port.
Internal interfaces can accept pointers to the device-specific struct,
which makes them more straightforward.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Remove the struct ls_pcie.dbi member, which is a duplicate of the generic
pp.dbi_base member.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

The layerscape driver never uses the platform drvdata pointer, so don't
bother setting it.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Use a local "struct device *dev" for brevity and consistency with other
drivers.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Reorder struct keystone_pcie to put generic fields first.  No functional
change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Add device-specific register accessors for consistency across host drivers.
No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Instead of passing ks_pcie->va_app_base to DBI mode functions,
pass the struct keystone_pcie.  This will allow them to use register
accessors.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Instead of passing the application register base to IRQ functions,
pass the struct keystone_pcie.  This will allow them to use register
accessors.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

The dw_pcie_readl_rc() and dw_pcie_writel_rc() interfaces already add in
pp->dbi_base, so use those instead of doing it ourselves in the keystone
driver.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>

Use a local "struct device *dev" for brevity and consistency with other
drivers.  No functional change intended.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>