EFLAGS.ZF needs to be checked after each iteration, not before.
Signed-off-by: NAvi Kivity <avi@redhat.com>

Signed-off-by: NAvi Kivity <avi@redhat.com>

emulate_push() only schedules a push; it doesn't actually push anything.
Call writeback() to flush out the write.
Signed-off-by: NAvi Kivity <avi@redhat.com>

Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Change OUT instruction to use dst instead of src, so we can
reuse those code for all out instructions.
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Introduce DstImmUByte for dst operand decode, which
will be used for out instruction.
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Add setcc instruction emulation (opcode 0x0f 0x90~0x9f)
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Add XADD instruction emulation (opcode 0x0f 0xc0~0xc1)
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Introduce function write_register_operand() to write back the
register operand.
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Add bsf/bsr instruction emulation (opcode 0x0f 0xbc~0xbd)
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

This patch lets emulate_grp3() return X86EMUL_* return codes instead
of hardcoded ones.
Signed-off-by: NMohammed Gamal <m.gamal005@gmail.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

This adds unary mul, imul, div, and idiv instructions (group 3 r/m 4-7).
Signed-off-by: NMohammed Gamal <m.gamal005@gmail.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Mask group 8 instruction as BitOp, so we can share the
code for adjust the source operand.
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Reviewed-by: NPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

adjust the dst address for a register source but not adjust the
address for an immediate source.
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Reviewed-by: NPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

If bit offset operands is a negative number, BitOp instruction
will return wrong value. This patch fix it.
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Reviewed-by: NPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Signed-off-by: NMohammed Gamal <m.gamal005@gmail.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Using SrcOne for instruction d0/d1 decoding.
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

This patch change to disable writeback when decode dest
operand if the dest type is ImplicitOps or not specified.
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Use SrcAcc to simplify stos decoding.
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

This adds support for int instructions to the emulator.
Signed-off-by: NMohammed Gamal <m.gamal005@gmail.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Two-byte opcode always start with 0x0F and the decode flags
of opcode 0xF0 is always 0, so remove dup check.
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

If a nop instruction is encountered, we jump directly to the done label.
This skip updating rip. Break from the switch case instead
Signed-off-by: NMohammed Gamal <m.gamal005@gmail.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

Since modrm operand can be either register or memory, decoding it into
a 'struct operand', which can represent both, is simpler.
Signed-off-by: NAvi Kivity <avi@redhat.com>

Instead of using modrm_ea, which will soon be gone.
Signed-off-by: NAvi Kivity <avi@redhat.com>

The NoAccess flag will prevent memory from being accessed.
Signed-off-by: NAvi Kivity <avi@redhat.com>

Use for INVLPG, which accesses the tlb, not memory.
Signed-off-by: NAvi Kivity <avi@redhat.com>

This is an ordinary modrm source or destination; use the standard structure
representing it.
Signed-off-by: NAvi Kivity <avi@redhat.com>

This is an ordinary modrm source or destination; use the standard structure
representing it.
Signed-off-by: NAvi Kivity <avi@redhat.com>

Signed-off-by: NAvi Kivity <avi@redhat.com>

The operands for these instructions are 32 bits or 64 bits, depending on
long mode, and ignoring REX prefixes, or the operand size prefix.
Signed-off-by: NAvi Kivity <avi@redhat.com>

(x && (x & y)) == (x & y)
Signed-off-by: NAvi Kivity <avi@redhat.com>

Unused (and has never been).
Signed-off-by: NAvi Kivity <avi@redhat.com>

The code is repeated three times, put it into fetch_register_operand()
Signed-off-by: NAvi Kivity <avi@redhat.com>

Signed-off-by: NAvi Kivity <avi@redhat.com>

Use X8() to avoid repetition.
Signed-off-by: NAvi Kivity <avi@redhat.com>

Currently we use a void pointer for memory addresses.  That's wrong since
these are guest virtual addresses which are not directly dereferencable by
the host.

Use the correct type, unsigned long.
Signed-off-by: NAvi Kivity <avi@redhat.com>

Let it compute modrm_seg instead, and have the caller apply it.
Signed-off-by: NAvi Kivity <avi@redhat.com>

Do not recheck io permission on every iteration.
Signed-off-by: NGleb Natapov <gleb@redhat.com>
Signed-off-by: NAvi Kivity <avi@redhat.com>

LMSW is documented not to be able to clear cr0.pe; make it so.
Signed-off-by: NAvi Kivity <avi@redhat.com>