1. 14 9月, 2013 3 次提交
  2. 29 8月, 2013 4 次提交
  3. 31 7月, 2013 3 次提交
  4. 11 6月, 2013 1 次提交
  5. 26 4月, 2013 2 次提交
  6. 25 4月, 2013 1 次提交
  7. 28 2月, 2013 1 次提交
    • S
      hlist: drop the node parameter from iterators · b67bfe0d
      Sasha Levin 提交于
      I'm not sure why, but the hlist for each entry iterators were conceived
      
              list_for_each_entry(pos, head, member)
      
      The hlist ones were greedy and wanted an extra parameter:
      
              hlist_for_each_entry(tpos, pos, head, member)
      
      Why did they need an extra pos parameter? I'm not quite sure. Not only
      they don't really need it, it also prevents the iterator from looking
      exactly like the list iterator, which is unfortunate.
      
      Besides the semantic patch, there was some manual work required:
      
       - Fix up the actual hlist iterators in linux/list.h
       - Fix up the declaration of other iterators based on the hlist ones.
       - A very small amount of places were using the 'node' parameter, this
       was modified to use 'obj->member' instead.
       - Coccinelle didn't handle the hlist_for_each_entry_safe iterator
       properly, so those had to be fixed up manually.
      
      The semantic patch which is mostly the work of Peter Senna Tschudin is here:
      
      @@
      iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
      
      type T;
      expression a,c,d,e;
      identifier b;
      statement S;
      @@
      
      -T b;
          <+... when != b
      (
      hlist_for_each_entry(a,
      - b,
      c, d) S
      |
      hlist_for_each_entry_continue(a,
      - b,
      c) S
      |
      hlist_for_each_entry_from(a,
      - b,
      c) S
      |
      hlist_for_each_entry_rcu(a,
      - b,
      c, d) S
      |
      hlist_for_each_entry_rcu_bh(a,
      - b,
      c, d) S
      |
      hlist_for_each_entry_continue_rcu_bh(a,
      - b,
      c) S
      |
      for_each_busy_worker(a, c,
      - b,
      d) S
      |
      ax25_uid_for_each(a,
      - b,
      c) S
      |
      ax25_for_each(a,
      - b,
      c) S
      |
      inet_bind_bucket_for_each(a,
      - b,
      c) S
      |
      sctp_for_each_hentry(a,
      - b,
      c) S
      |
      sk_for_each(a,
      - b,
      c) S
      |
      sk_for_each_rcu(a,
      - b,
      c) S
      |
      sk_for_each_from
      -(a, b)
      +(a)
      S
      + sk_for_each_from(a) S
      |
      sk_for_each_safe(a,
      - b,
      c, d) S
      |
      sk_for_each_bound(a,
      - b,
      c) S
      |
      hlist_for_each_entry_safe(a,
      - b,
      c, d, e) S
      |
      hlist_for_each_entry_continue_rcu(a,
      - b,
      c) S
      |
      nr_neigh_for_each(a,
      - b,
      c) S
      |
      nr_neigh_for_each_safe(a,
      - b,
      c, d) S
      |
      nr_node_for_each(a,
      - b,
      c) S
      |
      nr_node_for_each_safe(a,
      - b,
      c, d) S
      |
      - for_each_gfn_sp(a, c, d, b) S
      + for_each_gfn_sp(a, c, d) S
      |
      - for_each_gfn_indirect_valid_sp(a, c, d, b) S
      + for_each_gfn_indirect_valid_sp(a, c, d) S
      |
      for_each_host(a,
      - b,
      c) S
      |
      for_each_host_safe(a,
      - b,
      c, d) S
      |
      for_each_mesh_entry(a,
      - b,
      c, d) S
      )
          ...+>
      
      [akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
      [akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
      [akpm@linux-foundation.org: checkpatch fixes]
      [akpm@linux-foundation.org: fix warnings]
      [akpm@linux-foudnation.org: redo intrusive kvm changes]
      Tested-by: NPeter Senna Tschudin <peter.senna@gmail.com>
      Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Signed-off-by: NSasha Levin <sasha.levin@oracle.com>
      Cc: Wu Fengguang <fengguang.wu@intel.com>
      Cc: Marcelo Tosatti <mtosatti@redhat.com>
      Cc: Gleb Natapov <gleb@redhat.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      b67bfe0d
  8. 16 2月, 2013 4 次提交
  9. 05 2月, 2013 3 次提交
  10. 01 2月, 2013 1 次提交
  11. 24 1月, 2013 2 次提交
  12. 22 11月, 2012 1 次提交
  13. 01 11月, 2012 2 次提交
  14. 23 10月, 2012 1 次提交
    • A
      ixgbe: Fix possible memory leak in ixgbe_set_ringparam · 1f4702aa
      Alexander Duyck 提交于
      We were not correctly freeing the temporary rings on error in
      ixgbe_set_ring_param.  In order to correct this I am unwinding a number of
      changes that were made in order to get things back to the original working
      form with modification for the current ring layouts.
      
      This approach has multiple advantages including a smaller memory footprint,
      and the fact that the interface is stopped while we are allocating the rings
      meaning that there is less potential for some sort of memory corruption on the
      ring.
      
      The only disadvantage I see with this approach is that on a Rx allocation
      failure we will report an error and only update the Tx rings.  However the
      adapter should be fully functional in this state and the likelihood of such
      an error is very low.  In addition it is not unreasonable to expect the
      user to need to recheck the ring configuration should they experience an
      error setting the ring sizes.
      Signed-off-by: NAlexander Duyck <alexander.h.duyck@intel.com>
      Tested-by: NPhil Schmitt <phillip.j.schmitt@intel.com>
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      1f4702aa
  15. 03 10月, 2012 1 次提交
  16. 19 7月, 2012 1 次提交
  17. 11 7月, 2012 1 次提交
  18. 20 6月, 2012 1 次提交
  19. 10 5月, 2012 2 次提交
  20. 04 5月, 2012 1 次提交
  21. 27 4月, 2012 1 次提交
  22. 20 3月, 2012 1 次提交
  23. 19 3月, 2012 1 次提交
  24. 17 3月, 2012 1 次提交
    • A
      ixgbe: Replace standard receive path with a page based receive · f800326d
      Alexander Duyck 提交于
      This patch replaces the existing Rx hot-path in the ixgbe driver with a new
      implementation that is based on performing a double buffered receive.  The
      ixgbe driver already had something similar in place for its' packet split
      path, however in that case we were still receiving the header for the
      packet into the sk_buff.  The big change here is the entire receive path
      will receive into pages only, and then pull the header out of the page and
      copy it into the sk_buff data.  There are several motivations behind this
      approach.
      
      First, this allows us to avoid several cache misses as we were taking a
      set of cache misses for allocating the sk_buff and then another set for
      receiving data into the sk_buff.  We are able to avoid these misses on
      receive now as we allocate the sk_buff when data is available.
      
      Second we are able to see a considerable performance gain when an IOMMU is
      enabled because we are no longer unmapping every buffer on receive.
      Instead we can delay the unmap until we are unable to use the page, and
      instead we can simply call sync_single_range on the half of the page that
      contains new data.
      
      Finally we are able to drop a considerable amount of code from the driver
      as we no longer have to support 2 different receive modes, packet split and
      one buffer.  This allows us to optimize the Rx path further since less
      branching is required.
      Signed-off-by: NAlexander Duyck <alexander.h.duyck@intel.com>
      Tested-by: NRoss Brattain <ross.b.brattain@intel.com>
      Tested-by: NStephen Ko <stephen.s.ko@intel.com>
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      f800326d