1. 21 6月, 2010 2 次提交
  2. 02 6月, 2010 1 次提交
    • J
      HID: roccat: introduce missing kfree · dfe5c7b7
      Julia Lawall 提交于
      Error handling code following a kmalloc should free the allocated data.
      
      The semantic match that finds the problem is as follows:
      (http://www.emn.fr/x-info/coccinelle/)
      
      // <smpl>
      @r exists@
      local idexpression x;
      statement S;
      expression E;
      identifier f,f1,l;
      position p1,p2;
      expression *ptr != NULL;
      @@
      
      x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
      ...
      if (x == NULL) S
      <... when != x
           when != if (...) { <+...x...+> }
      (
      x->f1 = E
      |
       (x->f1 == NULL || ...)
      |
       f(...,x->f1,...)
      )
      ...>
      (
       return \(0\|<+...x...+>\|ptr\);
      |
       return@p2 ...;
      )
      
      @script:python@
      p1 << r.p1;
      p2 << r.p2;
      @@
      
      print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
      // </smpl>
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      dfe5c7b7
  3. 31 5月, 2010 4 次提交
    • S
      HID: roccat: change kone_driver_version to kone_abi_version · 33ccbc32
      Stefan Achatz 提交于
      Renamed the sysfs attribute kone_driver_version to kone_abi_version and
      simplified returned data to integer.
      Signed-off-by: NStefan Achatz <erazor_de@users.sourceforge.net>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      33ccbc32
    • S
      HID: roccat: fix whitespace warning from checkpatch.pl · 22d51572
      Stefan Achatz 提交于
      Fixed the following warning of checkpatch.pl:
      WARNING: space prohibited between function name and open parenthesis '('
      Signed-off-by: NStefan Achatz <erazor_de@users.sourceforge.net>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      22d51572
    • S
      HID: roccat: remove obsolete comment · 597b49ec
      Stefan Achatz 提交于
      Removed comment that is obsolete since roccat char device is
      implemented
      Signed-off-by: NStefan Achatz <erazor_de@users.sourceforge.net>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      597b49ec
    • R
      rapidio: fix new kernel-doc warnings · 97ef6f74
      Randy Dunlap 提交于
      Fix a bunch of new rapidio kernel-doc warnings:
      
      Warning(include/linux/rio.h:123): No description found for parameter 'comp_tag'
      Warning(include/linux/rio.h:123): No description found for parameter 'phys_efptr'
      Warning(include/linux/rio.h:123): No description found for parameter 'em_efptr'
      Warning(include/linux/rio.h:123): No description found for parameter 'pwcback'
      Warning(include/linux/rio.h:247): No description found for parameter 'set_domain'
      Warning(include/linux/rio.h:247): No description found for parameter 'get_domain'
      Warning(drivers/rapidio/rio-scan.c:1133): No description found for parameter 'rdev'
      Warning(drivers/rapidio/rio-scan.c:1133): Excess function parameter 'port' description in 'rio_init_em'
      Warning(drivers/rapidio/rio.c:349): No description found for parameter 'rdev'
      Warning(drivers/rapidio/rio.c:349): Excess function parameter 'mport' description in 'rio_request_inb_pwrite'
      Warning(drivers/rapidio/rio.c:393): No description found for parameter 'port'
      Warning(drivers/rapidio/rio.c:393): No description found for parameter 'local'
      Warning(drivers/rapidio/rio.c:393): No description found for parameter 'destid'
      Warning(drivers/rapidio/rio.c:393): No description found for parameter 'hopcount'
      Warning(drivers/rapidio/rio.c:393): Excess function parameter 'rdev' description in 'rio_mport_get_physefb'
      Warning(drivers/rapidio/rio.c:845): Excess function parameter 'local' description in 'rio_std_route_clr_table'
      Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
      Cc: Alexandre Bounine <alexandre.bounine@idt.com>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      97ef6f74
  4. 29 5月, 2010 6 次提交
    • D
      drm/radeon: fix the r100/r200 ums block 0 page fix · cf22f20a
      Dave Airlie 提交于
      airlied -> brown paper bag.
      
      I blame Hi-5 or the Wiggles for lowering my IQ, move the fix inside some
      brackets instead of breaking everything in site.
      
      Cc: stable@kernel.org
      Signed-off-by: NDave Airlie <airlied@redhat.com>
      cf22f20a
    • V
      ACPI: Don't let acpi_pad needlessly mark TSC unstable · 0dc698b9
      Venkatesh Pallipadi 提交于
      acpi pad driver kind of aggressively marks TSC as unstable at init
      time, on mwait capable and non X86_FEATURE_NONSTOP_TSC systems. This is
      irrespective of whether pad driver is ever going to be used on the
      system or deep C-states are supported/used. This will affect every user
      who just happens to compile in (or get a kernel version which
      compiles in) acpi pad driver.
      
      Move mark_tsc_unstable() out of init to the actual idle invocation path
      of the pad driver.
      
      There is also another bug/missing_feature in the code that it does not
      support 'always running apic timer' and switches to broadcast mode
      unconditionally. Shaohua, can you take a look at that please.
      Signed-off-by: NVenkatesh Pallipadi <venki@google.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      0dc698b9
    • A
      drivers/acpi/sleep.h: Checkpatch cleanup · b6fecaa8
      Andrea Gelmini 提交于
      drivers/acpi/sleep.h:3: WARNING: space prohibited between function name and open parenthesis '('
      Signed-off-by: NAndrea Gelmini <andrea.gelmini@gelma.net>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      b6fecaa8
    • V
      ACPI: Minor cleanup eliminating redundant PMTIMER_TICKS to NS conversion · 2da513f5
      Venkatesh Pallipadi 提交于
      acpi_enter_[simple,bm] does
      idle timing in ns, convert it to timeval, then to us, then to
      pmtimer_ticks and then back to ns.
      
      This patch changes things to
      idle timing in ns, convert it to us, and then to pmtimer_ticks.
      
      Just saves an imul along this path, but makes the code cleaner.
      Signed-off-by: NVenkatesh Pallipadi <venki@google.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      2da513f5
    • L
      intel_idle: native hardware cpuidle driver for latest Intel processors · 26717172
      Len Brown 提交于
      This EXPERIMENTAL driver supersedes acpi_idle on
      Intel Atom Processors, Intel Core i3/i5/i7 Processors
      and associated Intel Xeon processors.
      
      It does not support the Intel Core2 processor or earlier.
      
      For kernels configured with ACPI, CONFIG_INTEL_IDLE=y
      allows intel_idle to probe before the ACPI processor driver.
      Booting with "intel_idle.max_cstate=0" disables intel_idle
      and the system will fall back on ACPI's "acpi_idle".
      
      Typical Linux distributions load ACPI processor module early,
      making CONFIG_INTEL_IDLE=m not easily useful on ACPI platforms.
      
      intel_idle probes all processors at module_init time.
      Processors that are hot-added later will be limited
      to using C1 in idle.
      Signed-off-by: NLen Brown <len.brown@intel.com>
      26717172
    • L
      ACPI: acpi_idle: touch TS_POLLING only in the non-MWAIT case · 02cf4f98
      Len Brown 提交于
      commit d306ebc2
      (ACPI: Be in TS_POLLING state during mwait based C-state entry)
      fixed an important power & performance issue where ACPI c2 and c3 C-states
      were clearing TS_POLLING even when using MWAIT (ACPI_STATE_FFH).
      That bug had been causing us to receive redundant scheduling interrups
      when we had already been woken up by MONITOR/MWAIT.
      
      Following up on that...
      
      In the MWAIT case, we don't have to subsequently
      check need_resched(), as that c heck was there
      for the TS_POLLING-clearing case.
      
      Note that not only does the cpuidle calling function
      already check need_resched() before calling us, the
      low-level entry into monitor/mwait calls it twice --
      guaranteeing that a write to the trigger address
      can not go un-noticed.
      
      Also, in this case, we don't have to set TS_POLLING
      when we wake, because we never cleared it.
      Signed-off-by: NLen Brown <len.brown@intel.com>
      Acked-by: NVenkatesh Pallipadi <venki@google.com>
      02cf4f98
  5. 28 5月, 2010 27 次提交