提交 · 0ac07ce022c8e0e1680e7576b97465a49ba7bbf0 · openeuler / raspberrypi-kernel

24 5月, 2014 40 次提交

staging: rtl8712: fix unnecessary parentheses · 0ac07ce0

由 Marcus Farkas 提交于 5月 17, 2014

This commit fixes the following checkpatch warnings:

rtl8712/rtl871x_security.c
    - 1167: WARNING: Unnecessary parentheses - maybe == should be = ?
    - 1374: WARNING: Unnecessary parentheses - maybe == should be = ?
Signed-off-by: NMarcus Farkas <marcus.farkas@finitebox.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

0ac07ce0

staging: rtl8712: fix missing blank lines after declarations · 4679934a

由 Marcus Farkas 提交于 5月 17, 2014

This commit fixes the following checkpatch warnings:

rtl8712/rtl871x_security.c
    - 275: WARNING: Missing a blank line after declarations
    - 768: WARNING: Missing a blank line after declarations
    - 801: WARNING: Missing a blank line after declarations
Signed-off-by: NMarcus Farkas <marcus.farkas@finitebox.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

4679934a

staging: rtl8712: fix potential leaks in r8712_set_key() · 2af9e74a

由 Christian Engelmayer 提交于 5月 07, 2014

Fix potential leaks in the error paths of r8712_set_key(). In case the
algorithm specific checks fail, the function returns without enqueuing
or freeing the already allocated command and parameter structs. Use a
centralized exit path and make sure that all memory is freed correctly.
Detected by Coverity - CID 144370, 144371.
Signed-off-by: NChristian Engelmayer <cengelma@gmx.at>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

2af9e74a

staging: rtl8712: fix potential leak in r871x_wx_set_enc_ext() · 55d4f6cc

由 Christian Engelmayer 提交于 5月 07, 2014

Fix a potential leak in the error path of r871x_wx_set_enc_ext(). In case the
requested algorithm is not supported by the driver, the function returns
without freeing the already allocated 'param' struct. Move the input
verification to the beginning of the function so that the direct return is
safe. Detected by Coverity - CID 144373.
Signed-off-by: NChristian Engelmayer <cengelma@gmx.at>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

55d4f6cc

staging: comedi: removing warnings reported by checkpatch tool on cb_pcimdas.c · 540958e2

由 Raghavendra Ganiga 提交于 5月 10, 2014

This is a patch to remove warnings reported
by checkpatch tool on cb_pcimdas.c file
Signed-off-by: NRaghavendra Chandra Ganiga <ravi23ganiga@gmail.com>
Reviewed-by: NIan Abbott <abbotti@mev.co.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

540958e2

staging: wlags49_h2: wl_priv: Remove useless return variables · 2b9d89dd

由 Peter Senna Tschudin 提交于 5月 20, 2014

This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>
Signed-off-by: NPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

2b9d89dd

staging: wlags49_h2: make return of 0 explicit · aac22d07

由 Julia Lawall 提交于 5月 19, 2014

Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@

-ret = 0;
... when != ret = e
return
- ret
+ 0
  ;
// </smpl>
Signed-off-by: NJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

aac22d07

staging : android: Fixes a coding style issue in timed_gpio.c · 27ea2f16

由 John Church 提交于 5月 07, 2014

This patch fixes a coding style issue for a line that was over 80 characters long.
Signed-off-by: NJohn Church <sleeveroller@gmail.com>
Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

27ea2f16

staging: rtl8188eu: os_dep: usb_intf.c: Fix to remove null pointer checks that could never happen · 89b90c68

由 Rickard Strandqvist 提交于 5月 22, 2014

Removal of null pointer checks that could never happen
Signed-off-by: NRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: NJosh Triplett <josh@joshtriplett.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

89b90c68

staging: rtl8188eu: Do not byteswap half initialized variable · d6c455ac

由 Jes Sorensen 提交于 5月 19, 2014

Copying 16 bits into an uninitialized 32 bit stack variable and then
byteswapping it can provide 'interesting' results.
Signed-off-by: NJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

d6c455ac

N
staging: rtl8188eu:Remove function with empty defination odm_DynamicPrimaryCCA() · b5e1e912
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
b5e1e912
N
staging: rtl8188eu: Remove unused function ODM_DynamicPrimaryCCA_DupRTS() · fce87279
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
fce87279

staging: rtl8188eu: Remove unused function DM_DIG_LowerBound_88E() · 5aac98ab

由 navin patidar 提交于 5月 18, 2014

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

5aac98ab

N
staging: rtl8188eu: Remove function with empty defination ODM_CheckPowerStatus() · 2c4c9a51
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
2c4c9a51

staging: rtl8188eu: Remove unused function ConvertTo_dB() · 293f6c08

由 navin patidar 提交于 5月 18, 2014

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

293f6c08

N
staging: rtl8188eu: Remove unused function odm_SwAntDivChkAntSwitchCallback() · ddd0d480
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
ddd0d480

staging: rtl8188eu: Remove unused funtion odm_DynamicTxPowerNIC() · 36622c97

由 navin patidar 提交于 5月 18, 2014

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

36622c97

N
staging: rtl8188eu: Remove unused function odm_RefreshRateAdaptiveMaskAPADSL() · ba727007
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
ba727007
N
staging: rtl8188eu: Remove unused function odm_RefreshRateAdaptiveMaskMP() · 53760485
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
53760485

staging:rtl8188eu: Remove unused function iodm_1R_CCA() · bd645d88

由 navin patidar 提交于 5月 18, 2014

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

bd645d88

N
staging: rtl8188eu: Remove unused function odm_DynamicBBPowerSavingInit() · 06dd47e3
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
06dd47e3

staging: rtl8188eu: Remove function odm_DynamicBBPowerSaving() · 86ff6440

由 navin patidar 提交于 5月 18, 2014

odm_DynamicBBPowerSaving() has empty defination.
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

86ff6440

staging: rtl8188eu: Remove unused function odm_DIGbyRSSI_LPS() · ffb25070

由 navin patidar 提交于 5月 18, 2014

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

ffb25070

N
staging: rtl8188eu: Remove unused function rtl8188e_RF_ChangeTxPath() · ef8e0bae
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
ef8e0bae

staging: rtl8188eu: Remove unused structure rf_shadow · 0149a62f

由 navin patidar 提交于 5月 18, 2014

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

0149a62f

N
staging: rtl8188eu: Remove unused funtion PHY_ScanOperationBackup8188E() · 914df7f8
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
914df7f8

staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm() · a25d2594

由 navin patidar 提交于 5月 18, 2014

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

a25d2594

N
staging: rtl8188eu: Remove unused funtion PHY_GetTxPowerLevel8188E() · 9a696fe1
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
9a696fe1

staging:rtl8188eu: Remove unused function phy_DbmToTxPwrIdx() · aae8993c

由 navin patidar 提交于 5月 18, 2014

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

aae8993c

N
staging: rtl8188eu: Remove unused function PHY_UpdateTxPowerDbm8188E() · ba814a24
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
ba814a24
N
staging: rtl8188eu: Remove unused function rtl8192c_PHY_GetHWRegOriginalValue() · 9578c308
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
9578c308
N
staging: rtl8188eu: Remove unused function rtl8188e_PHY_ConfigRFWithParaFile() · b204bc24
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
b204bc24

staging:rtl8188eu:Remove funtion Hal_CustomizeByCustomerID_8188EU() · 994d7781

由 navin patidar 提交于 5月 18, 2014

Function has empty defination.
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

994d7781

staging: rtl8188eu: Remove unused function _ps_close_RF() · 3cf2f015

由 navin patidar 提交于 5月 18, 2014

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

3cf2f015

N
staging: rtl8188eu: Remove function with empty definition _ps_open_RF() · 0f657d1b
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
0f657d1b
N
staging: rtl8188eu: Remove function with empty definition _InitOperationMode() · 8a39ec22
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
8a39ec22
N
staging: rtl8188eu: Remove function with empty definition _InitBeaconMaxError(). · 5751dfc1
由 navin patidar 提交于 5月 18, 2014
```
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
```
5751dfc1

staging: rtl8188eu: remove dead code in rtw_drv_init() · b8f6ad08

由 Christian Engelmayer 提交于 5月 17, 2014

(status != _SUCCESS) immediately after 'status = _SUCCESS' will never evaluate
true. Thus remove the logically dead code. Detected by Coverity - CID 1077553.
Signed-off-by: NChristian Engelmayer <cengelma@gmx.at>
Acked-by: NJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

b8f6ad08

staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init() · 9eb6f16d

由 Christian Engelmayer 提交于 5月 17, 2014

Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS
as long as not explicitly set. Thus initialize 'status' to FAIL, in order to
prevent undefined behaviour if going through the exit paths. Detected by
Coverity - CID 1077832.
Signed-off-by: NChristian Engelmayer <cengelma@gmx.at>
Acked-by: NJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

9eb6f16d

staging: rtl8188eu: fix potential leak in rtw_set_key() · e0c49319

由 Christian Engelmayer 提交于 5月 07, 2014

Fix a potential leak in the error path of rtw_set_key(). In case the requested
algorithm is not supported by the driver, the function returns without
enqueuing or freeing the already allocated command and parameter structs. Use
a centralized exit path and make sure that all memory is freed correctly.
Detected by Coverity - CID 1077716, 1077717.
Signed-off-by: NChristian Engelmayer <cengelma@gmx.at>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

e0c49319