Replace occurrences of 'if (<bool expr> == <1|0>)' with
'if ([!]<bool expr>)'

Replace occurrences of '<bool var> = (<non-bool expr>) ? true : false'
with '<bool var> = <non-bool expr>'.

Replace occurrence of '<bool var> = <non-bool expr>' with
'<bool var> = !!<non-bool expr>'

While the latter replacement is not really necessary, it is done here for
consistency and clarity.  No functional changes.
Signed-off-by: NBruce Allan <bruce.w.allan@intel.com>
Tested-by: NAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>

Now that split strings generate checkpatch warnings (per Chapter 2 of
Documentation/CodingStyle to make it easier to grep the code for the
string) cleanup the remaining instances of them in the driver.
Signed-off-by: NBruce Allan <bruce.w.allan@intel.com>
Tested-by: NAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>

This patch enables software (and phy device) transmit time stamping.
Tested on an old PIII laptop with built in NIC.
Signed-off-by: NRichard Cochran <richardcochran@gmail.com>
Tested-by: NAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>

Signed-off-by: NRichard Cochran <richardcochran@gmail.com>
Tested-by: NAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>

This fixes possible null dereference in probe() function: when both
.mac_addr and .link_gpio are unknown, dev.platform_data may be NULL
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NMike Sinkovsky <msink@permonline.ru>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Signed-off-by: NJim Cromie <jim.cromie@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Signed-off-by: NJim Cromie <jim.cromie@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Signed-off-by: NJim Cromie <jim.cromie@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Signed-off-by: NFlorian Fainelli <florian@openwrt.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Define and use the bits of the PHY_CC (status change configuration) register.
Signed-off-by: NFlorian Fainelli <florian@openwrt.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Define MTPR bit 0 of the register and use it where it is appropriate.
Signed-off-by: NFlorian Fainelli <florian@openwrt.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Define the MLSR (MAC Last Status Register bits) for:
- tx fifo under-run
- tx exceed collision
- tx late collision
Signed-off-by: NFlorian Fainelli <florian@openwrt.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

We are currently updating the rx fifo error counter in the tx path while
it should have been the tx fifo error counter, fix that.
Signed-off-by: NFlorian Fainelli <florian@openwrt.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

2048 is the usual value for busy-waiting on a register r/w, define it
as MAC_DEF_TIMEOUT and use it where it is appropriate.
Signed-off-by: NFlorian Fainelli <florian@openwrt.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Signed-off-by: NFlorian Fainelli <florian@openwrt.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

The reset of the MAC is currently done identically from two places
and one place is not waiting for the MAC_SM bit to be set after reset.
Everytime the MAC is software resetted a state machine is also needed
so consolidate the reset to its own function.
Signed-off-by: NFlorian Fainelli <florian@openwrt.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

m68k/allmodconfig:

drivers/net/ethernet/wiznet/w5100.c: In function ‘w5100_hw_probe’:
drivers/net/ethernet/wiznet/w5100.c:680: error: ‘IRQ_TYPE_LEVEL_LOW’ undeclared (first use in this function)
drivers/net/ethernet/wiznet/w5300.c: In function ‘w5300_hw_probe’:
drivers/net/ethernet/wiznet/w5300.c:594: error: ‘IRQ_TYPE_LEVEL_LOW’ undeclared (first use in this function)

Include <linux/irq.h>, which provides the declaration for IRQ_TYPE_LEVEL_LOW.
Signed-off-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

This option was there for debugging race conditions,
just remove it, and assume TX_FLOW is always enabled.
Signed-off-by: NMike Sinkovsky <msink@permonline.ru>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Both drivers need to depend upon HAS_IOMEM, otherwise we
get a build failure on platforms like S390.

All the driver specific config options need to depend upon
the drivers themselves.
Reported-by: NStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Jon Mason <mason@myri.com>
Acked-by: NAndrew Gallatin <gallatin@myri.com>

- pci_resource_start() can be removed from sis900_get_mac_addr() because
  the IO range is maped and stored into the device private struct early
  in the device probe function.
- the driver contains a few direct accesses to low IO ports that forbid
  to re(#)define the usual out{l, w, b} macros.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Daniele Venzano <venza@brownhat.org>

This is a pure PCI driver, no ISA here.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Acked-by: NGrant Grundler <grundler@parisc-linux.org>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

The bulk of the patch comes from the __iomem changes.

- the phy read and write operations were carrying the chip id deep
  down the call chain. Let's waste a pointer and contain the flying
  spaghetti monster.
- phy_{read, write}_1bit only need to access the DCR9 register. The loss
  of generality here should not hurt.
- removed a leftover printk of the EISA era. This is a pure PCI device.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Acked-by: NGrant Grundler <grundler@parisc-linux.org>

The eeprom registers always use the same PCI bar whereas the general
registers may either use the same mapping as the eeprom registers or
a different one. It is thus possible to simplify parse_eeprom().
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

It's useless to check mem_start on a newly allocated device.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Tim Hockin <thockin@hockin.org>

The device private data pointer can not be NULL in smsc9420_open().
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Steve Glendinning <steve.glendinning@smsc.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Acked-by: NGrant Grundler <grundler@parisc-linux.org>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Acked-by: NGrant Grundler <grundler@parisc-linux.org>

- unbalanced pci_disable_device
- PCI ressources were not released
- mismatching pci_alloc_.../kfree pairs are replaced by DMA alloc helpers.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Ack-by: NGrant Grundler <grundler@parisc-linux.org>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Ack-by: NGrant Grundler <grundler@parisc-linux.org>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Ack-by: NGrant Grundler <grundler@parisc-linux.org>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Acked-by: NMichael Chan <mchan@broadcom.com>

Some settings are duplicated between ethtool link management and module
options. The latter is trimmed. The half duplex, speed and autonegotiation
defaults are kept unchanged.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Ion Badulescu <ionut@badula.org>