1. 22 6月, 2012 1 次提交
    • I
      wlcore: Change read/write ops to return errors · 02eb1d9d
      Ido Yariv 提交于
      While bus operations may fail, either due to HW or FW issues, these are
      never propagated to higher layers. As a result, the core driver has no
      way of knowing that the operations failed, and will only recover if high
      level logic requires it (e.g. no command completion).
      
      Change read/write bus operations to return errors to let higher layer
      functionality handle these.
      Signed-off-by: NIdo Yariv <ido@wizery.com>
      Signed-off-by: NLuciano Coelho <coelho@ti.com>
      02eb1d9d
  2. 12 4月, 2012 4 次提交
  3. 15 2月, 2012 2 次提交
  4. 29 11月, 2011 1 次提交
    • L
      wireless: Remove redundant spi driver bus initialization · 4e3309ba
      Lars-Peter Clausen 提交于
      In ancient times it was necessary to manually initialize the bus field of an
      spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
      so we can drop the manual assignment.
      
      The patch was generated using the following coccinelle semantic patch:
      // <smpl>
      @@
      identifier _driver;
      @@
      struct spi_driver _driver = {
      	.driver = {
      -		.bus = &spi_bus_type,
      	},
      };
      // </smpl>
      Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
      Cc: Dan Williams <dcbw@redhat.com>
      Cc: "John W. Linville" <linville@tuxdriver.com>
      Cc: Christian Lamparter <chunkeey@googlemail.com>
      Cc: Luciano Coelho <coelho@ti.com>
      Cc: libertas-dev@lists.infradead.org
      Cc: linux-wireless@vger.kernel.org
      Acked-by: NLuciano Coelho <coelho@ti.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      4e3309ba
  5. 12 10月, 2011 1 次提交
    • L
      wl12xx: use the same plat dev name for both SPI and SDIO · ccb62000
      Luciano Coelho 提交于
      There's no need to have the bus name included in the platform device
      name that we create.  The core driver doesn't need to know about the
      type of bus it uses.  Any differences between the buses that need to
      be handled differently in the core, can be passed in the platform data
      (as the pwr_in_suspend boolean does).
      
      Use "wl12xx" for the device name in both bus drivers.  Rename the
      platform driver name to "wl12xx_driver", just to differentiate from
      the platform device names.
      Signed-off-by: NLuciano Coelho <coelho@ti.com>
      ccb62000
  6. 11 10月, 2011 5 次提交
  7. 22 8月, 2011 1 次提交
  8. 27 6月, 2011 1 次提交
  9. 07 6月, 2011 1 次提交
  10. 19 4月, 2011 5 次提交
  11. 05 4月, 2011 1 次提交
  12. 03 3月, 2011 2 次提交
    • I
      wl12xx: Switch to level trigger interrupts · 2da69b89
      Ido Yariv 提交于
      The interrupt of the wl12xx is a level interrupt in nature, since the
      interrupt line is not auto-reset. However, since resetting the interrupt
      requires bus transactions, this cannot be done from an interrupt
      context. Thus, requesting a level interrupt would require to disable the
      irq and re-enable it after the HW is acknowledged. Since we now request
      a threaded irq, this can also be done by specifying the IRQF_ONESHOT
      flag.
      
      Triggering on an edge can be problematic in some platforms, if the
      sampling frequency is not sufficient for detecting very frequent
      interrupts. In case an interrupt is missed, the driver will hang as the
      interrupt line will stay high until it is acknowledged by the driver,
      which will never happen.
      
      Fix this by requesting a level triggered interrupt, with the
      IRQF_ONESHOT flag.
      Signed-off-by: NIdo Yariv <ido@wizery.com>
      Reviewed-by: NLuciano Coelho <coelho@ti.com>
      Signed-off-by: NLuciano Coelho <coelho@ti.com>
      2da69b89
    • I
      wl12xx: Switch to a threaded interrupt handler · a620865e
      Ido Yariv 提交于
      To achieve maximal throughput, it is very important to react to
      interrupts as soon as possible. Currently the interrupt handler wakes up
      a worker for handling interrupts in process context. A cleaner and more
      efficient design would be to request a threaded interrupt handler.  This
      handler's priority is very high, and can do blocking operations such as
      SDIO/SPI transactions.
      
      Some work can be deferred, mostly calls to mac80211 APIs
      (ieee80211_rx_ni and ieee80211_tx_status). By deferring such work to a
      different worker, we can keep the irq handler thread more I/O
      responsive. In addition, on multi-core systems the two threads can be
      scheduled on different cores, which will improve overall performance.
      
      The use of WL1271_FLAG_IRQ_PENDING & WL1271_FLAG_IRQ_RUNNING was
      changed. For simplicity, always query the FW for more pending
      interrupts. Since there are relatively long bursts of interrupts, the
      extra FW status read overhead is negligible. In addition, this enables
      registering the IRQ handler with the ONESHOT option.
      Signed-off-by: NIdo Yariv <ido@wizery.com>
      Reviewed-by: NLuciano Coelho <coelho@ti.com>
      Signed-off-by: NLuciano Coelho <coelho@ti.com>
      a620865e
  13. 01 2月, 2011 1 次提交
  14. 25 1月, 2011 2 次提交
  15. 22 11月, 2010 1 次提交
  16. 05 10月, 2010 1 次提交
  17. 28 9月, 2010 1 次提交
  18. 21 9月, 2010 3 次提交
  19. 05 8月, 2010 1 次提交
  20. 07 7月, 2010 1 次提交
  21. 01 4月, 2010 3 次提交
  22. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6