提交 fecdf8be 编写于 作者: O Oleg Nesterov 提交者: David S. Miller

net: pktgen: fix race between pktgen_thread_worker() and kthread_stop()

pktgen_thread_worker() is obviously racy, kthread_stop() can come
between the kthread_should_stop() check and set_current_state().
Signed-off-by: NOleg Nesterov <oleg@redhat.com>
Reported-by: NJan Stancek <jstancek@redhat.com>
Reported-by: NMarcelo Leitner <mleitner@redhat.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 4a0e3e98
...@@ -3572,8 +3572,10 @@ static int pktgen_thread_worker(void *arg) ...@@ -3572,8 +3572,10 @@ static int pktgen_thread_worker(void *arg)
pktgen_rem_thread(t); pktgen_rem_thread(t);
/* Wait for kthread_stop */ /* Wait for kthread_stop */
while (!kthread_should_stop()) { for (;;) {
set_current_state(TASK_INTERRUPTIBLE); set_current_state(TASK_INTERRUPTIBLE);
if (kthread_should_stop())
break;
schedule(); schedule();
} }
__set_current_state(TASK_RUNNING); __set_current_state(TASK_RUNNING);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册