提交 f8e8be1c 编写于 作者: J Julia Lawall 提交者: David S. Miller

fec_mpc52xx: delete unneeded test before of_node_put

Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>
Signed-off-by: NJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 6a3e6aa1
...@@ -1015,8 +1015,7 @@ mpc52xx_fec_remove(struct platform_device *op) ...@@ -1015,8 +1015,7 @@ mpc52xx_fec_remove(struct platform_device *op)
unregister_netdev(ndev); unregister_netdev(ndev);
if (priv->phy_node) of_node_put(priv->phy_node);
of_node_put(priv->phy_node);
priv->phy_node = NULL; priv->phy_node = NULL;
irq_dispose_mapping(ndev->irq); irq_dispose_mapping(ndev->irq);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册